From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Evandro Menezes <e.menezes@samsung.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
nd <nd@arm.com>, Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
Kyrylo Tkachov <Kyrylo.Tkachov@arm.com>,
James Greenhalgh <James.Greenhalgh@arm.com>
Subject: Re: [PATCH][AArch64] Replace insn to zero up DF register
Date: Fri, 26 Feb 2016 12:37:00 -0000 [thread overview]
Message-ID: <AM3PR08MB00887106972C8DCA02A635A283A70@AM3PR08MB0088.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <56A94F35.8000000@samsung.com>
Evandro Menezes <e.menezes@samsung.com> wrote:
>
> I have a question though: is it necessary to add the "fp" and "simd"
> attributes to both movsf_aarch64 and movdf_aarch64 as well?
You need at least the "simd" attribute, but providing "fp" as well is clearer
(in principle the TARGET_FLOAT check in the pattern condition is
redundant as a result, but the movhf and movtf patterns already do both).
Also you want to use the smallest possible SIMD size as these are
scalar operations and some microarchitectures execute 64-bit operations
more efficiently than 128-bit ones, so:
mov\\t%0.h[0], %w1
+ movi\\t%0.4h, #0
umov\\t%w0, %1.h[0]
fmov\\t%s0, %w1
+ movi\\t%0.2s, #0
fmov\\t%w0, %s1
With those changes it should be ready for commit once you get the OK from James/Marcus.
Wilco
next prev parent reply other threads:[~2016-02-26 12:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 13:52 Wilco Dijkstra
2016-01-27 23:14 ` Evandro Menezes
2016-02-26 12:37 ` Wilco Dijkstra [this message]
2016-02-26 22:43 ` Evandro Menezes
2016-02-29 18:07 ` Wilco Dijkstra
2016-02-29 23:11 ` Evandro Menezes
2016-03-01 19:02 ` Wilco Dijkstra
2016-03-01 19:08 ` Evandro Menezes
2016-03-09 21:36 ` Evandro Menezes
2016-03-10 13:23 ` James Greenhalgh
2016-03-10 16:27 ` Evandro Menezes
2016-03-10 16:32 ` Evandro Menezes
2016-03-10 16:37 ` James Greenhalgh
2016-04-25 19:20 ` [PATCH][AArch64] Replace insn to zero up SIMD registers Evandro Menezes
2016-04-26 13:25 ` Wilco Dijkstra
2016-04-27 19:55 ` Evandro Menezes
-- strict thread matches above, loose matches on Subject: below --
2015-10-19 23:41 [PATCH][AArch64] Replace insn to zero up DF register Evandro Menezes
2015-10-19 23:52 ` Andrew Pinski
2015-10-20 0:33 ` Andrew Pinski
2015-10-20 14:46 ` Andrew Pinski
2015-10-28 18:49 ` Evandro Menezes
2015-10-30 10:26 ` Marcus Shawcroft
2015-11-09 22:59 ` Evandro Menezes
2015-12-03 21:01 ` Evandro Menezes
2015-11-19 22:01 ` Evandro Menezes
2015-12-16 21:30 ` Evandro Menezes
2016-01-13 0:06 ` Evandro Menezes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM3PR08MB00887106972C8DCA02A635A283A70@AM3PR08MB0088.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=James.Greenhalgh@arm.com \
--cc=Kyrylo.Tkachov@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=e.menezes@samsung.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).