From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Richard Henderson <rth@redhat.com>,
Christophe Lyon <christophe.lyon@linaro.org>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, nd <nd@arm.com>
Subject: Re: [PATCH] Fix aarch64 bootstrap (pr69416)
Date: Mon, 25 Jan 2016 18:32:00 -0000 [thread overview]
Message-ID: <AM3PR08MB0088717DD3402CBC7BB9BBAA83C70@AM3PR08MB0088.eurprd08.prod.outlook.com> (raw)
Richard Henderson wrote:
> On 01/25/2016 05:28 AM, Christophe Lyon wrote:
> > After this, I'm seeing this test now FAILs:
> > gcc.target/aarch64/ccmp_1.c scan-assembler adds\t
>
> That test case is badly written. In addition to that one, several of the other
> failures that I see within that file are simply equally optimal alternative
> choices for the compiler. The file needs to be split up and simpler more
> directed tests written.
The test case was written specifically to emit 'adds' as that is the optimal
sequence. It is a regression caused by wrapping the immediate in a unspec which
disables costing of all CCMPs... I have a patch for this.
The zero issue is due to the testcase assuming GCC emits '0' and 'wzr' correctly -
it was based on a very old patch that emits the correct zero for compares that hasn't
been OK'd yet. And the failure to emit an fccmp is due to a recent fix to NaN handling
in compares, so that testcase now needs -ffinite-math-only.
Wilco
next reply other threads:[~2016-01-25 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 18:32 Wilco Dijkstra [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-22 17:07 Richard Henderson
2016-01-22 17:11 ` Richard Earnshaw (lists)
2016-01-25 13:28 ` Christophe Lyon
2016-01-25 16:27 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM3PR08MB0088717DD3402CBC7BB9BBAA83C70@AM3PR08MB0088.eurprd08.prod.outlook.com \
--to=wilco.dijkstra@arm.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=nd@arm.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).