From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Denis Campredon <denis.campredon@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>,
Jason Merrill <jason@redhat.com>
Subject: Re: [PATCHv2] Add a warning for suspicious use of conditional expressions in boolean context
Date: Mon, 05 Sep 2016 20:03:00 -0000 [thread overview]
Message-ID: <AM4PR0701MB216219EA8D327E25AAB0AE2FE4E60@AM4PR0701MB2162.eurprd07.prod.outlook.com> (raw)
In-Reply-To: <CAPWdEev7VW5LT47iPh-0EgAJz5ELEnoZ_snLtg-F5ZR+etLimg@mail.gmail.com>
On 09/05/16 21:23, Denis Campredon wrote:
> Hi,
> Your patch does not emit warning for the following case:
> void f(int j){bool i = j ?: 3;}
>
> But for emit one for
> void f(){bool i = 4 ?: 2;}
> Regards
>
Yes, good point.
It is probably not completely unrealistic
that the middle expression may be accidentally
left out?
The first example is a bit too complicated, because
the warning does only work with integer constants
in the moment, but "j ?: 3" is expanded as "j ? j : 3",
while "4 ?: 2" is expanded as "4 ? 4 : 2" which
matches the check.
I'm not sure if detecting the special case j ?: 3
is worth the effort, but it may be doable.
Should I try that as a follow-up patch?
Thanks
Bernd.
next prev parent reply other threads:[~2016-09-05 20:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 18:53 [PATCH] " Bernd Edlinger
2016-09-04 8:45 ` [PATCHv2] " Bernd Edlinger
2016-09-05 11:41 ` Joseph Myers
2016-09-05 14:59 ` Bernd Edlinger
2016-09-05 16:57 ` Joseph Myers
[not found] ` <CAPWdEev7VW5LT47iPh-0EgAJz5ELEnoZ_snLtg-F5ZR+etLimg@mail.gmail.com>
2016-09-05 20:03 ` Bernd Edlinger [this message]
2016-09-12 19:40 ` [PATCH] " Jeff Law
2016-09-12 20:02 ` Bernd Edlinger
2016-09-12 20:18 ` Jeff Law
2016-09-12 21:28 ` Bernd Edlinger
2016-09-14 16:14 ` [PATCH, updated] " Bernd Edlinger
2016-09-14 16:50 ` Jason Merrill
2016-09-14 17:41 ` Bernd Edlinger
2016-09-14 19:04 ` Jason Merrill
[not found] ` <AM4PR0701MB2162B5B8246F8A10B4B6E42CE4F10@AM4PR0701MB2162.eurprd07.prod.outlook.com>
2016-09-14 20:17 ` [PATCHv3] " Bernd Edlinger
2016-09-15 15:52 ` [PATCH, updated] " Jeff Law
2016-09-15 16:20 ` Bernd Edlinger
2016-09-15 16:36 ` Jeff Law
2016-09-15 16:51 ` Bernd Edlinger
2016-09-15 19:21 ` Joseph Myers
2016-09-15 20:34 ` Jason Merrill
2016-09-15 20:45 ` Bernd Edlinger
2016-09-14 17:54 ` Steve Kargl
2016-09-14 17:56 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM4PR0701MB216219EA8D327E25AAB0AE2FE4E60@AM4PR0701MB2162.eurprd07.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=denis.campredon@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).