From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94554 invoked by alias); 14 Sep 2016 17:54:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 94510 invoked by uid 89); 14 Sep 2016 17:54:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-spam-relays-external:sk:COL004-, H*RU:sk:COL004-, HX-HELO:sk:COL004-, Hx-spam-relays-external:sk:col004- X-Spam-User: qpsmtpd, 2 recipients X-HELO: COL004-OMC2S18.hotmail.com Received: from col004-omc2s18.hotmail.com (HELO COL004-OMC2S18.hotmail.com) (65.55.34.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Sep 2016 17:54:37 +0000 Received: from EUR03-AM5-obe.outbound.protection.outlook.com ([65.55.34.72]) by COL004-OMC2S18.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Wed, 14 Sep 2016 10:54:36 -0700 Received: from DB5EUR03FT033.eop-EUR03.prod.protection.outlook.com (10.152.20.57) by DB5EUR03HT017.eop-EUR03.prod.protection.outlook.com (10.152.21.118) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.619.6; Wed, 14 Sep 2016 17:54:33 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com (10.152.20.57) by DB5EUR03FT033.mail.protection.outlook.com (10.152.20.76) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.619.6 via Frontend Transport; Wed, 14 Sep 2016 17:54:32 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) by AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) with mapi id 15.01.0619.011; Wed, 14 Sep 2016 17:54:31 +0000 From: Bernd Edlinger To: "kargl@uw.edu" CC: Jeff Law , "gcc-patches@gcc.gnu.org" , Joseph Myers , "Jason Merrill" , "fortran@gcc.gnu.org" Subject: Re: [PATCH, updated] Add a warning for suspicious use of conditional expressions in boolean context Date: Wed, 14 Sep 2016 17:56:00 -0000 Message-ID: References: <4fd68972-b48b-560a-b8e2-ae7d607b9b87@redhat.com> <48602fe1-c295-fce5-a6fe-e7e259532f44@redhat.com> <20160914174058.GB77830@troutmask.apl.washington.edu> In-Reply-To: <20160914174058.GB77830@troutmask.apl.washington.edu> authentication-results: spf=softfail (sender IP is 10.152.20.57) smtp.mailfrom=hotmail.de; uw.edu; dkim=none (message not signed) header.d=none;uw.edu; dmarc=none action=none header.from=hotmail.de; received-spf: SoftFail (protection.outlook.com: domain of transitioning hotmail.de discourages use of 10.152.20.57 as permitted sender) x-ms-exchange-messagesentrepresentingtype: 1 x-eopattributedmessage: 0 x-microsoft-exchange-diagnostics: 1;DB5EUR03HT017;6:+28WV82DcUKqyEARoZ+ayPvtxDHDx0IL1+Hnpzcs8UTVh3RPsZwTka/9OoR1MF0hWoi2eaanxMNYBR14U238yz3d/0/CraYH2rzU73N6zbRm2b6GhHCMyJc+RvAdMcPM5NjNlnahR64lfFH7/aI/l/X+i1FQZ4R1l6e0uX7KzMV4ZAoeiiyN4TDNpplNhgdEMjTk3tChqfx6FtalolP6ehEBxzPNYp/Jr6hXpTWn5TEICxj05lKGQI94Gq0kveUBCFzwwYpJmJMVVBukgq/dxBrndx3ep+YPTYKoDnC9PlU=;5:pe0JE/zVd/8VR8RpS3WKwroW/7Pa2QV1epeWeM+g+d1jVJ99RBVqlnsjkg5cMxTqBF3ACc/V+rpowxWxMiWcWywNZ075f9VSbA4oKpnDzUUEhABBsZ70RUUZHtsZ34q582stFCTO38HXb8qOEODagQ==;24:bfesxTjWoAJQr7WGjpMhrK/W9Ay13lJdjr/meil9j25W7+2BoVEaaKm7Cda3ar97J41ao9Sx0Oc8Wd8agrVbPnZOZI+9wwKGJBElQJFkSOM=;7:Fo50zJtJGqjFLCU4m0Mme3Ff8td0Oc6ZYo3XD3WoS7N4aMQtjPbWvs8xweBvv0xeFpibdiJH49sNMTtT74MFCTxjoOxvT3/Aq1yVhQHO6HfjVzU89GTVQsrkVlzHsNwY/DuymMy06GSACu0ZEhDMuyuoVSlv9/atS3hzUJxCLcbV5j61ll3txC+8jR467DIoSFZ0LzQ0QWX63R73j79rHzEbhrcwmQyf1pJZdohsFavQ0iuhEZi+qVhKCtY3dHyE x-forefront-antispam-report: EFV:NLI;SFV:NSPM;SFS:(10019020)(98900003);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5EUR03HT017;H:AM4PR0701MB2162.eurprd07.prod.outlook.com;FPR:;SPF:None;LANG:en; x-ms-office365-filtering-correlation-id: 6887b54c-96d4-4b56-155b-08d3dcc82dec x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(1601124038)(1603103081)(1601125047);SRVR:DB5EUR03HT017; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(432015012)(82015046);SRVR:DB5EUR03HT017;BCL:0;PCL:0;RULEID:;SRVR:DB5EUR03HT017; x-forefront-prvs: 006546F32A spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: <07D1270520F78A4789DF8EF49A290CB1@eurprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Sep 2016 17:54:31.9445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5EUR03HT017 X-SW-Source: 2016-09/txt/msg00866.txt.bz2 On 09/14/16 19:40, Steve Kargl wrote: > On Wed, Sep 14, 2016 at 04:10:46PM +0000, Bernd Edlinger wrote: >> >> fortran: >> 2016-09-14 Bernd Edlinger >> >> PR c++/77434 >> * simplify.c (gfc_simplify_repeat): Fix a warning. >> >> Index: gcc/fortran/simplify.c >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> --- gcc/fortran/simplify.c (revision 240135) >> +++ gcc/fortran/simplify.c (working copy) >> @@ -5127,7 +5127,7 @@ gfc_simplify_repeat (gfc_expr *e, gfc_expr *n) >> >> if (len || >> (e->ts.u.cl->length && >> - mpz_sgn (e->ts.u.cl->length->value.integer)) !=3D 0) >> + mpz_sgn (e->ts.u.cl->length->value.integer) !=3D 0)) >> { >> const char *res =3D gfc_extract_int (n, &ncop); >> gcc_assert (res =3D=3D NULL); > > This part should be committed regardless of the > outcome of a review of the complete patch. The > closing ')' is clearly missed placed. > OK, thanks, then I will go ahead and commit that one as obvious. Bernd.