From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109705 invoked by alias); 12 Sep 2016 22:02:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 109695 invoked by uid 89); 12 Sep 2016 22:02:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=peters, Peters, Hx-spam-relays-external:10.152.0.52, Peter's X-HELO: BAY004-OMC4S12.hotmail.com Received: from bay004-omc4s12.hotmail.com (HELO BAY004-OMC4S12.hotmail.com) (65.54.190.214) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Sep 2016 22:02:09 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com ([65.54.190.201]) by BAY004-OMC4S12.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Mon, 12 Sep 2016 15:02:08 -0700 Received: from HE1EUR01FT007.eop-EUR01.prod.protection.outlook.com (10.152.0.52) by HE1EUR01HT023.eop-EUR01.prod.protection.outlook.com (10.152.0.242) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.619.6; Mon, 12 Sep 2016 22:01:57 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com (10.152.0.58) by HE1EUR01FT007.mail.protection.outlook.com (10.152.1.243) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.619.6 via Frontend Transport; Mon, 12 Sep 2016 22:01:56 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) by AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) with mapi id 15.01.0619.011; Mon, 12 Sep 2016 22:01:56 +0000 From: Bernd Edlinger To: Jeff Law , Kyrill Tkachov , Peter Bergner CC: Andrew Pinski , GCC Patches , Vladimir Makarov , Bill Schmidt Subject: Re: [PATCH] Fix aarch64 fallout of [PATCH, LRA] Fix PR rtl-optimization 77289, LRA matching constraint problem Date: Mon, 12 Sep 2016 22:06:00 -0000 Message-ID: References: <57D6A451.1030700@foss.arm.com> In-Reply-To: authentication-results: spf=softfail (sender IP is 10.152.0.58) smtp.mailfrom=hotmail.de; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=hotmail.de; received-spf: SoftFail (protection.outlook.com: domain of transitioning hotmail.de discourages use of 10.152.0.58 as permitted sender) x-ms-exchange-messagesentrepresentingtype: 1 x-eopattributedmessage: 0 x-forefront-antispam-report: CIP:10.152.0.58;IPV:NLI;CTRY:;EFV:NLI;SFV:NSPM;SFS:(10019020)(98900003);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1EUR01HT023;H:AM4PR0701MB2162.eurprd07.prod.outlook.com;FPR:;SPF:None;LANG:en; x-microsoft-exchange-diagnostics: 1;HE1EUR01HT023;6:wtHvQAjCS/ZlNrWZoPXjUb66oxjgbXuE3RytMtwlu5OB/NK68FLgReOlziZzLKaSjVYpr9VdbAFUjSoHYPBgVeTPINU+mSQkGEaPsbh6ohnCj8IoIhSXQgVwZFvOROOcBInHTn+WDKR4oqP4ebSrNtMNGUbqVZLxdhMXseM0O5k6eW4DUoIg4fUjXSNlySMBbVKd67Q/Q6tsOieYhSg+BvrysUhXWsjvZw9fjIt3OKAZLmnKHuC9qZESZsnE4/pmUUcFjLT5w2IZZSoO1n+ZsGMDvSsl/MHxZ7J86u6RNX1SlY2IfLQvNAon86s8VmVV;5:V0sWPjoV8enK/sw6ddK+aHhRuXbkZjlXrHMCM6KEGHUnT3fe8BukuGOPqBiViuz1X0Vn2MaHtAF7+rr5T+ws1ini6NBtdMPGUEggHm55cX8uwiSni3RzL+45mSAYxihMhln4Ci5zsGi7OSjMgc6fag==;24:y+dXQzpd3qJEIYnbY8sm0pgFPWuj54q7FGLsTAsRmCyPaSfvdiU3CyY8muwYo4bry/7PLbrEpYFqYzeDexzeWYBhikNy/K1plOFV/9OIq5k=;7:pDggfrYlXTcQIqcCODbiRDZ+LhILK0//L91xlLAbgD0jcxxG9RJxDm+BDXxEPv23ZV8qu4aSYZccRmFbbYNL1iYQ0uk6N1BCILFRrdbP6yqVvfzQKv8xwfxTI8Wfy/dfDtLITOYM/rWIQTYytbk9awH2NhLui5+btZGB+Y4h+dwB86KKqUWEsOvTmx6XswHG2KQM7hUEpAbMI9Laaipu6R1rUmpoeAbM6ebTQ5w1/TFl+ctC3nJxt6Ep6ZbEyi3p x-ms-office365-filtering-correlation-id: 2e705374-0077-4c1e-6943-08d3db5868ca x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(1601124038)(1603103081)(1601125047);SRVR:HE1EUR01HT023; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(432015012)(82015046);SRVR:HE1EUR01HT023;BCL:0;PCL:0;RULEID:;SRVR:HE1EUR01HT023; x-forefront-prvs: 006339698F spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: <12DD1F3D4FEBA947A753A20E291E2037@eurprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Sep 2016 22:01:56.5184 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT023 X-SW-Source: 2016-09/txt/msg00679.txt.bz2 On 09/12/16 23:45, Jeff Law wrote: > On 09/12/2016 07:43 AM, Bernd Edlinger wrote: >> Hi, >> >> the attached patch boot-straps and reg-tests cleanly >> on x86_64-pc-linux-gnu, powerpc and aarch64 targets. >> >> Is it OK for trunk? > Unfortunately, there's no explanation for why the original code was > wrong. Yes, I can clearly see you're trying to fix an ICE, but what > about the code's behaviour was wrong? > > jeff > Sorry, everything is just folding, and continuing Peter's cleanup, except here: @@ -1840,7 +1829,7 @@ process_alt_operands (int only_alternative) op =3D no_subreg_reg_operand[nop] =3D *curr_id->operand_loc[nop]; /* The real hard regno of the operand after the allocation. */ - hard_regno[nop] =3D get_hard_regno (op); + hard_regno[nop] =3D get_hard_regno (op, true); operand_reg[nop] =3D reg =3D op; biggest_mode[nop] =3D GET_MODE (op); note the comment above. This restores the state before Peter's patch here, but only here, not in the operand matching. Bernd.