From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46025 invoked by alias); 3 Aug 2016 14:25:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 45923 invoked by uid 89); 3 Aug 2016 14:25:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:eurprd07, HX-OriginatorOrg:outlook.com, Hx-languages-length:1426, H*c:Windows-1252 X-HELO: BAY004-OMC4S9.hotmail.com Received: from bay004-omc4s9.hotmail.com (HELO BAY004-OMC4S9.hotmail.com) (65.54.190.211) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA256 encrypted) ESMTPS; Wed, 03 Aug 2016 14:25:21 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com ([65.54.190.201]) by BAY004-OMC4S9.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Wed, 3 Aug 2016 07:25:20 -0700 Received: from VE1EUR01FT019.eop-EUR01.prod.protection.outlook.com (10.152.2.58) by VE1EUR01HT019.eop-EUR01.prod.protection.outlook.com (10.152.3.105) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.557.8; Wed, 3 Aug 2016 14:25:16 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com (10.152.2.55) by VE1EUR01FT019.mail.protection.outlook.com (10.152.2.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.557.8 via Frontend Transport; Wed, 3 Aug 2016 14:25:16 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) by AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) with mapi id 15.01.0549.022; Wed, 3 Aug 2016 14:25:14 +0000 From: Bernd Edlinger To: Jeff Law , Segher Boessenkool CC: GCC Patches , Eric Botcazou , Bernd Schmidt , Andreas Schwab , Tamar Christina Subject: Re: [PATCH] Fix wrong code on aarch64 due to paradoxical subreg Date: Wed, 03 Aug 2016 14:25:00 -0000 Message-ID: References: <49bd77c6-d53c-ddb1-3fed-d4c0a0d50869@redhat.com> <20160729070216.GC28169@gate.crashing.org> <20160730113914.GB32017@gate.crashing.org> In-Reply-To: authentication-results: spf=softfail (sender IP is 10.152.2.55) smtp.mailfrom=hotmail.de; redhat.com; dkim=none (message not signed) header.d=none;redhat.com; dmarc=none action=none header.from=hotmail.de; received-spf: SoftFail (protection.outlook.com: domain of transitioning hotmail.de discourages use of 10.152.2.55 as permitted sender) x-ms-exchange-messagesentrepresentingtype: 1 x-eopattributedmessage: 0 x-forefront-antispam-report: CIP:10.152.2.55;IPV:NLI;CTRY:;EFV:NLI;SFV:NSPM;SFS:(10019020)(98900003);DIR:OUT;SFP:1102;SCL:1;SRVR:VE1EUR01HT019;H:AM4PR0701MB2162.eurprd07.prod.outlook.com;FPR:;SPF:None;LANG:en; x-microsoft-exchange-diagnostics: 1;VE1EUR01HT019;6:taGNQYsyWBJHfmX3TEeWIPbvfkcsgepx+fxCJf4Cqku9SFMBPw/pmnqJkIH9h0PHQcIWZ0Y8ugfhAy/iVBQpTEP1IlPHaS33PEgpRm9zbZd4A/KRksnTnois9yxC+L+PAd65CEctjPfBP1XS8Kqmf7J1sQFuYf/elqTf24eYpsjXOSai1zd6cE+HF/IFMHIQfVNTWeNKDwh07OM69YP70Ngr4tvtSWDTfD0h3mpZ5roGaGo5/ejMLfp6i94wEh+MfXUJpFVBeNyQbhqnSiT6XB0z9piwLbnc3sZE/UGZ62pdGfCGyGHqteukSqCBHDPT;5:rEFa2xYOcqNG3akCUPBelDYeAT/btAWgueNtZ/0QZU8RLb2+neruVKrVT9mN6pwMqiclf2Zlpvqxpze+pjbag861bTcpIBsIDYS7QcjdswEK+ky9D695pg4xPuZMFiSlKQ0d+pAHi28mIeizhdPdxg==;24:cN8STZwxhUr4bdbBv2s/GpybKCkXbC6qAbJaPisLhoDiP1zQ0EwT63FL0YMQU/AK7R3xZbf2UB99zo/jdkGTC2QOTW1sXQmvHyNgBOAiXjc=;7:kvX+Xb8SEBe0ndmTiicIh67GenqvbIBVfR5TMu813EqTBA2PQPzRagUTyL2poDmYtp1pHoxHoFMYmIGK9Ka1ZNw8r5WncO+6xaOe/LYN8mA1Ee/7c8xP4ykcshTv6sVvg7/UvFeC+mTPUuBeWeG+G0EjPxvsWFDZM0yFlC4Vl6YMB0gwiGexQKaqg4AvvlCI23Y23P1tgs20HHnJsrLK6IIU6hRHy07H6kmlWTa7RKNcv5kh6oU4XV6aVVZFWO6B x-ms-office365-filtering-correlation-id: 2ced40df-17db-415d-e15f-08d3bba9fbc2 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(1601124038)(1601125047);SRVR:VE1EUR01HT019; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(432015012)(82015046);SRVR:VE1EUR01HT019;BCL:0;PCL:0;RULEID:;SRVR:VE1EUR01HT019; x-forefront-prvs: 00235A1EEF spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: <06B9DAF4307A744CB09CF45E24EA41A1@eurprd07.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2016 14:25:14.8831 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR01HT019 X-SW-Source: 2016-08/txt/msg00187.txt.bz2 Hi, Is it OK for the trunk? I guess so, but need an explicit OK. Thanks Bernd. On 08/01/16 20:52, Bernd Edlinger wrote: > Hi Jeff, > > On 08/01/16 19:54, Jeff Law wrote: >> Looks like you've probably nailed it. It'll be interesting see if >> there's any fallout (though our RTL optimizer testing is pretty weak, so >> even if there were, I doubt we'd catch it). >> > > If there is, it will probably a performance regression... > > Anyway I'd say these two patches do just disable actually wrong > transformations. So here are both patches as separate diffs > with your suggestion for the comment in cse_insn. > > I believe that on x86_64 both patches do not change a single bit. > > However I think there are more paradoxical subregs generated all over, > but the aarch64 insv code pattern did trigger more hidden bugs than > any other port. It is certainly unfortunate that the major source > of paradoxical subreg is in a target-dependent code path :( > > Please apologize that I am not able to reduce/finalize the aarch64 test > case at this time, as I usually only work with arm and intel targets, > but I made an exception here, because a bug like that may affect all > targets sooner or later. > > > Boot-strap and reg-testing on x86_64-linux-gnu. > Plus aarch64 bootstrap and isl-testing by Andreas. > > > Is it OK for trunk? > > > > Thanks > Bernd.