From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70585 invoked by alias); 12 Aug 2016 05:21:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 70558 invoked by uid 89); 12 Aug 2016 05:21:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL,BAYES_20,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=mpfr, MPFR, mpc, lineno X-HELO: BAY004-OMC2S22.hotmail.com Received: from bay004-omc2s22.hotmail.com (HELO BAY004-OMC2S22.hotmail.com) (65.54.190.97) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 Aug 2016 05:21:33 +0000 Received: from EUR01-DB5-obe.outbound.protection.outlook.com ([65.54.190.123]) by BAY004-OMC2S22.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Thu, 11 Aug 2016 22:21:32 -0700 Received: from HE1EUR01FT018.eop-EUR01.prod.protection.outlook.com (10.152.0.51) by HE1EUR01HT190.eop-EUR01.prod.protection.outlook.com (10.152.1.107) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.567.7; Fri, 12 Aug 2016 05:21:30 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com (10.152.0.52) by HE1EUR01FT018.mail.protection.outlook.com (10.152.0.175) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.567.7 via Frontend Transport; Fri, 12 Aug 2016 05:21:29 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) by AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) with mapi id 15.01.0549.026; Fri, 12 Aug 2016 05:21:28 +0000 From: Bernd Edlinger To: "Maciej W. Rozycki" , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Indicate minimum in-tree MPFR version handled Date: Fri, 12 Aug 2016 05:21:00 -0000 Message-ID: References: In-Reply-To: authentication-results: spf=softfail (sender IP is 10.152.0.52) smtp.mailfrom=hotmail.de; imgtec.com; dkim=none (message not signed) header.d=none;imgtec.com; dmarc=none action=none header.from=hotmail.de; received-spf: SoftFail (protection.outlook.com: domain of transitioning hotmail.de discourages use of 10.152.0.52 as permitted sender) x-ms-exchange-messagesentrepresentingtype: 1 x-tmn: [2cIFvl56fCkZJ4NgYBg97O95j1HcFPsN] x-eopattributedmessage: 0 x-forefront-antispam-report: CIP:10.152.0.52;IPV:NLI;CTRY:;EFV:NLI;SFV:NSPM;SFS:(10019020)(98900003);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1EUR01HT190;H:AM4PR0701MB2162.eurprd07.prod.outlook.com;FPR:;SPF:None;LANG:en; x-microsoft-exchange-diagnostics: 1;HE1EUR01HT190;6:TPbv8R7D4/BK2sTcuW11ynSwy66E2rRcN7bTV/DmhyjKte/q3uiNiZz8LjuJXChA7fXveeYH4P1TSjCow3nZ1aF3UMVsDe4Y79/Q24ox89Sjx/WU9e6X51OaQhjTJfjtJIYGPds1YbfqhtxYY6YvnS7OO+2ZZ415gDiU9I0rQlC4mcdxnRhalqqyEwjRSI55mmzC/R/+RBBsjgjHgmJ2wSseJcg5q58SQuy+zQabCGSW2MwMqXIhBQySLwsOz6GFqnurs5J5ONfaNW9p3k1XS5gCWRerDUV4kljdEDyZKryLatRTWk/c2zFjstlpYH2Q;5:0GSDbuJ8wVbkt7kNYO3JTifHRI0/fHHvCYdL/eRnSSbAaWvx6hlcSPRaJu87pbgDLwOpLAaxge95c7IczzFMfIoH26QG+udDBle7hAdqzxTyQf71HgAil23b0A7p2aMIP/Z5gWy4Vtp9AnWcbwxQLA==;24:Nq6N+pNksefKULGHdKu1kJozBnRSVYwyrrR/IMo4hO/GNQymfxG7+qOAxTGtks4P6ofvwKwhG/9y2YSkCp/LSDxssF/bKZIIzksxsUjQfSs=;7:YhAJ9NnWeet2uetR78RmFcBYXPrBKM6JWu0FeYcwDmkT0/5fhEGTxbaOisr3mj4dBelx621M++zK7/8/sDzbTiSBxs3j65STHYrFmrn/Lby77w0yVd9YdZ7svMnOi8NuPsuIyieSrV9usPQ0YRPEJCmtIK6VV51EBepq62tXNLC1p864pbxbyAz5KgQEmJ04/MXVy7QoAH9R72YE0yWITK458s+hPQK2XK6PQ3UkSuf14WYfIQau7xEnn6FGwz7D x-ms-office365-filtering-correlation-id: 153bdccf-ca6f-4e25-b59a-08d3c2708336 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(1601124038)(1601125047);SRVR:HE1EUR01HT190; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(432015012)(82015046);SRVR:HE1EUR01HT190;BCL:0;PCL:0;RULEID:;SRVR:HE1EUR01HT190; x-forefront-prvs: 003245E729 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Aug 2016 05:21:28.0926 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR01HT190 X-SW-Source: 2016-08/txt/msg00989.txt.bz2 On 08/12/16, Maciej W. Rozycki wrote: > Hi, >=20 > Commit 235763 removed support for versions of MPFR below 3.1.0 which have > a flat directory structure, however it did not introduce any safety check > for such an unhandled library version present in the tree. Consequently > the system-installed version is silently chosen, which if too old, causes > a confusing configuration failure in mpc/ stating a misleading version > requirement: >=20 > checking for MPFR... yes > checking for recent GMP... yes > checking for recent MPFR... no > configure: error: MPFR version >=3D 2.4.2 required > make[1]: *** [configure-mpc] Error 1 >=20 > I propose the check below to make people's life just a little bit easier > and indicate right away that an incorrect version of MPFR has been found > in the source tree. This is especially helpful when you just sync your > build tree from upstream and may easily miss the updated requirement. I > carefully chose to use "handled" rather than "supported" in the message as > the commit referred clearly indicates you are on your own with versions of > the libraries different from those stated in `download_prerequisites'. >=20 > + # MPFR v3.1.0 moved the sources into a src sub-directory. > + if ! test -d ${srcdir}/mpfr/src; then > + as_fn_error "Building GCC with MPFR in the source tree is only handl= ed for MPFR 3.1.0+." "$LINENO" 5 > + fi I think it is a good idea to detect this situation, but you should advise t= he user that he has to use exactly the same version(s) that contrib/download_prereq= uisites installs. Bernd.