From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40365 invoked by alias); 20 Dec 2016 18:17:09 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 40328 invoked by uid 89); 20 Dec 2016 18:17:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*p:D*de, Hx-spam-relays-external:sk:blu004-, H*RU:sk:BLU004-, HX-HELO:sk:BLU004- X-HELO: BLU004-OMC4S19.hotmail.com Received: from blu004-omc4s19.hotmail.com (HELO BLU004-OMC4S19.hotmail.com) (65.55.111.158) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Dec 2016 18:17:04 +0000 Received: from EUR02-VE1-obe.outbound.protection.outlook.com ([65.55.111.135]) by BLU004-OMC4S19.hotmail.com over TLS secured channel with Microsoft SMTPSVC(7.5.7601.23008); Tue, 20 Dec 2016 10:17:03 -0800 Received: from VE1EUR02FT015.eop-EUR02.prod.protection.outlook.com (10.152.12.57) by VE1EUR02HT159.eop-EUR02.prod.protection.outlook.com (10.152.13.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.10; Tue, 20 Dec 2016 18:17:00 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com (10.152.12.51) by VE1EUR02FT015.mail.protection.outlook.com (10.152.12.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.10 via Frontend Transport; Tue, 20 Dec 2016 18:17:00 +0000 Received: from AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) by AM4PR0701MB2162.eurprd07.prod.outlook.com ([10.167.132.147]) with mapi id 15.01.0803.010; Tue, 20 Dec 2016 18:17:00 +0000 From: Bernd Edlinger To: Wilco Dijkstra , "gcc-patches@gcc.gnu.org" CC: Ramana Radhakrishnan , Richard Earnshaw , Kyrill Tkachov , nd Subject: Re: [PATCH, ARM] Further improve stack usage in sha512, part 2 (PR 77308) Date: Tue, 20 Dec 2016 18:52:00 -0000 Message-ID: References: In-Reply-To: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=hotmail.de; x-incomingtopheadermarker: OriginalChecksum:76CBA54D130E1A07A0CB55F4D83B9EC51C9F29C7643EA3685422DD79CF3F70B7;UpperCasedChecksum:34967FE880953EBCDBDCDCE0164506F544305153B255BDDEC4AFC604D668B2D2;SizeAsReceived:7691;Count:37 x-ms-exchange-messagesentrepresentingtype: 1 x-incomingheadercount: 37 x-eopattributedmessage: 0 x-microsoft-exchange-diagnostics: 1;VE1EUR02HT159;7:6+R3RRmDBch/eG4PeOO+hUP8bW2kl7bCOQoITgC6FcpE5CTLX25bL+p4IGqemhoaa+DC0Tm03kDZd4hJ5fjVnPvhFMyH8MdeDmW2BU523vxXX9eHU6WDzpjASc4p/vxt4FYlfaZNYx8YFQpu7ZbfFR8Mb0Pt4vcUG2fFjNQ7khlYkHTGsaRzUu5BljlPG4+uTTdkn7YzFKqq7iLD+vrH4mlPo1ph8bZJnGI8Wjq6Z6qdhvthdkgtDV802NGb/hHsJMQbaEGhaEqfqfbrBbuwzP2otpnclZs5qtBpg9xvt9HDYyv/YLXSmMaaAaZ0O4Z2V8GEaaXLct/9ZW+DxCqTzIlTI3ieNYtAsczjpqM7xsjNIjnnAq1VUDODq2b0hdskVYF7mc06ecUDGXQHYFQyrB/eQKKVN6qDrc4bzhmbFKSy2iieaahoCMZ4LlcCOS93vDbeXD6ONaLNjh5nDW/PPg== x-forefront-antispam-report: EFV:NLI;SFV:NSPM;SFS:(10019020)(98900003);DIR:OUT;SFP:1102;SCL:1;SRVR:VE1EUR02HT159;H:AM4PR0701MB2162.eurprd07.prod.outlook.com;FPR:;SPF:None;LANG:en; x-ms-office365-filtering-correlation-id: 2376c1bd-e246-4cf0-0ab1-08d429046382 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(1601124038)(1603103113)(1601125047);SRVR:VE1EUR02HT159; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(432015012)(82015046);SRVR:VE1EUR02HT159;BCL:0;PCL:0;RULEID:;SRVR:VE1EUR02HT159; x-forefront-prvs: 0162ACCC24 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2016 18:17:00.4247 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Internet X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR02HT159 X-SW-Source: 2016-12/txt/msg01732.txt.bz2 On 12/20/16 16:09, Wilco Dijkstra wrote: > Bernd Edlinger wrote: >> this splits the *arm_negdi2, *arm_cmpdi_insn and *arm_cmpdi_unsigned >> also at split1 except for TARGET_NEON and TARGET_IWMMXT. >> >> In the new test case the stack is reduced to about 270 bytes, except >> for neon and iwmmxt, where this does not change anything. > > This looks odd: > > - operands[2] =3D gen_lowpart (SImode, operands[2]); > + if (can_create_pseudo_p ()) > + operands[2] =3D gen_reg_rtx (SImode); > + else > + operands[2] =3D gen_lowpart (SImode, operands[2]); > > Given this is an SI mode scratch, do we need the else part at all? It see= ms wrong > to ask for the low part of an SI mode operand... > Yes, I think that is correct. > Other than that it looks good to me, but I can't approve. > > As a result of your patches a few patterns are unused now. All the Thumb-= 2 iordi_notdi* > patterns cannot be used anymore. Also I think arm_cmpdi_zero never gets u= sed - a DI > mode compare with zero is always split into ORR during expand. > I did not change anything for -mthumb -mfpu=3Dneon for instance. Do you think that iordi_notdi* is never used also for that configuration? And if the arm_cmpdi_zero is never expanded, isn't it already unused before my patch? Bernd.