From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Biener <rguenther@suse.de>
Subject: [PATCH] Avoid another non zero terminated string constant
Date: Sun, 29 Jul 2018 08:14:00 -0000 [thread overview]
Message-ID: <AM5PR0701MB2657C1BF2BA2438C49E63216E4280@AM5PR0701MB2657.eurprd07.prod.outlook.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
Hi!
This fixes another not NUL terminated string literal that is created
in tree-ssa-forwprop.c at simplify_builtin_call.
src_buf is set up to contain a NUL at src_buf[src_len], thus use src_len + 1
as length parameter to build_string_literal. All other uses of
build_string_literal do it right, as far as I can see.
Bootstrapped and reg-tested on x86_64-pc-linux-gnu.
Is it OK for trunk?
Thanks
Bernd.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch-forwprop.diff --]
[-- Type: text/x-patch; name="patch-forwprop.diff", Size: 699 bytes --]
2018-07-29 Bernd Edlinger <bernd.edlinger@hotmail.de>
* tree-ssa-forwprop.c (simplify_builtin_call): Don't create a not NUL
terminated string literal.
Index: gcc/tree-ssa-forwprop.c
===================================================================
--- gcc/tree-ssa-forwprop.c (revision 263045)
+++ gcc/tree-ssa-forwprop.c (working copy)
@@ -1391,7 +1391,7 @@ simplify_builtin_call (gimple_stmt_iterator *gsi_p
src_buf, ptr1_align, false))
break;
- new_str_cst = build_string_literal (src_len, src_buf);
+ new_str_cst = build_string_literal (src_len + 1, src_buf);
if (callee1)
{
/* If STMT1 is a mem{,p}cpy call, adjust it and remove
next reply other threads:[~2018-07-29 8:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-29 8:14 Bernd Edlinger [this message]
2018-07-30 6:52 ` Richard Biener
2018-09-14 13:08 ` [PATCH] Avoid another non zero terminated string constant (revert) Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR0701MB2657C1BF2BA2438C49E63216E4280@AM5PR0701MB2657.eurprd07.prod.outlook.com \
--to=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).