From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93807 invoked by alias); 21 Jul 2017 11:22:06 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 93781 invoked by uid 89); 21 Jul 2017 11:22:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1654 X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com Received: from mail-db5eur01on0084.outbound.protection.outlook.com (HELO EUR01-DB5-obe.outbound.protection.outlook.com) (104.47.2.84) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jul 2017 11:22:03 +0000 Received: from AM5PR0802MB2610.eurprd08.prod.outlook.com (10.175.46.18) by DB6PR08MB2663.eurprd08.prod.outlook.com (10.175.234.159) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1282.10; Fri, 21 Jul 2017 11:22:00 +0000 Received: from AM5PR0802MB2610.eurprd08.prod.outlook.com ([fe80::b567:13a:e52:92de]) by AM5PR0802MB2610.eurprd08.prod.outlook.com ([fe80::b567:13a:e52:92de%17]) with mapi id 15.01.1282.014; Fri, 21 Jul 2017 11:22:00 +0000 From: Wilco Dijkstra To: GCC Patches , James Greenhalgh CC: nd , Yvan Roux Subject: Re: [PATCH][AArch64] Fix PR79041 Date: Fri, 21 Jul 2017 11:22:00 -0000 Message-ID: References: , In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wilco.Dijkstra@arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DB6PR08MB2663;7:5mSQ4VHeM5aL0lQD6RNwSgK6IPGuOY99OGYGX6uaK0ZizCtfJpmvUCsaFYapR7Vmv/i2zQkGzGsWEiyDuNEsXnfL6VjCaZ7GRq10yHl0720SbHS7MoXoqYih2uSISdIWeEzTvHBWN3t4/DWueCUM3eHk7vPSpncrhA/XdlZMBb28cC90Xp+LlL34mOVKdx+t+FCwHxpapW0nVFzNLdeOZHfAVlba5yXL50963crTwd+L7Zj5VeIjW2/Bqce8MjywkOwqddJOnB6K7lK1GAOkRdQc0Ryri98TuKKnPALkyzct2i5/Dd6s0yz6KJ2VxFZQYUJCL8Z4ANcoqsyTWCVNJOaCzNGx7hO2YodeeUD/MaVgW5Di20Lk1Nnh3364Te44KbqjtzdgF1Zy9ykr0pTEYcUebGjbEyG7300K2C02VyZ7rUBxNGLj+IRqcp8QZKMeYHM++tsCUrSqoMsdSqfNK2E/OvhFPSGrdeMcYVJxL5jtLuiOW2dZZZpPYjTdT5kzZsjKqkQLE20NR6RAfsKKtyR6mBUKdAQYRL83wS5atGgOdFRgQ3i+zi/NVE/dGeWTsZnEV7Nkdmd8nIdirpZo8rd/ZwEzw5CHtYvpLJXsfNGP+lBwxvQvTVpWsOm82QfXr2R3AiUL9hUTmbDgTx2XGzBsC8eumjwTqIfKPCF6+N2sTuJFLY0mePDRqVNHcjDXCL5hyJH5sHlHgdGAsccF91UfnhiizLNh87YpSEc6vFdzDNssuAVp8/QlyIE+DSBdz6b/+Fq9BE4P5hxXT12yaGsItwjNUb/6/xl+onEudEc= x-ms-office365-filtering-correlation-id: b0d7c038-5a97-4d84-7725-08d4d02ab486 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254075)(48565401081)(300000503095)(300135400095)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DB6PR08MB2663; x-ms-traffictypediagnostic: DB6PR08MB2663: nodisclaimer: True x-exchange-antispam-report-test: UriScan:(180628864354917); x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB6PR08MB2663;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB6PR08MB2663; x-forefront-prvs: 0375972289 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39850400002)(39410400002)(39840400002)(39860400002)(39400400002)(39450400003)(199003)(54534003)(189002)(377424004)(4326008)(8936002)(33656002)(189998001)(81166006)(81156014)(8676002)(5250100002)(86362001)(76176999)(99286003)(6436002)(575784001)(5660300001)(50986999)(9686003)(54906002)(55016002)(54356999)(3846002)(7696004)(7736002)(6116002)(102836003)(66066001)(74316002)(97736004)(53936002)(6246003)(38730400002)(305945005)(101416001)(2900100001)(68736007)(478600001)(229853002)(105586002)(6636002)(2950100002)(2906002)(106356001)(14454004)(3660700001)(25786009)(6506006)(3280700002)(72206003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR08MB2663;H:AM5PR0802MB2610.eurprd08.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2017 11:22:00.0903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR08MB2663 X-SW-Source: 2017-07/txt/msg01289.txt.bz2 =A0=20=20=20 ping =A0=A0=A0=20 As described in PR79041, -mcmodel=3Dlarge -mpc-relative-literal-loads may be used to avoid generating ADRP/ADD or ADRP/LDR.=A0 However both trunk and GCC7 may still emit ADRP for some constant pool literals. Fix this by adding a aarch64_pcrelative_literal_loads check. OK for trunk/GCC7 backport? ChangeLog: 2017-06-27=A0 Wilco Dijkstra=A0 =A0=A0=A0=A0=A0=A0=A0 PR target/79041 =A0=A0=A0=A0=A0=A0=A0 * config/aarch64/aarch64.c (aarch64_classify_symbol): =A0=A0=A0=A0=A0=A0=A0 Avoid SYMBOL_SMALL_ABSOLUTE . =A0=A0=A0=A0=A0=A0=A0 * testsuite/gcc.target/aarch64/pr79041-2.c: New test. -- diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index 060cd8476d2954119daac495ecb059c9be73edbe..329d244e9cf16dbdf849e5dd02b= 3999caf0cd5a7 100644 --- a/gcc/config/aarch64/aarch64.c +++ b/gcc/config/aarch64/aarch64.c @@ -10042,7 +10042,7 @@ aarch64_classify_symbol (rtx x, rtx offset) =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 /* This is alright even in PIC code as the c= onstant =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 pool reference is always PC relativ= e and within =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 the same translation unit.=A0 */ -=A0=A0=A0=A0=A0=A0=A0=A0 if (CONSTANT_POOL_ADDRESS_P (x)) +=A0=A0=A0=A0=A0=A0=A0=A0 if (CONSTANT_POOL_ADDRESS_P (x) && !aarch64_pcrel= ative_literal_loads) =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return SYMBOL_SMALL_ABSOLUTE; =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 else =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 return SYMBOL_FORCE_TO_MEM; diff --git a/gcc/testsuite/gcc.target/aarch64/pr79041-2.c b/gcc/testsuite/g= cc.target/aarch64/pr79041-2.c new file mode 100644 index 0000000000000000000000000000000000000000..e7899725bad2b770f8488a07f99= 792113275bdf2 --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/pr79041-2.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -mcmodel=3Dlarge -mpc-relative-literal-loads" } */ + +__int128 +t (void) +{ +=A0 return (__int128)1 << 80; +} + +/* { dg-final { scan-assembler "adr" } } */ =A0=A0=A0=20=20=20=20=20