From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117829 invoked by alias); 15 Jun 2017 17:43:17 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117818 invoked by uid 89); 15 Jun 2017 17:43:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:998 X-HELO: EUR01-VE1-obe.outbound.protection.outlook.com Received: from mail-ve1eur01on0086.outbound.protection.outlook.com (HELO EUR01-VE1-obe.outbound.protection.outlook.com) (104.47.1.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Jun 2017 17:43:14 +0000 Received: from AM5PR0802MB2610.eurprd08.prod.outlook.com (10.175.46.18) by AM5PR0802MB2385.eurprd08.prod.outlook.com (10.175.43.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1178.14; Thu, 15 Jun 2017 17:43:16 +0000 Received: from AM5PR0802MB2610.eurprd08.prod.outlook.com ([fe80::611d:6946:9597:da06]) by AM5PR0802MB2610.eurprd08.prod.outlook.com ([fe80::611d:6946:9597:da06%17]) with mapi id 15.01.1178.013; Thu, 15 Jun 2017 17:43:16 +0000 From: Wilco Dijkstra To: Jiong Wang , James Greenhalgh CC: GCC Patches , nd , Jiong Wang , Richard Earnshaw , "Marcus Shawcroft" Subject: Re: [RFC][PATCH][AArch64] Cleanup frame pointer usage Date: Thu, 15 Jun 2017 17:43:00 -0000 Message-ID: References: <20170614145109.GF8010@arm.com> ,<5ef1dcc5-7aac-5a09-140e-8ec0932d8bc9@foss.arm.com> In-Reply-To: <5ef1dcc5-7aac-5a09-140e-8ec0932d8bc9@foss.arm.com> authentication-results: gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;AM5PR0802MB2385;7:EnFwhq2jvfwwXzY2Gqrj0BWPplTXV8T22Tk9FltLYJ2caSo7+ISNeG9KK3KtnDP0R9uGbkM6yODzupIGvtVjFeEJYLUsLWLYO/B41UfjvAjwKUUd43gRWjujtKeW3DLmuH46j2uh2QyLm8x2fPevWHE0mOIXER6bzgVxmaKq983Gmm+Wa6oPE4SQGmJLNjknDe8xdAWw/PObi5f/1zZsawWXZH9RMRdoayFfCyTb4MizG+fkOqHcYyq6vCjivwATgDcyW28fwOxJeaHPJ8uy98YZW2kXgxLRCnZ0cmZ7pB8Qo50osY1Hnf3fYoaV84Z4SgUbn1EOSmO7WfNyf3A7+rwbehVeEu37sfUPJrJHvA1X69Xrany7KMEC4qfE8GfYNIdKxXMmdB2b6lacT47wwVkpDhuAfQTZjBpQkHMACbVj9MXLHph+zE0lr81ATnqyVrCYTZdS/R2OSiO8VBAB7MBwlAtym+10aFdvwnM2oLqYHCPrc91Sn2PdW8AfQ5aZcJn48ESdl9ydLwwsmNCegLtyKI9UkQfaq91R803XKK2QdyjmT9ElReOBYm7dxnakgSoJ6/0FqAPHqCC5JMaO8cgGt5nU0B/WCBwWJ2q6zoV3fWY1F950svTZVbdSJvuNsO4aKztD/HZq85pYPwhHCQWfkAm5yDW4QiHuPKnOx2j9WzRIbLAEMCWebZj5Ge/XJc1cT7+h41W1ScwP7TpC1w/4Yz80JvgkszMJZ+7Aa+j5WieeDGGZmsAXWVEqQDsA/K715Udi9ugAsebeLthvlkQJj+F0hO49LWu4IppbHHc= x-ms-office365-filtering-correlation-id: d2a34b39-4c36-4cb6-a8f2-08d4b41600d6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:AM5PR0802MB2385; x-ms-traffictypediagnostic: AM5PR0802MB2385: nodisclaimer: True x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(100000703101)(100105400095)(93006095)(93001095)(6055026)(6041248)(20161123560025)(20161123562025)(20161123564025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123555025)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:AM5PR0802MB2385;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:AM5PR0802MB2385; x-forefront-prvs: 0339F89554 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(39860400002)(39450400003)(39850400002)(39400400002)(39410400002)(39840400002)(24454002)(7736002)(81166006)(6506006)(7696004)(8676002)(53936002)(6436002)(74316002)(189998001)(93886004)(5660300001)(33656002)(76176999)(478600001)(54906002)(54356999)(6246003)(5250100002)(55016002)(50986999)(102836003)(6116002)(86362001)(305945005)(72206003)(99286003)(38730400002)(25786009)(229853002)(9686003)(2906002)(4326008)(3660700001)(2950100002)(6636002)(3280700002)(14454004)(2900100001)(8936002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0802MB2385;H:AM5PR0802MB2610.eurprd08.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2017 17:43:16.0868 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2385 X-SW-Source: 2017-06/txt/msg01138.txt.bz2 Jiong Wang wrote: test.c =3D=3D=3D struct K { =A0 int a; =A0 int b; =A0 int c; =A0 int d; =A0 char e; =A0 short f; =A0 long g; =A0 float h; =A0 double i; }; void foo (int, struct K *); void test (int i) { =A0 struct K k =3D { =A0=A0 .a =3D 5, =A0=A0 .b =3D 0, =A0=A0 .c =3D i, =A0 }; =A0 foo (5, &k); } There are 2 separate latent bugs here, both unrelated to this patch. If I b= uild with -fomit-frame pointer I get: str x30, [sp, -64]! mov w2, 5 mov x1, sp str w2, [sp, 16] add x1, x1, 20 stp xzr, xzr, [x1] add x1, sp, 16 str w0, [sp, 24] mov x0, sp add x0, x0, 36 stp xzr, xzr, [x0] mov w0, w2 str xzr, [sp, 52] str wzr, [sp, 60] bl foo ldr x30, [sp], 64 ret If I use a compiler from early January (which also includes my patch) I get: str x30, [sp, -64]! mov w2, 5 stp xzr, xzr, [sp, 16] add x1, sp, 16 str w0, [sp, 24] mov w0, w2 stp xzr, xzr, [sp, 32] stp xzr, xzr, [sp, 48] str w2, [sp, 16] bl foo ldr x30, [sp], 64 ret Clearly a nasty regression was introduced in the structure initialization c= ode... Wilco