public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Richard Earnshaw <Richard.Earnshaw@foss.arm.com>,
	GCC Patches	<gcc-patches@gcc.gnu.org>, nd <nd@arm.com>,
	James Greenhalgh	<James.Greenhalgh@arm.com>
Subject: Re: [PATCH][AArch64] Mark symbols as constant
Date: Fri, 23 Jun 2017 10:56:00 -0000	[thread overview]
Message-ID: <AM5PR0802MB2610D32EC8D37D863969A55783D80@AM5PR0802MB2610.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <mvmk24482tk.fsf@suse.de>

Andreas Schwab wrote:
>
> This breaks gcc.target/aarch64/reload-valid-spoff.c with -mabi=ilp32:

Indeed, there is a odd ILP32 bug that causes high/lo_sum to be generated
in SI mode in expand:

(insn 15 14 16 4 (set (reg:SI 125)
        (high:SI (symbol_ref/u:DI ("*.LC1") [flags 0x2]))) 
     (nil))
(insn 16 15 17 4 (set (reg:SI 124)
        (lo_sum:SI (reg:SI 125)
            (symbol_ref/u:DI ("*.LC1") [flags 0x2])))

Eventually this may end up as a 64-bit adrp, a 32-bit lo_sum and a load that
expects a 64-bit address...

I have a simple workaround to disable the symbol optimization in ILP32,
but I'm looking into fixing the underlying cause.

Wilco

      reply	other threads:[~2017-06-23 10:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-19 18:59 Wilco Dijkstra
2017-06-19 22:13 ` Richard Earnshaw
2017-06-20 14:56   ` Wilco Dijkstra
2017-06-21 10:01     ` Richard Earnshaw (lists)
2017-06-22 15:22     ` Andreas Schwab
2017-06-23 10:56       ` Wilco Dijkstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM5PR0802MB2610D32EC8D37D863969A55783D80@AM5PR0802MB2610.eurprd08.prod.outlook.com \
    --to=wilco.dijkstra@arm.com \
    --cc=James.Greenhalgh@arm.com \
    --cc=Richard.Earnshaw@foss.arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).