public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Bader, Lucas" <lucas.bader@sap.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106
Date: Thu, 02 Jan 2020 08:27:00 -0000	[thread overview]
Message-ID: <AM6PR02MB4376742F48758E181E833A6BE1200@AM6PR02MB4376.eurprd02.prod.outlook.com> (raw)

Happy New Year and a ping for https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01113.html 

-----Original Message-----
From: Bader, Lucas 
Sent: Montag, 16. Dezember 2019 12:19
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

Hello,

within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. 
When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. prints out the affected source
line and fixit hints, it attempts to read the source file again, even when compiling a preprocessed file (-fpreprocessed). 
This leads to wrong diagnostics when building with a compile cluster, or, more generally, when changing or deleting the original source file.

This patch attempts to alter the behavior by implementing a location_get_source_line_preprocessed 
function that can be used in diagnostic-show-locus.c in case a preprocessed file is compiled.
There was some previous discussion on this behavior on PR preprocessor/79106.

This is my first patch to GCC, so in case something is wrong with the format, please let me know.

Best regards
Lucas

             reply	other threads:[~2020-01-02  8:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  8:27 Bader, Lucas [this message]
2024-01-22  9:02 ` Bader, Lucas
2025-01-03 14:27   ` Ping^3 " Bader, Lucas
2025-01-18 16:41     ` Jeff Law
2025-01-28 19:52       ` Bader, Lucas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM6PR02MB4376742F48758E181E833A6BE1200@AM6PR02MB4376.eurprd02.prod.outlook.com \
    --to=lucas.bader@sap.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).