From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 128707 invoked by alias); 2 Sep 2019 14:02:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 128697 invoked by uid 89); 2 Sep 2019 14:02:16 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.5 required=5.0 tests=AWL,BAYES_05,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=expr.c, H*f:sk:AM6PR10, UD:expr.c, exprc X-HELO: EUR01-HE1-obe.outbound.protection.outlook.com Received: from mail-oln040092065018.outbound.protection.outlook.com (HELO EUR01-HE1-obe.outbound.protection.outlook.com) (40.92.65.18) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 02 Sep 2019 14:02:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XmRHIN10PjQDHaM/Did4wp0tIAK3jGMj/DDoiyLCZ4MlX508ncORU+/ua+QW5F/QUbt5w9Hh4pRNmDuZ49TsSWAijCLBGI07JxIaSroaTtKTIukcnQyFE7WOAAgl6q8aMx2ohiGRH6UFrPwOXBuK2A/Ocw3cB+8UuNCU7sbUiICu/Ea1o+3NMLeix8WhZ7JXMahgNMru3rmyvapZqH2iFRQC44pqb8k7rDDxxb488WrrytzU2mSnPRCUe8WHf45kEFqhWmwgcft40ffsrfslW0yEkyN4eusdDYfiYBhGNiUuNGezfQEmt7/4KWy8kblx1/JypZX7M/RhauowPI7dbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tuPE/JhhiQZtks8whY0Nds/ffeFz/YpJA6nq56+lt+Q=; b=LTbjfN/SFYruNG0Pe4AOKkEqDmgTSLPNmmq+89/qB6vH3BVIP/TXjDxxr4y/pXZHZVSwKUSmbsWRuyjtOBe0hzAzB4KXN0ju/XaTa5q2ZQ1I3pb4IlzvYE+K7XEWal32bpLUDo3Kl5mXYwezIbK3ZCMN5GTE4YyRbesNQ1iL24f6K0FtdtxLYBmNt79uL7W+GlNddYK8Idyecn4T4yedfdWzVaTSqyzwodbgT+CH1OnnMUO0sj1HCz5cH5MdX+5DC9aWHXHlSTbdti2xc2Rq4X7UxJHsUU3i/1xmjXdod2mWRgyTeM3YdUv3vS5gJmTotWBVv8pXDLPGjn+YWvAUWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from HE1EUR01FT049.eop-EUR01.prod.protection.outlook.com (10.152.0.52) by HE1EUR01HT078.eop-EUR01.prod.protection.outlook.com (10.152.0.223) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2220.16; Mon, 2 Sep 2019 14:02:11 +0000 Received: from AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM (10.152.0.57) by HE1EUR01FT049.mail.protection.outlook.com (10.152.0.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2220.16 via Frontend Transport; Mon, 2 Sep 2019 14:02:11 +0000 Received: from AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM ([fe80::2c65:b468:fdc0:d924]) by AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM ([fe80::2c65:b468:fdc0:d924%6]) with mapi id 15.20.2220.021; Mon, 2 Sep 2019 14:02:10 +0000 From: Bernd Edlinger To: Richard Biener CC: "gcc-patches@gcc.gnu.org" , Jeff Law Subject: Re: [PATCH] Fix PR 91605 Date: Mon, 02 Sep 2019 14:02:00 -0000 Message-ID: References: In-Reply-To: x-microsoft-original-message-id: <2242e608-995b-c8c8-7c15-8c451b52549a@hotmail.de> x-ms-exchange-transport-forked: True Content-Type: multipart/mixed; boundary="_002_AM6PR10MB25666CBEB8CCC2C33CFEB18AE4BE0AM6PR10MB2566EURP_" MIME-Version: 1.0 X-SW-Source: 2019-09/txt/msg00059.txt.bz2 --_002_AM6PR10MB25666CBEB8CCC2C33CFEB18AE4BE0AM6PR10MB2566EURP_ Content-Type: text/plain; charset="Windows-1252" Content-ID: <9AD9231251C63244B1D0BAE7BEE9EA3B@EURPRD10.PROD.OUTLOOK.COM> Content-Transfer-Encoding: quoted-printable Content-length: 1124 On 9/2/19 9:50 AM, Richard Biener wrote: > On Sun, 1 Sep 2019, Bernd Edlinger wrote: >=20 >> Hi, >> >> this fixes an oversight in r274986. >> We need to avoid using movmisalign on DECL_P which are not in memory, >> similar to the !mem_ref_refers_to_non_mem_p which unfortunately can't >> handle DECL_P. >> >=20 > But >=20 > - && (DECL_P (to) || !mem_ref_refers_to_non_mem_p (to)) > + && (DECL_P (to) ? MEM_P (DECL_RTL (to)) > + : !mem_ref_refers_to_non_mem_p (to)) >=20 > and in mem_ref_refers_to_non_mem_p we do >=20 > if (!DECL_RTL_SET_P (base)) > return nortl; >=20 > return (!MEM_P (DECL_RTL (base))); >=20 > so when !DECL_RTL_SET_P (t) we can go full speed ahead? That said, > can we refactor addr_expr_of_non_mem_decl_p_1 to put >=20 Ah, I was not aware that DECL_RTL has a side-effect if !DECL_RTL_SET_P. > if (TREE_CODE (addr) !=3D ADDR_EXPR) > return false; >=20 > tree base =3D TREE_OPERAND (addr, 0); >=20 > into the single caller and re-use it then also for the DECL_P case? >=20 Yes, that is probably better then. So how about this? Is it OK? Thanks Bernd. --_002_AM6PR10MB25666CBEB8CCC2C33CFEB18AE4BE0AM6PR10MB2566EURP_ Content-Type: text/x-patch; name="patch-pr91605.diff" Content-Description: patch-pr91605.diff Content-Disposition: attachment; filename="patch-pr91605.diff"; size=3203; creation-date="Mon, 02 Sep 2019 14:02:10 GMT"; modification-date="Mon, 02 Sep 2019 14:02:10 GMT" Content-ID: <5173C69063D71A4B82D8B9701BA1AEAF@EURPRD10.PROD.OUTLOOK.COM> Content-Transfer-Encoding: base64 Content-length: 4344 MjAxOS0wOS0wMSAgQmVybmQgRWRsaW5nZXIgIDxiZXJuZC5lZGxpbmdlckBo b3RtYWlsLmRlPgoKCVBSIG1pZGRsZS1lbmQvOTE2MDUKCSogZXhwci5jIChh ZGRyX2V4cHJfb2Zfbm9uX21lbV9kZWNsX3BfMSk6IFJlZmFjdG9yIGludG8u Li4KCShub25fbWVtX2RlY2xfcCk6IC4uLnRoaXMuCgkobWVtX3JlZl9yZWZl cnNfdG9fbm9uX21lbV9wKTogSGFuZGxlIERFQ0xfUCBhcyB3ZWxsIGFzZSBN RU1fUkVGLgoJKGV4cGFuZF9hc3NpZ25tZW50KTogQ2FsbCBtZW1fcmVmX3Jl ZmVyZXNfdG9fbm9uX21lbV9wCgl1bmNvbmRpdGlvbmFsbHkgYXMgYmVmb3Jl LgoKdGVzdHN1aXRlOgoyMDE5LTA5LTAxICBCZXJuZCBFZGxpbmdlciAgPGJl cm5kLmVkbGluZ2VyQGhvdG1haWwuZGU+CgoJUFIgbWlkZGxlLWVuZC85MTYw NQoJKiBnKysudGFyZ2V0L2kzODYvcHI5MTYwNS5DOiBOZXcgdGVzdC4KCklu ZGV4OiBnY2MvZXhwci5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGdj Yy9leHByLmMJKHJldmlzaW9uIDI3NTI3OSkKKysrIGdjYy9leHByLmMJKHdv cmtpbmcgY29weSkKQEAgLTQ5NDIsMTggKzQ5NDIsMTMgQEAgZ2V0X2JpdF9y YW5nZSAocG9seV91aW50NjRfcG9kICpiaXRzdGFydCwgcG9seV91aW4KICAg KmJpdGVuZCA9ICpiaXRzdGFydCArIHRyZWVfdG9fcG9seV91aW50NjQgKERF Q0xfU0laRSAocmVwcikpIC0gMTsKIH0KIAotLyogUmV0dXJucyB0cnVlIGlm IEFERFIgaXMgYW4gQUREUl9FWFBSIG9mIGEgREVDTCB0aGF0IGRvZXMgbm90 IHJlc2lkZQotICAgaW4gbWVtb3J5IGFuZCBoYXMgbm9uLUJMS21vZGUuICBE RUNMX1JUTCBtdXN0IG5vdCBiZSBhIE1FTTsgaWYKLSAgIERFQ0xfUlRMIHdh cyBub3Qgc2V0IHlldCwgcmV0dXJuIE5PUlRMLiAgKi8KKy8qIFJldHVybnMg dHJ1ZSBpZiBCQVNFIGlzIGEgREVDTCB0aGF0IGRvZXMgbm90IHJlc2lkZSBp biBtZW1vcnkgYW5kCisgICBoYXMgbm9uLUJMS21vZGUuICBERUNMX1JUTCBt dXN0IG5vdCBiZSBhIE1FTTsgaWYKKyAgIERFQ0xfUlRMIHdhcyBub3Qgc2V0 IHlldCwgcmV0dXJuIGZhbHNlLiAgKi8KIAogc3RhdGljIGlubGluZSBib29s Ci1hZGRyX2V4cHJfb2Zfbm9uX21lbV9kZWNsX3BfMSAodHJlZSBhZGRyLCBi b29sIG5vcnRsKQorbm9uX21lbV9kZWNsX3AgKHRyZWUgYmFzZSkKIHsKLSAg aWYgKFRSRUVfQ09ERSAoYWRkcikgIT0gQUREUl9FWFBSKQotICAgIHJldHVy biBmYWxzZTsKLQotICB0cmVlIGJhc2UgPSBUUkVFX09QRVJBTkQgKGFkZHIs IDApOwotCiAgIGlmICghREVDTF9QIChiYXNlKQogICAgICAgfHwgVFJFRV9B RERSRVNTQUJMRSAoYmFzZSkKICAgICAgIHx8IERFQ0xfTU9ERSAoYmFzZSkg PT0gQkxLbW9kZSkKQEAgLTQ5NjAsMTkgKzQ5NTUsMzMgQEAgc3RhdGljIGlu bGluZSBib29sCiAgICAgcmV0dXJuIGZhbHNlOwogCiAgIGlmICghREVDTF9S VExfU0VUX1AgKGJhc2UpKQotICAgIHJldHVybiBub3J0bDsKKyAgICByZXR1 cm4gZmFsc2U7CiAKICAgcmV0dXJuICghTUVNX1AgKERFQ0xfUlRMIChiYXNl KSkpOwogfQogCi0vKiBSZXR1cm5zIHRydWUgaWYgdGhlIE1FTV9SRUYgUkVG IHJlZmVycyB0byBhbiBvYmplY3QgdGhhdCBkb2VzIG5vdAorLyogUmV0dXJu cyB0cnVlIGlmIFJFRiByZWZlcnMgdG8gYW4gb2JqZWN0IHRoYXQgZG9lcyBu b3QKICAgIHJlc2lkZSBpbiBtZW1vcnkgYW5kIGhhcyBub24tQkxLbW9kZS4g ICovCiAKIHN0YXRpYyBpbmxpbmUgYm9vbAogbWVtX3JlZl9yZWZlcnNfdG9f bm9uX21lbV9wICh0cmVlIHJlZikKIHsKLSAgdHJlZSBiYXNlID0gVFJFRV9P UEVSQU5EIChyZWYsIDApOwotICByZXR1cm4gYWRkcl9leHByX29mX25vbl9t ZW1fZGVjbF9wXzEgKGJhc2UsIGZhbHNlKTsKKyAgdHJlZSBiYXNlOworCisg IGlmIChUUkVFX0NPREUgKHJlZikgPT0gTUVNX1JFRgorICAgICAgfHwgVFJF RV9DT0RFIChyZWYpID09IFRBUkdFVF9NRU1fUkVGKQorICAgIHsKKyAgICAg IHRyZWUgYWRkciA9IFRSRUVfT1BFUkFORCAocmVmLCAwKTsKKworICAgICAg aWYgKFRSRUVfQ09ERSAoYWRkcikgIT0gQUREUl9FWFBSKQorCXJldHVybiBm YWxzZTsKKworICAgICAgYmFzZSA9IFRSRUVfT1BFUkFORCAoYWRkciwgMCk7 CisgICAgfQorICBlbHNlCisgICAgYmFzZSA9IHJlZjsKKworICByZXR1cm4g bm9uX21lbV9kZWNsX3AgKGJhc2UpOwogfQogCiAvKiBFeHBhbmQgYW4gYXNz aWdubWVudCB0aGF0IHN0b3JlcyB0aGUgdmFsdWUgb2YgRlJPTSBpbnRvIFRP LiAgSWYgTk9OVEVNUE9SQUwKQEAgLTUwMDQsNyArNTAxMyw3IEBAIGV4cGFu ZF9hc3NpZ25tZW50ICh0cmVlIHRvLCB0cmVlIGZyb20sIGJvb2wgbm9udGVt CiAgICAgICAgfHwgVFJFRV9DT0RFICh0bykgPT0gVEFSR0VUX01FTV9SRUYK ICAgICAgICB8fCBERUNMX1AgKHRvKSkKICAgICAgICYmIG1vZGUgIT0gQkxL bW9kZQotICAgICAgJiYgKERFQ0xfUCAodG8pIHx8ICFtZW1fcmVmX3JlZmVy c190b19ub25fbWVtX3AgKHRvKSkKKyAgICAgICYmICFtZW1fcmVmX3JlZmVy c190b19ub25fbWVtX3AgKHRvKQogICAgICAgJiYgKChhbGlnbiA9IGdldF9v YmplY3RfYWxpZ25tZW50ICh0bykpCiAJICA8IEdFVF9NT0RFX0FMSUdOTUVO VCAobW9kZSkpCiAgICAgICAmJiAoKChpY29kZSA9IG9wdGFiX2hhbmRsZXIg KG1vdm1pc2FsaWduX29wdGFiLCBtb2RlKSkKSW5kZXg6IGdjYy90ZXN0c3Vp dGUvZysrLnRhcmdldC9pMzg2L3ByOTE2MDUuQwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBnY2MvdGVzdHN1aXRlL2crKy50YXJnZXQvaTM4Ni9wcjkx NjA1LkMJKHJldmlzaW9uIDApCisrKyBnY2MvdGVzdHN1aXRlL2crKy50YXJn ZXQvaTM4Ni9wcjkxNjA1LkMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwx MyBAQAorLyogeyBkZy1kbyBjb21waWxlIH0gKi8KKy8qIHsgZGctb3B0aW9u cyAiLWZwYWNrLXN0cnVjdCAtbWF2eCIgfSAqLworCitzdHJ1Y3QgQSB7Cisg IF9fYXR0cmlidXRlX18oKF9fdmVjdG9yX3NpemVfXyg0ICogc2l6ZW9mKGRv dWJsZSkpKSkgZG91YmxlIGRhdGE7Cit9Oworc3RydWN0IEIgeworICBBIG9w ZXJhdG9yKihCKTsKK307Cit2b2lkIGZuMSgpIHsKKyAgQiB4LCB5OworICB4 ICp5OworfQo= --_002_AM6PR10MB25666CBEB8CCC2C33CFEB18AE4BE0AM6PR10MB2566EURP_--