From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 78888 invoked by alias); 16 Aug 2019 11:53:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 78880 invoked by uid 89); 16 Aug 2019 11:53:15 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 spammy=H*i:sk:AM6PR10 X-HELO: EUR03-VE1-obe.outbound.protection.outlook.com Received: from mail-oln040092072108.outbound.protection.outlook.com (HELO EUR03-VE1-obe.outbound.protection.outlook.com) (40.92.72.108) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Aug 2019 11:53:13 +0000 Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com (10.152.18.52) by VE1EUR03HT159.eop-EUR03.prod.protection.outlook.com (10.152.19.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2052.18; Fri, 16 Aug 2019 11:53:10 +0000 Received: from AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM (10.152.18.60) by VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2178.16 via Frontend Transport; Fri, 16 Aug 2019 11:53:10 +0000 Received: from AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM ([fe80::4056:d9d8:9ce5:1976]) by AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM ([fe80::4056:d9d8:9ce5:1976%4]) with mapi id 15.20.2157.022; Fri, 16 Aug 2019 11:53:10 +0000 From: Bernd Edlinger To: Vladimir Makarov , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] [LRA] Fix wrong-code PR 91109 take 2 Date: Fri, 16 Aug 2019 12:07:00 -0000 Message-ID: References: <6a79fb83-d6d5-63fa-c16e-ccea9d2f93ca@redhat.com> In-Reply-To: x-microsoft-original-message-id: <46de38b3-bf3e-e480-07f5-6d94db9e05b7@hotmail.de> Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-08/txt/msg01162.txt.bz2 On 8/15/19 9:46 PM, Bernd Edlinger wrote: > Hi, >=20 > as discussed in the PR 91109 audit trail, > my previous patch missed a case where no spilling is necessary, > but the re-materialized instruction has now scratch regs without > a hard register assignment. And thus the LRA pass falls out of > the loop pre-maturely. >=20 > Fixed by checking for scratch regs with no assignment > and continuing the loop in that case. >=20 >=20 > Boot-strapped and reg-tested on x86_64-pc-linux-gnu and arm-linux-gnueabi= hf. > Is it OK for trunk? >=20 Aehm, sorry, I forgot to ask, but is it also OK for the gcc-9 branch ? Thanks Bernd.