From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <richard.earnshaw@arm.com>,
Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Subject: Re: [PATCH] Fix PR 91684
Date: Sat, 07 Sep 2019 18:32:00 -0000 [thread overview]
Message-ID: <AM6PR10MB2566E997317D868CA9929C3EE4B50@AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <AM6PR10MB2566CF802CF95AF0488FDD25E4B50@AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM>
I just noticed that the effective target is not right,
this needs to be prefer_ldrd_strd instead of arm_ldrd_strd_ok,
otherwise the ldrd is not generated.
Committed the following fix to the test case as obvious:
Index: gcc.target/arm/pr91684.c
===================================================================
--- gcc.target/arm/pr91684.c (revision 275488)
+++ gcc.target/arm/pr91684.c (revision 275489)
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-require-effective-target arm_ldrd_strd_ok } */
+/* { dg-require-effective-target arm_prefer_ldrd_strd } */
/* { dg-options "-O3" } */
typedef struct { int a, b, c; } S;
Index: ChangeLog
===================================================================
--- ChangeLog (revision 275488)
+++ ChangeLog (revision 275489)
@@ -1,3 +1,7 @@
+2019-09-07 Bernd Edlinger <bernd.edlinger@hotmail.de>
+
+ * gcc.target/arm/pr91684.c: Use effective-target arm_prefer_ldrd_strd.
+
2019-09-07 David Edelsohn <dje.gcc@gmail.com>
* g++.dg/cpp2a/decomp2.C: Add TLS options.
On 9/7/19 6:39 AM, Bernd Edlinger wrote:
> Hi,
>
> this fixes PR 91684, where an only 4-byte aligned memory is used with movdi,
> which is formally invalid for strict alignment, but okay for prefer_ldrd_strd
> targets.
>
>
> Boot-strapped and reg-tested on arm-linux-gnueabihf.
> Patch was approved via BZ.
> Applied to trunk.
>
>
> Thanks
> Bernd.
>
prev parent reply other threads:[~2019-09-07 18:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 4:40 Bernd Edlinger
2019-09-07 18:32 ` Bernd Edlinger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR10MB2566E997317D868CA9929C3EE4B50@AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM \
--to=bernd.edlinger@hotmail.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=richard.earnshaw@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).