From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28699 invoked by alias); 7 Sep 2019 18:32:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28690 invoked by uid 89); 7 Sep 2019 18:32:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-oln040092070091.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.92.70.91) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Sep 2019 18:32:34 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C/F3/mkllhmRKaswlgrks0rYeku89sE/cn+N6I2NoIJgIvH6BRblus7hDn+OZxaHunoAvAJQqV57eMNLkgCjbrQy3yr6MaNN3CUt2o3GJdIY/crVTJAlaQHfOILmTEs++hjtl0I/H9CIVND3L4Gh0WzKOIGivF7JseDgfqDbM9uMsb3fDe8bw9Q5EfRyc7rFh93mW5RioFD5IE1A8doZ0/CeJK4PNbbbUZSxC5i4c3NE6wqRhwH2uR7bBEruoDjettP5ydv2+an05du7quv56cia0EBO2yVE4+2UUw9d9L31HFAqiQaC24v6IzE4GgakJEanW/SiVrpxX17U0EbBxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F3Ac4PzRwGAE0hbiauI2EBJKjLfwRgY+yuvptTtp2Z0=; b=aHJcBYSAEAyP+EOM6fOO4/mL6dPtQBF5salyTuOhGB4tCB8fYl5jjnzoC/YJqjdhLpcx3OlDeVHRBuNKqNdOdmChV3p/9Rp5kZPlprmK8k6o59IjVgE73lkMezvFkHdqjRnNOg+RlGk9zjpPRERWOToDWmglXMElT+X4qLUA7s3vuPgSgNNpdVUKCDyiudquol0SMDhw6/+wVCZ3Do/UirepMzOiAFRJTGumpev1RsHswpmCj7uhnTMfZ3KRePuTvn2ITk2O2P2hQgE73k+OwtFEFGFHMZNIbaxrtpH6EQEFGxlBpjskFHKAK1619SJRwt2vaPQxQCw9ZMlev/R4Vg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB5EUR03FT037.eop-EUR03.prod.protection.outlook.com (10.152.20.57) by DB5EUR03HT246.eop-EUR03.prod.protection.outlook.com (10.152.21.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2241.14; Sat, 7 Sep 2019 18:32:31 +0000 Received: from AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM (10.152.20.52) by DB5EUR03FT037.mail.protection.outlook.com (10.152.20.215) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2241.14 via Frontend Transport; Sat, 7 Sep 2019 18:32:31 +0000 Received: from AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM ([fe80::2c65:b468:fdc0:d924]) by AM6PR10MB2566.EURPRD10.PROD.OUTLOOK.COM ([fe80::2c65:b468:fdc0:d924%6]) with mapi id 15.20.2241.018; Sat, 7 Sep 2019 18:32:30 +0000 From: Bernd Edlinger To: "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Kyrill Tkachov Subject: Re: [PATCH] Fix PR 91684 Date: Sat, 07 Sep 2019 18:32:00 -0000 Message-ID: References: In-Reply-To: x-microsoft-original-message-id: x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="Windows-1252" Content-ID: <699B04C7E582B4418866862EEF45321F@EURPRD10.PROD.OUTLOOK.COM> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-SW-Source: 2019-09/txt/msg00446.txt.bz2 I just noticed that the effective target is not right, this needs to be prefer_ldrd_strd instead of arm_ldrd_strd_ok, otherwise the ldrd is not generated. Committed the following fix to the test case as obvious: Index: gcc.target/arm/pr91684.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- gcc.target/arm/pr91684.c (revision 275488) +++ gcc.target/arm/pr91684.c (revision 275489) @@ -1,5 +1,5 @@ /* { dg-do compile } */ -/* { dg-require-effective-target arm_ldrd_strd_ok } */ +/* { dg-require-effective-target arm_prefer_ldrd_strd } */ /* { dg-options "-O3" } */ =20 typedef struct { int a, b, c; } S; Index: ChangeLog =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- ChangeLog (revision 275488) +++ ChangeLog (revision 275489) @@ -1,3 +1,7 @@ +2019-09-07 Bernd Edlinger + + * gcc.target/arm/pr91684.c: Use effective-target arm_prefer_ldrd_strd. + 2019-09-07 David Edelsohn =20 * g++.dg/cpp2a/decomp2.C: Add TLS options. On 9/7/19 6:39 AM, Bernd Edlinger wrote: > Hi, >=20 > this fixes PR 91684, where an only 4-byte aligned memory is used with mov= di, > which is formally invalid for strict alignment, but okay for prefer_ldrd_= strd > targets. >=20 >=20 > Boot-strapped and reg-tested on arm-linux-gnueabihf. > Patch was approved via BZ. > Applied to trunk. >=20 >=20 > Thanks > Bernd. >=20