From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05olkn2046.outbound.protection.outlook.com [40.92.91.46]) by sourceware.org (Postfix) with ESMTPS id 4120C388B832 for ; Mon, 2 Aug 2021 17:18:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4120C388B832 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m/g9TfvsO6IKbOksys3umoCoERAK6vy44d9qW4+WukIu0a10amSOVBussKv/lkcFdE34aBuyd+NBh3Fw/ZhyYo5bqkz6ktXSrAOqkGANDS9TPZf78ts/B94zCCoXoxlhGtRHmwFHMoEIu51Wujz+0UQRe/kH8cv0HGTywRvg3+YYxBGFjAuGk7d2mjjf08kURnGI9TtSlUpg+FaVCgTEwrmhqhOHW4Do4Tx2RC+xXyUIRcw5kZ7XzOHhcvJ6QmHv5rrhzwcyqVe8WB22CPxzLaakwf2htNwB8HncRbtoFN9m/6aM1tdgOPX54StkJZ302HZmCDtog80vjWwpxLWhvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e1wOiQG5yNoOTrkNahsDVb0MWzfqAL7CmQpTiLVGmDE=; b=aErfkOTRozTPuHHRDDS3d+0SmhJoW1H3w2J12C4SdoZ4/t7c5vHNHblkgxTDT7o3Rd4Y5nnoG9v+VdpFB1L2q3zY9+j7E6WB2yjkgKAIOaBG7RJVtN8MOjkDJZMGlXJY1hTjb3qSSmWb4oqkWh/WQcZ/UShKjw/Cs0qFlM7D0mCPQmb2I5o+SCFtPAkqYbS7UWhy/IuPSNAY5xCWl+MX3HVpJ1D+8F39GnAg1QvFUC0dKf6yO0gm6kEZRYCYdeUYPZXWKl3DCqDVYwYpZN5QhdweYZNkjIcpLbB4CT+yWAeUGZD8sflHpSyi/6A2RTZl/W8ZF02SWk8Mbyzm3hcfeA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VI1EUR05FT029.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc12::4c) by VI1EUR05HT003.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc12::201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Mon, 2 Aug 2021 17:18:14 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:fc12::44) by VI1EUR05FT029.mail.protection.outlook.com (2a01:111:e400:fc12::382) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18 via Frontend Transport; Mon, 2 Aug 2021 17:18:14 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:14EE1E904AB6ACC718D7482F1E6CDBE1A56F6F9FD0631C96B18C35B712FC46CD; UpperCasedChecksum:0D5349662FDF7FC26A6169C1938240A76AF24932058DC90827F34B8C16D673EB; SizeAsReceived:7963; Count:48 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::3d30:d151:570a:8a16]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::3d30:d151:570a:8a16%9]) with mapi id 15.20.4373.026; Mon, 2 Aug 2021 17:18:14 +0000 Subject: Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions To: Eric Botcazou Cc: "gcc-patches@gcc.gnu.org" , Richard Biener , Arnaud Charlet References: <5484735.DvuYhMxLoT@arcturus> From: Bernd Edlinger Message-ID: Date: Mon, 2 Aug 2021 19:18:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <5484735.DvuYhMxLoT@arcturus> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [d6OrDYiT48jgePf977GltG3j7f42jlmo] X-ClientProxiedBy: FR3P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::16) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: <3e9571bc-188a-82a2-4fe3-7340bed099ba@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (88.76.118.196) by FR3P281CA0069.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.10 via Frontend Transport; Mon, 2 Aug 2021 17:18:14 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 4014e0ff-0ef9-4365-c0c1-08d955d9830b X-MS-TrafficTypeDiagnostic: VI1EUR05HT003: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VwP/ADokecWO4EoxWSCMQLXJcvp6Vz+WckQFOAZx9MxiSlw0ZHPsPoyVsaLomgocZ9oo29wV1IpVPkhoLEkBvWVWsCeY2374o0VTgSryVA5nUDz+cKZJWqU2DW35Qsku48hlppWkYUPSmUZd5I9Jm8NFzHSYZzzuw1sNQlRTaO59UdX1NNMgvRjilegbBDZ+NAeH4F5/KslqmbC8tRnHsZBRsG8yxfZ3LtkBV1b4u3HAHPgTwrWnFrvbfuM/ZMZMR9cH7EGK5wc5dHwdVobYAL/WRF+NgKft8FAIFxnjH/P7m370r1ScyDgdVCdXE3W1XiEdEIUtQHLy818YOE/vGugoZGgQB3ULioDz9r4R8YD+1MqsbatuLE04fEhPt90YeJveXw7+0Lo0C6h/U+eLPGuA60YX3GIYhPz9EDpune5FWKNZww2UU5ohejjv9M+B X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: q4SKtGvEQzPT6VFZM2G1VUqOZUfIPT++F5aIaUaV+5Gxc4Ny7pmhxpBs+7WGPsWXNZ1ttRcQMG5S0glqV2OG0y8y4d97GFwe2joQOReaXsNeR4IZYuyO8HmV6QQlhulaq6OkOukM82d8wboSU+lrgA== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4014e0ff-0ef9-4365-c0c1-08d955d9830b X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Aug 2021 17:18:14.7333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: VI1EUR05FT029.eop-eur05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1EUR05HT003 X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2021 17:18:17 -0000 On 8/2/21 3:07 PM, Eric Botcazou wrote: >> It was pointed out in PR101598 to be inappropriate, that >> ignored Ada decls receive the source line number which was >> recorded in the function decl's DECL_SOURCE_LOCATION. >> Therefore set all front-end-generated Ada decls with >> DECL_IGNORED_P to UNKNOWN_LOCATION. >> >> 2021-07-24 Bernd Edlinger >> >> PR debug/101598 >> * gcc-interface/trans.c (Subprogram_Body_to_gnu): Set the >> DECL_SOURCE_LOCATION of DECL_IGNORED_P gnu_subprog_decl to >> UNKNOWN_LOCATION. > > Is that really needed in DWARF 5? If no, I'm not sure that we want it. > No, this one is completely optional, only DWARF 4 may have additional issues without part 1/2 of this patch. The location of these ignored Ada decls looks completely sane to me. However, it was an unintentional side effect of the patch to allow minimal debugging of ignored decls. This means we can now step into those functions or set line breakpoints there, while previously that was not possible. And I guess it could be considered an improvement. So it's your choice, how you want these functions to be debugged. Thanks Bernd.