From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-oln040092071015.outbound.protection.outlook.com [40.92.71.15]) by sourceware.org (Postfix) with ESMTPS id 8F044385B805 for ; Fri, 28 May 2021 07:33:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8F044385B805 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eEnlbupIoKSWvnlUQRF6TTb/PKHJBCXm3uXT8/3Oj0Wr17kKT1ooVTx5XXDE+ujWjnmUhC4lIL3iU5OCrsKjKSKUXHNWLBTo3xLKGPY6NpE/rjleokMx0KnEGRh7bU2+bQh43U/a/zEirUiSNltV5B6cEdy9GjNQM50iuyitflbu4pNylF6Srvy9q6fzWZv/5eZOr4hWJCN8a7FTDL/cQQxILJUucUsxC7usmOaJANGYs2sCHiY5CB2DVb0AzMmUx0aFErkojPauL9+TGU74Yey/RQhN3/E98mPiytUcP0bCUXi1wC3NTxpcHU9+ZnuaEGpECh3f/G52BqL2VUOxtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=szq96UPdT7Ox6YY4bisq5/SLaTfLnNlenVwaoG6e7MU=; b=XAQnB1HhdVMXKqJz7KgUWYNq6hgO2oDR9RO4+nwTzWmfHh8zqCQoyX7xbxqHBxjIaqlD7X/g0noxg2tuTnUi6mBKF2cS+SEYOP3bp+AOZiK+6bKIve+mV7VUU4rytUvKsnYM6KrheduoBuUIMlAzS5trlcAiM4/pK0oRsl8NxVDLv4oS+zdHccjBMRQKOQ8smxW5y2q/YmPEWyAAzdzTL+ufCfIFKO8b+W9tQa0IqPJrN6VYgj8wDtLLSHGeFDEatrlwwfLSJCJ7amJjP13EVSuTiml6IrmZwuqIGPoDXOdrQWHUwLD5hoCH1G4ZVBG0cKtLCkoPj/IaZI/XmbfweQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com (2a01:111:e400:7e09::4c) by VE1EUR03HT044.eop-EUR03.prod.protection.outlook.com (2a01:111:e400:7e09::432) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Fri, 28 May 2021 07:33:16 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:7e09::53) by VE1EUR03FT023.mail.protection.outlook.com (2a01:111:e400:7e09::133) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.30 via Frontend Transport; Fri, 28 May 2021 07:33:16 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:BCEC6B76972FC8DFB128F1D2844B48B43EE5C91D7257B30A4C76414459D015E7; UpperCasedChecksum:D49C1EC0D00E71DE7145B601E365DDCD465306988BCDB32DF469DC4A11B4FE99; SizeAsReceived:8841; Count:48 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::ad12:6a2c:b949:f65d]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::ad12:6a2c:b949:f65d%5]) with mapi id 15.20.4173.020; Fri, 28 May 2021 07:33:16 +0000 Subject: Re: [PATCH] Generate gimple-match.c and generic-match.c earlier To: Andrew Pinski Cc: "gcc-patches@gcc.gnu.org" , Richard Biener References: From: Bernd Edlinger Message-ID: Date: Fri, 28 May 2021 09:33:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [6za1E5dn1VS1i1ty5/8qHXeyVeTQeMy9] X-ClientProxiedBy: PR1P264CA0025.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19f::12) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: <7e995e74-9b25-0525-7da5-8af2d7097517@hotmail.de> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (84.57.61.94) by PR1P264CA0025.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:19f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Fri, 28 May 2021 07:33:15 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 48 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: 36973452-c5e3-4552-93b2-08d921aadb93 X-MS-TrafficTypeDiagnostic: VE1EUR03HT044: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cQ+GteJzpu6QfCQZHUrjcNh8fvDZ5G1Mvd/pucSfP0zBGkdISpOKwhnlUSlhw5+8gCytbDqTM84i9lVXHGpQH98ril8JEvr5gW5Qzxn8wcCuwt/5d7LKMECSjkGxyMCZSo1rxqo/CRkL0E1ynWNH5iZz1TWZonmsDugqx6/0vZouUEUBVwp9zGg4jwH9bwYIkb+7b67CrznVOOiUMeybl2zAaxqJMSFv+71sOExQycxHjEFEbIT+uJ2pIG6jwPjs/i66kf3EhkGYye5zYHfOqDWOZejl30vCaPzVhGtEHZD26RKd8HTv1POTQUY1BQNfQmr5GmYY5qgsv3ehgN7vJDZSH/CLfar/BTAf33vuos9tzx6CnkzLTFnqpplLLkR/q9aOzR/T0FNy3u4ZvfnpzC9qmpQgcEJFU2KqsRZXKdCPBS/3INiC9rVcrXW+H6mlvr1pclyyseuK1TTdwWd/cA== X-MS-Exchange-AntiSpam-MessageData: sgWesqnKAX57sOF7SHPX1km2qz1KXOrmostHPh/ePBS5SjxD0qD22KISHTFr+18Q9zZSBdCkGae0f5TWnCaeFoo3XxgoYdkop6wTBLmZoMFsf+9BUKrrGTiH7rREF51zCt0EZDVhO6xdw4dkkGczCw== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 36973452-c5e3-4552-93b2-08d921aadb93 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 May 2021 07:33:16.6254 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1EUR03HT044 X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, KAM_DMARC_STATUS, KAM_SHORT, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 May 2021 07:33:21 -0000 On 5/28/21 9:26 AM, Andrew Pinski wrote: > On Thu, May 27, 2021 at 10:10 PM Bernd Edlinger > wrote: >> >> Hi, >> >> I was wondering, why gimple-match.c and generic-match.c >> are not built early but always last, which slows down parallel >> makes significantly. >> >> The reason seems to be that generated_files does not >> mention gimple-match.c and generic-match.c. >> >> This comment in Makefile.in says it all: >> >> $(ALL_HOST_OBJS) : | $(generated_files) >> >> So this patch adds gimple-match.c generic-match.c to generated_files. >> >> >> Tested on x86_64-pc-linux-gnu. >> Is it OK for trunk? > > This should help for what I was complaining about in > https://gcc.gnu.org/pipermail/gcc/2021-May/235963.html . I build with > -j24 and it was stalling on compiling gimple-match.c for me. > Looks like insn-attrtab.c is missed too; I saw genattrtab was running last too. > Yeah, probably insn-automata.c as well, sometimes it is picked up early sometimes not. maybe $(simple_generated_c) should be added to generated_files, but insn-attrtab.c is yet another exception. Bernd. > Thanks, > Andrew > >> >> >> Thanks >> Bernd. >> >> >> 2021-05-28 Bernd Edlinger >> >> * Makefile.in (generated_files): Add gimple-match.c and >> generic-match.c