Re: Committed: gcc.misc-tests/outputs.exp (outest): Fix typo "is_target"

[Bernd Edlinger <bernd.edlinger@hotmail.de>]

Oops,

thanks for fixing this problem.

To my excuse I would like to note,
that the script error does not happen on x86_64-pc-linux-gnu,
probably it would only happen when a file is left over.

Since usually this is never executed because $outs is empty:

    foreach f $outs {
        file delete $f
        # collect2 may create <execname>.cdtor* files in -save-temps link tests,
        # ??? without regard to aux output naming conventions.
        # Limit this exception to targets that define EH_FRAME_THROUGH_COLLECT2.
        if { !(([istarget powerpc*-*-aix*] || [is_target hppa*-*-hpux*])
               && ([string match "*.cdtor.*" $f]
                   || [string match "*.gcc_args" $f])) } {
            lappend outb $f
        }
    }

Can you say which target was this, where you found this bug?
Which file was in $outs?

I am also a bit surprised that a script error in one test aborts
the whole gcc.target tests.  How can that be?

Thanks
Bernd.


On 2/16/21 2:33 AM, Hans-Peter Nilsson wrote:
> Committed as obvious.  Please be more careful; this typo
> should have been obvious in "make check" output as below.
> 
> Commit-log:
> -------------------------------
> Fix typo for istarget in "is_target hppa*-*-hpux*", yielding
> an error running the test-suite for any target not matching
> powerpc*-*-aix* (presumably, by code inspection), aborting
> the check-gcc (check-gcc-c) regression test run some 3000
> tests before the last one, missing e.g. all gcc.target
> tests like so:
> 
> -----
> ...
> Running /x/gcc/gcc/testsuite/gcc.misc-tests/outputs.exp ...
> ERROR: (DejaGnu) proc "is_target hppa*-*-hpux*" does not exist.
> The error code is TCL LOOKUP COMMAND is_target
> The info on the error is:
> invalid command name "is_target"
>     while executing
> "::tcl_unknown is_target hppa*-*-hpux*"
>     ("uplevel" body line 1)
>     invoked from within
> "uplevel 1 ::tcl_unknown $args"
> 
> 		=== gcc Summary ===
> ...
> -----
> 
> gcc/testsuite:
> 	* gcc.misc-tests/outputs.exp (outest): Fix typo "is_target".
> ---
>  gcc/testsuite/gcc.misc-tests/outputs.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp
> index d5a9709910c2..4d904bde31d5 100644
> --- a/gcc/testsuite/gcc.misc-tests/outputs.exp
> +++ b/gcc/testsuite/gcc.misc-tests/outputs.exp
> @@ -192,7 +192,7 @@ proc outest { test sources opts dirs outputs } {
>  	# collect2 may create <execname>.cdtor* files in -save-temps link tests,
>  	# ??? without regard to aux output naming conventions.
>  	# Limit this exception to targets that define EH_FRAME_THROUGH_COLLECT2.
> -	if { !(([istarget powerpc*-*-aix*] || [is_target hppa*-*-hpux*])
> +	if { !(([istarget powerpc*-*-aix*] || [istarget hppa*-*-hpux*])
>  	       && ([string match "*.cdtor.*" $f]
>  		   || [string match "*.gcc_args" $f])) } {
>  	    lappend outb $f
>