From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2031.outbound.protection.outlook.com [40.92.89.31]) by sourceware.org (Postfix) with ESMTPS id 48E63385781D for ; Tue, 16 Feb 2021 07:35:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 48E63385781D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hotmail.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bernd.edlinger@hotmail.de ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BvtN975G30Yw/UbyLNjeFQVPxIav92NacbM6xCzjg6d63CKdpu6cBhuSbncWLku27Ek5657djHljBPinOT5VpjrGFa0xjb6RtFd6Zv7o4nauwqOYkOHtgKG64yaLqjRO2Up+HteKDaB2+1pWDqrUkljl2D7uqXYOVApp7R5e/7TtoREmiSKkKpLmffaL46QsOLAxancjOif8i5tSlVk9z6PGdDbzTjNMva3TEJn0QvApG5YxtEDS4tCKKeLbT+wP+HkoSQYpWZWjKJqL2AbVdM50l/5FXnlWBhZY1eeygZQY3gop0eMWzpMTgn31o0qqMM9SanUbdezRR8wYH901Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uw/EZsAHXxccrqYTGkW5RJxig8+ulf9aviM7ecShH50=; b=mZU/0SJG/Nd7vVVjTcZ2CDu3itGdHA/VeOYg7XP06mrLMcIvzgPJy+MKjUFAzJ9w/oJX4OYwjOlsX5gC9/UQrmfTRNXqbxig2sEuPKNbGmdI2PKQaXohHM/wxGq/MqkKhFt0gTOUeHsn+RQNMuUqZ3yw5vmDqmascProM1VZhWzod/dyNbEepa3xYRnQ0LkDH9mqjSTkGIuhJNc8xK2w5QLfkaMeQEcMGih6h5WIHVh23S/KZZ/Nr+ziuAefka97Oyx0o0JGCPRmq26vE08wK9KFe/vv8xVICj1zjYo3c9WE4tEcRlWlekb71dLEMMxZE2TIbSPm2oT/cF6BtEKBzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DB8EUR05FT040.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::4f) by DB8EUR05HT017.eop-eur05.prod.protection.outlook.com (2a01:111:e400:fc0f::281) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25; Tue, 16 Feb 2021 07:35:06 +0000 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2a01:111:e400:fc0f::52) by DB8EUR05FT040.mail.protection.outlook.com (2a01:111:e400:fc0f::220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.25 via Frontend Transport; Tue, 16 Feb 2021 07:35:06 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:5175CC991D737CAC68BACFAA76CBAF1A12575664AB2EC1E03E49634787EBBCD6; UpperCasedChecksum:46DABF716F2D70BB429E1AD61439402945F38B008F1208FC4CB94EA6C211AD63; SizeAsReceived:8177; Count:47 Received: from AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::7510:8a00:1c00:1147]) by AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM ([fe80::7510:8a00:1c00:1147%5]) with mapi id 15.20.3846.042; Tue, 16 Feb 2021 07:35:06 +0000 Subject: Re: Committed: gcc.misc-tests/outputs.exp (outest): Fix typo "is_target" To: Hans-Peter Nilsson , gcc-patches@gcc.gnu.org References: <20210216013333.6B96C203D4@pchp3.se.axis.com> From: Bernd Edlinger Message-ID: Date: Tue, 16 Feb 2021 08:35:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 In-Reply-To: <20210216013333.6B96C203D4@pchp3.se.axis.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TMN: [JRQ7cU04xM1GsMsdxsdIBw3uj0G7oyLN] X-ClientProxiedBy: MR2P264CA0157.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::20) To AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:20b:364::23) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.101] (92.211.177.211) by MR2P264CA0157.FRAP264.PROD.OUTLOOK.COM (2603:10a6:501:1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3846.36 via Frontend Transport; Tue, 16 Feb 2021 07:35:06 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: e6434bc1-5f63-4d39-76b0-08d8d24d618a X-MS-TrafficTypeDiagnostic: DB8EUR05HT017: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hJJ/Pn/khdJjz6YoftLFHvd3WLCmVErsbSE5f/Ffn6M7ZFIE/FpWt40mO5ps1DYKw68D0ZgpvAigb1N9FPnniUQw5J5Y04UijBJj1RDJCCRFW7vNFdGpplV8gccE1cfGLfrjcRtBvhujrgAqBw8BiI10+H4ejSOLe48Or415IvxcbhBTHEXRV63ng/y5NRBjSRnpN8Esx+VDpELaN5GknetlyNpWPsjxsRbt/M4lFb/iU7cq3igMP0Q+nfrg/tFrXgzAyHi9GSW+mpa5/f/P/TZF9rLszre7BkfB/6mE6/+1gl50wyUXVSFXduRAlATfgvMk2dQZ3tIg1kLdTwpxm8M5ue9HB9nMOODjvn1l/e2oD+lmuFIKEY1kgh/KWevifoo8pR2fJSUwE2yee2pJBg== X-MS-Exchange-AntiSpam-MessageData: tc2UwRfCGyQUjMJTQCDmMKBu/tG+E/uc9TDv7p6HsB2vMr1a8Qhmv3kea2mlSN54QgakmEEGWp2lSLWHMK0zPKPEfjEt1i8qs+eCmUgerMJ6G7d7c1drVsJsCAlJoljIn7s7iZFA2ww0oklgf0QF1A== X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6434bc1-5f63-4d39-76b0-08d8d24d618a X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2021 07:35:06.6472 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: DB8EUR05FT040.eop-eur05.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8EUR05HT017 X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, FORGED_MUA_MOZILLA, FREEMAIL_FROM, GIT_PATCH_0, KAM_DMARC_STATUS, MSGID_FROM_MTA_HEADER, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Feb 2021 07:35:14 -0000 Oops, thanks for fixing this problem. To my excuse I would like to note, that the script error does not happen on x86_64-pc-linux-gnu, probably it would only happen when a file is left over. Since usually this is never executed because $outs is empty: foreach f $outs { file delete $f # collect2 may create .cdtor* files in -save-temps link tests, # ??? without regard to aux output naming conventions. # Limit this exception to targets that define EH_FRAME_THROUGH_COLLECT2. if { !(([istarget powerpc*-*-aix*] || [is_target hppa*-*-hpux*]) && ([string match "*.cdtor.*" $f] || [string match "*.gcc_args" $f])) } { lappend outb $f } } Can you say which target was this, where you found this bug? Which file was in $outs? I am also a bit surprised that a script error in one test aborts the whole gcc.target tests. How can that be? Thanks Bernd. On 2/16/21 2:33 AM, Hans-Peter Nilsson wrote: > Committed as obvious. Please be more careful; this typo > should have been obvious in "make check" output as below. > > Commit-log: > ------------------------------- > Fix typo for istarget in "is_target hppa*-*-hpux*", yielding > an error running the test-suite for any target not matching > powerpc*-*-aix* (presumably, by code inspection), aborting > the check-gcc (check-gcc-c) regression test run some 3000 > tests before the last one, missing e.g. all gcc.target > tests like so: > > ----- > ... > Running /x/gcc/gcc/testsuite/gcc.misc-tests/outputs.exp ... > ERROR: (DejaGnu) proc "is_target hppa*-*-hpux*" does not exist. > The error code is TCL LOOKUP COMMAND is_target > The info on the error is: > invalid command name "is_target" > while executing > "::tcl_unknown is_target hppa*-*-hpux*" > ("uplevel" body line 1) > invoked from within > "uplevel 1 ::tcl_unknown $args" > > === gcc Summary === > ... > ----- > > gcc/testsuite: > * gcc.misc-tests/outputs.exp (outest): Fix typo "is_target". > --- > gcc/testsuite/gcc.misc-tests/outputs.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/testsuite/gcc.misc-tests/outputs.exp b/gcc/testsuite/gcc.misc-tests/outputs.exp > index d5a9709910c2..4d904bde31d5 100644 > --- a/gcc/testsuite/gcc.misc-tests/outputs.exp > +++ b/gcc/testsuite/gcc.misc-tests/outputs.exp > @@ -192,7 +192,7 @@ proc outest { test sources opts dirs outputs } { > # collect2 may create .cdtor* files in -save-temps link tests, > # ??? without regard to aux output naming conventions. > # Limit this exception to targets that define EH_FRAME_THROUGH_COLLECT2. > - if { !(([istarget powerpc*-*-aix*] || [is_target hppa*-*-hpux*]) > + if { !(([istarget powerpc*-*-aix*] || [istarget hppa*-*-hpux*]) > && ([string match "*.cdtor.*" $f] > || [string match "*.gcc_args" $f])) } { > lappend outb $f >