public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Bernd Edlinger <bernd.edlinger@hotmail.de>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: Jiufu Guo <guojiufu@linux.ibm.com>,
	gcc-patches@gcc.gnu.org, rguenther@suse.de, jlaw@tachyum.com,
	wschmidt@linux.ibm.com, dje.gcc@gmail.com
Subject: Re: [PATCH V2] Split loop for NE condition.
Date: Tue, 18 May 2021 13:14:39 +0200	[thread overview]
Message-ID: <AM8PR10MB4708D939050E867C90407531E42C9@AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210518110000.GX10366@gate.crashing.org>

On 5/18/21 1:00 PM, Segher Boessenkool wrote:> On Tue, May 18, 2021 at 08:36:34AM +0200, Bernd Edlinger wrote:
>> On 5/17/21 4:01 AM, Jiufu Guo via Gcc-patches wrote:
>>> Bootstrap and regtest pass on ppc64le.  Is this ok for trunk?
> 
>> I've tried this patch and it does not seem to pass its own test:
>>
>> FAIL: gcc.dg/loop-split1.c scan-tree-dump-times lsplit "Loop split" 9
> 
> On what target?  :-P
> 
>> Note you should always do a bootstrap and regression test as described
>> here: https://gcc.gnu.org/contribute.html#testing
>>
>> Also please state in your future patch submissions how you tested the patch,
>> like "bootstrap and regression test on x86_64-pc-linux-gnu" for instance.
> 
> Jiu Fu did all that.  If you understand that ppc64le means
> powerpc64-linux of course.
> 

Yeah indeed, I overlooked that, sorry for the noise.

> It is interesting one loop fails on x86.  But that is why we have
> stage1 :-)
> 

Sure, after looking more closely it seems like 90% of the test works
already.


Bernd.


> 
> Segher
> 

  reply	other threads:[~2021-05-18 11:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-17  2:01 Jiufu Guo
2021-05-18  6:36 ` Bernd Edlinger
2021-05-18  9:28   ` guojiufu
2021-05-18 10:32     ` guojiufu
2021-05-18 11:04       ` guojiufu
2021-05-18 11:00   ` Segher Boessenkool
2021-05-18 11:14     ` Bernd Edlinger [this message]
2021-05-26  9:50 ` Richard Biener
2021-05-26 13:22   ` Segher Boessenkool
2021-06-01  3:28   ` guojiufu
2021-06-01  8:23     ` guojiufu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM8PR10MB4708D939050E867C90407531E42C9@AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM \
    --to=bernd.edlinger@hotmail.de \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=guojiufu@linux.ibm.com \
    --cc=jlaw@tachyum.com \
    --cc=rguenther@suse.de \
    --cc=segher@kernel.crashing.org \
    --cc=wschmidt@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).