public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106
@ 2020-01-02  8:27 Bader, Lucas
  2024-01-22  9:02 ` Bader, Lucas
  0 siblings, 1 reply; 5+ messages in thread
From: Bader, Lucas @ 2020-01-02  8:27 UTC (permalink / raw)
  To: gcc-patches

Happy New Year and a ping for https://gcc.gnu.org/ml/gcc-patches/2019-12/msg01113.html 

-----Original Message-----
From: Bader, Lucas 
Sent: Montag, 16. Dezember 2019 12:19
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

Hello,

within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. 
When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. prints out the affected source
line and fixit hints, it attempts to read the source file again, even when compiling a preprocessed file (-fpreprocessed). 
This leads to wrong diagnostics when building with a compile cluster, or, more generally, when changing or deleting the original source file.

This patch attempts to alter the behavior by implementing a location_get_source_line_preprocessed 
function that can be used in diagnostic-show-locus.c in case a preprocessed file is compiled.
There was some previous discussion on this behavior on PR preprocessor/79106.

This is my first patch to GCC, so in case something is wrong with the format, please let me know.

Best regards
Lucas

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106
  2020-01-02  8:27 [PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106 Bader, Lucas
@ 2024-01-22  9:02 ` Bader, Lucas
  2025-01-03 14:27   ` Ping^3 " Bader, Lucas
  0 siblings, 1 reply; 5+ messages in thread
From: Bader, Lucas @ 2024-01-22  9:02 UTC (permalink / raw)
  To: gcc-patches

Hello,

as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79106 is still open from what I can tell, I wanted to gently bump this patch I provided a while back. It was earmarked for gcc-11 in https://gcc.gnu.org/pipermail/gcc-patches/2020-January/539201.html but did not make it into the release.

Original submission: https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg01113.html

Please let me know if something is missing.

Best
Lucas

-----Original Message-----
From: Bader, Lucas 
Sent: Montag, 16. Dezember 2019 12:19
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

Hello,

within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. 
When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. prints out the affected source
line and fixit hints, it attempts to read the source file again, even when compiling a preprocessed file (-fpreprocessed). 
This leads to wrong diagnostics when building with a compile cluster, or, more generally, when changing or deleting the original source file.

This patch attempts to alter the behavior by implementing a location_get_source_line_preprocessed 
function that can be used in diagnostic-show-locus.c in case a preprocessed file is compiled.
There was some previous discussion on this behavior on PR preprocessor/79106.

This is my first patch to GCC, so in case something is wrong with the format, please let me know.

Best regards
Lucas


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Ping^3 [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106
  2024-01-22  9:02 ` Bader, Lucas
@ 2025-01-03 14:27   ` Bader, Lucas
  2025-01-18 16:41     ` Jeff Law
  0 siblings, 1 reply; 5+ messages in thread
From: Bader, Lucas @ 2025-01-03 14:27 UTC (permalink / raw)
  To: gcc-patches

Hello and Happy New Year,

as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79106 is still open, I wanted to again bump this patch I provided a while back.
It was earmarked for gcc-11 in https://gcc.gnu.org/pipermail/gcc-patches/2020-January/539201.html but did not make it into the release.

Original submission: https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg01113.html

Please let me know if something is missing.

Best
Lucas

-----Original Message-----
From: Bader, Lucas 
Sent: Montag, 16. Dezember 2019 12:19
To: gcc-patches@gcc.gnu.org
Subject: [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106

Hello,

within a compile cluster, only the preprocessed output of GCC is transferred to remote nodes for compilation. 
When GCC produces advanced diagnostics (with -fdiagnostics-show-caret), e.g. prints out the affected source
line and fixit hints, it attempts to read the source file again, even when compiling a preprocessed file (-fpreprocessed). 
This leads to wrong diagnostics when building with a compile cluster, or, more generally, when changing or deleting the original source file.

This patch attempts to alter the behavior by implementing a location_get_source_line_preprocessed 
function that can be used in diagnostic-show-locus.c in case a preprocessed file is compiled.
There was some previous discussion on this behavior on PR preprocessor/79106.

This is my first patch to GCC, so in case something is wrong with the format, please let me know.

Best regards
Lucas


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Ping^3 [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106
  2025-01-03 14:27   ` Ping^3 " Bader, Lucas
@ 2025-01-18 16:41     ` Jeff Law
  2025-01-28 19:52       ` Bader, Lucas
  0 siblings, 1 reply; 5+ messages in thread
From: Jeff Law @ 2025-01-18 16:41 UTC (permalink / raw)
  To: Bader, Lucas, gcc-patches; +Cc: David Malcolm



On 1/3/25 7:27 AM, Bader, Lucas wrote:
> Hello and Happy New Year,
> 
> as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79106 is still open, I wanted to again bump this patch I provided a while back.
> It was earmarked for gcc-11 in https://gcc.gnu.org/pipermail/gcc-patches/2020-January/539201.html but did not make it into the release.
> 
> Original submission: https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg01113.html
> 
> Please let me know if something is missing.
Martin S. is no longer active in GCC development and stuff like input 
locations tends to fall more towards David M's space.

David M probably needs to chime in here (on cc).

Jeff

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Ping^3 [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106
  2025-01-18 16:41     ` Jeff Law
@ 2025-01-28 19:52       ` Bader, Lucas
  0 siblings, 0 replies; 5+ messages in thread
From: Bader, Lucas @ 2025-01-28 19:52 UTC (permalink / raw)
  To: Jeff Law, David Malcolm; +Cc: gcc-patches


Thanks for having a look Jeff. Would be great to hear your thoughts on this patch David.

Best
Lucas

> On 18. Jan 2025, at 17:41, Jeff Law <jeffreyalaw@gmail.com> wrote:
>
> 
>
>> On 1/3/25 7:27 AM, Bader, Lucas wrote:
>> Hello and Happy New Year,
>> as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79106 is still open, I wanted to again bump this patch I provided a while back.
>> It was earmarked for gcc-11 in https://gcc.gnu.org/pipermail/gcc-patches/2020-January/539201.html but did not make it into the release.
>> Original submission: https://gcc.gnu.org/legacy-ml/gcc-patches/2019-12/msg01113.html
>> Please let me know if something is missing.
> Martin S. is no longer active in GCC development and stuff like input locations tends to fall more towards David M's space.
>
> David M probably needs to chime in here (on cc).
>
> Jeff

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-01-28 19:52 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-02  8:27 [PING] [PATCH] get source line for diagnostic from preprocessed file / PR preprocessor/79106 Bader, Lucas
2024-01-22  9:02 ` Bader, Lucas
2025-01-03 14:27   ` Ping^3 " Bader, Lucas
2025-01-18 16:41     ` Jeff Law
2025-01-28 19:52       ` Bader, Lucas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).