From: Mike Stump <mikestump@comcast.net>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Christophe Lyon <christophe.lyon@linaro.org>,
Bernd Schmidt <bschmidt@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Jeff Law <law@redhat.com>, Jakub Jelinek <jakub@redhat.com>
Subject: Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.
Date: Sun, 20 Nov 2016 17:27:00 -0000 [thread overview]
Message-ID: <B2298D34-5620-4C9F-83EB-415CEC78CFD3@comcast.net> (raw)
In-Reply-To: <20161119215926.GX5975@embecosm.com>
On Nov 19, 2016, at 1:59 PM, Andrew Burgess <andrew.burgess@embecosm.com> wrote:
>> So, your new test fails on arm* targets:
>
> After a little digging I think the problem might be that
> -freorder-blocks-and-partition is not supported on arm.
>
> This should be detected as the new tests include:
>
> /* { dg-require-effective-target freorder } */
>
> however this test passed on arm as -freorder-blocks-and-partition does
> not issue any warning unless -fprofile-use is also passed.
>
> The patch below extends check_effective_target_freorder to check using
> -fprofile-use. With this change in place the tests are skipped on
> arm.
> All feedback welcome,
Seems reasonable, unless a -freorder-blocks-and-partition/-fprofile-use person thinks this is the wrong solution.
next prev parent reply other threads:[~2016-11-20 17:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 16:56 [PATCH 0/2] Remove user_defined_section_attribute global Andrew Burgess
2016-06-10 16:56 ` [PATCH 1/2] gcc: Remove unneeded global flag Andrew Burgess
2016-06-22 2:55 ` Jeff Law
2016-06-22 6:02 ` Jakub Jelinek
2016-06-29 19:33 ` Andrew Burgess
2016-09-14 13:05 ` Ping: " Andrew Burgess
2016-09-14 13:08 ` Jakub Jelinek
2016-09-15 14:30 ` Andrew Burgess
2016-10-28 15:58 ` Jeff Law
2016-10-28 16:15 ` Andrew Burgess
2016-11-03 12:01 ` Bernd Schmidt
2016-11-16 20:09 ` Andrew Burgess
2016-11-16 21:00 ` Mike Stump
2016-11-16 22:12 ` Andrew Burgess
2016-11-17 17:59 ` Jeff Law
2016-11-18 12:22 ` Christophe Lyon
2016-11-19 21:59 ` Andrew Burgess
2016-11-20 17:27 ` Mike Stump [this message]
2016-11-21 12:47 ` Christophe Lyon
2016-11-24 21:40 ` Andrew Burgess
2016-11-28 22:09 ` Jeff Law
2016-11-29 14:03 ` Andrew Burgess
2016-11-29 17:36 ` Jeff Law
2016-11-30 11:40 ` Andrew Burgess
2016-06-10 16:57 ` [PATCH 2/2] gcc: Update comment in bb-reorder.c Andrew Burgess
2016-06-22 2:59 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B2298D34-5620-4C9F-83EB-415CEC78CFD3@comcast.net \
--to=mikestump@comcast.net \
--cc=andrew.burgess@embecosm.com \
--cc=bschmidt@redhat.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).