From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-442078-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 49620 invoked by alias); 20 Nov 2016 17:27:33 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 49609 invoked by uid 89); 20 Nov 2016 17:27:32 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:freorde, freorder, person
X-HELO: resqmta-po-05v.sys.comcast.net
Received: from resqmta-po-05v.sys.comcast.net (HELO resqmta-po-05v.sys.comcast.net) (96.114.154.164) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 Nov 2016 17:27:22 +0000
Received: from resomta-po-20v.sys.comcast.net ([96.114.154.244])	by resqmta-po-05v.sys.comcast.net with SMTP	id 8VswccuZ5cEL18VtgcuaDk; Sun, 20 Nov 2016 17:27:20 +0000
Received: from up.mrs.kithrup.com ([24.4.193.248])	by resomta-po-20v.sys.comcast.net with SMTP	id 8VtfcMKVOvml28Vtgc4EPE; Sun, 20 Nov 2016 17:27:20 +0000
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.
From: Mike Stump <mikestump@comcast.net>
In-Reply-To: <20161119215926.GX5975@embecosm.com>
Date: Sun, 20 Nov 2016 17:27:00 -0000
Cc: Christophe Lyon <christophe.lyon@linaro.org>, Bernd Schmidt <bschmidt@redhat.com>, "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>, Jeff Law <law@redhat.com>, Jakub Jelinek <jakub@redhat.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B2298D34-5620-4C9F-83EB-415CEC78CFD3@comcast.net>
References: <cover.1465577682.git.andrew.burgess@embecosm.com> <a3ed605cdecc22d1c5ff91d90b4856574fea2139.1465577682.git.andrew.burgess@embecosm.com> <512a967c-39c4-44f5-6f24-d75ef543979d@redhat.com> <20160629192130.GF8823@embecosm.com> <20160914130048.GC31794@embecosm.com> <03bef940-2b86-af7d-d2d2-b96b8283596f@redhat.com> <20161116200930.GG5975@embecosm.com> <F85FFFDD-90C8-4A91-B996-B51B43818302@comcast.net> <20161116221217.GH5975@embecosm.com> <CAKdteObtzskJK49Y2m-krPKYDFbkgi8AXMrVR7kxoC9_7_GiBw@mail.gmail.com> <20161119215926.GX5975@embecosm.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
X-CMAE-Envelope: MS4wfEaCANfOUV9xWrDQonUyEXiIcCeBknkJLPFZSe7HEYmURpnXrq5E97IeduPqSU0zVRioN59gffGFeU2BSIwD1y61Rx9tK4oPwwPHMptWUFRtZ2N0Avhc m4M42FC7F2hB1KXKGlNarrA4rE8rRfaEfA9+zYyq2ahaPFoAO6kvAQDIZqMtxdms9Wos6upllKzrcHcT5YCLvLO1+jKJnGQlMGD4OWAja/DjSOOdCwnP0IOb UoFmnRYGd/tJiaba70JSrtTV4zKFie7PduLU/hmceF/781wM2u/ZkEXVVrODf4nxq1YYqF11DoT0d5dHiP3rLjeEzp3xbyWjeKet6OJnI4s=
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg02064.txt.bz2

On Nov 19, 2016, at 1:59 PM, Andrew Burgess <andrew.burgess@embecosm.com> w=
rote:
>> So, your new test fails on arm* targets:
>=20
> After a little digging I think the problem might be that
> -freorder-blocks-and-partition is not supported on arm.
>=20
> This should be detected as the new tests include:
>=20
>    /* { dg-require-effective-target freorder } */
>=20
> however this test passed on arm as -freorder-blocks-and-partition does
> not issue any warning unless -fprofile-use is also passed.
>=20
> The patch below extends check_effective_target_freorder to check using
> -fprofile-use.  With this change in place the tests are skipped on
> arm.

> All feedback welcome,

Seems reasonable, unless a -freorder-blocks-and-partition/-fprofile-use per=
son thinks this is the wrong solution.