From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp001-out.apm-internet.net (smtp001-out.apm-internet.net [85.119.248.222]) by sourceware.org (Postfix) with ESMTPS id A90553858D37 for ; Thu, 30 Nov 2023 19:56:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A90553858D37 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=sandoe.co.uk Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=sandoe.co.uk ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A90553858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=85.119.248.222 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701374178; cv=none; b=DVQ5wppjvZYQSvbCMF01XNbyda0g73DwTGDACXrDbf8yVzvf4s5f33PlrxNaj2wmPkOMLMzqjgZuxeCkdHDJLYxH10kFm+ppmSYMmzsF6JSQJiUBof8X9i/3GfdB4yvI3z8D58rOgUT5o69KZ0naOuG9Qg/Hs2oXXfggryyesd8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701374178; c=relaxed/simple; bh=VB3PuWCf84I4t+nbofiYySDmIswG1oPQkP+NCKIWa8g=; h=Mime-Version:Subject:From:Date:Message-Id:To; b=uD3pGg+eurNkDDpcMTqdTvFBdQ78C7tW//LNoIAjzKfsbfHkojrfgkA7VwLN29tBPkfVgSoC4A4i68PlAdd3eWKxe6GlLKLs93M9Q/oBEHi2qiagfKLoT7JEAgQ7jutEbsQHYAKgr7mOmphxTM9o6glPrNLV1XOt8C0yfhoFR88= ARC-Authentication-Results: i=1; server2.sourceware.org Received: (qmail 71424 invoked from network); 30 Nov 2023 19:56:15 -0000 X-APM-Out-ID: 17013741747142 X-APM-Authkey: 257869/1(257869/1) 16 Received: from unknown (HELO smtpclient.apple) (81.138.1.83) by smtp001.apm-internet.net with SMTP; 30 Nov 2023 19:56:15 -0000 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.4\)) Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] From: Iain Sandoe In-Reply-To: Date: Thu, 30 Nov 2023 19:56:14 +0000 Cc: FX Coudert , GCC Patches Content-Transfer-Encoding: quoted-printable Message-Id: References: <92993a50-9667-45da-a62-5089e7e052f8@codesourcery.com> <14111ba7-615b-b2e9-6fba-e7bee3728182@codesourcery.com> <9B1D2B19-B4EB-48B0-91EE-9AC33B392875@gmail.com> <2abef445-3ba3-7b8a-29e7-ba736592e325@codesourcery.com> <3CB9E78B-65BF-4706-B13B-01422C42830B@gmail.com> <11A36820-BC70-4A8C-8EAE-85E5CA6FD9F6@gmail.com> To: Ian Lance Taylor X-Mailer: Apple Mail (2.3696.120.41.1.4) X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,KAM_COUK,KAM_DMARC_STATUS,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Ian > On 30 Nov 2023, at 19:43, Ian Lance Taylor wrote: >=20 > On Sun, Oct 22, 2023 at 2:18=E2=80=AFPM FX Coudert = wrote: >>=20 >> Thanks a lot Alexandre for the review! >=20 > This patch changed the files lingo/configure.ac and libgo/configure. > Those files live in an upstream repository and should be changed there > and then merged into the GCC repo, as described in libgo/README.gcc. > This is not a big deal, and I can take care of changing the upstream > repository. But I don't understand the changes in libgo. As far as I > can tell, all they do is add an automake conditional that is never > used. Is there any reason for that? It=E2=80=99s not used (yet) because we do not build libgo on Darwin, = if/when we do it would be used in the same way as for the other runtimes. > Should I just revert the changes to libgo? That is also fine (because we do not yet build it on Darwin), it seems = unlikely we=E2=80=99d forget to re-add it. Iain >=20 > To be clear, I am asking about this change in git revision > 6a6d3817afa02bbcd2388c8e005da6faf88932f1 and the corresponding change > in the generated file libgo/configure.ac. Thanks. >=20 > diff --git a/libgo/configure.ac b/libgo/configure.ac > index 54c35c0903c..e8d66f8415d 100644 > --- a/libgo/configure.ac > +++ b/libgo/configure.ac > @@ -53,6 +53,7 @@ AC_LIBTOOL_DLOPEN > AM_PROG_LIBTOOL > AC_SUBST(enable_shared) > AC_SUBST(enable_static) > +AM_CONDITIONAL([ENABLE_DARWIN_AT_RPATH], [test > x$enable_darwin_at_rpath =3D xyes]) >=20 > CC_FOR_BUILD=3D${CC_FOR_BUILD:-gcc} > AC_SUBST(CC_FOR_BUILD)