Re: [PATCH,AIX] Enable Stack Unwinding on AIX

Re: [PATCH,AIX] Enable Stack Unwinding on AIX

[David Edelsohn]

Please do not email my IBM Notes address with patches.  Please copy
this Gmail address for patch submissions.

>   * libgcc/config/rs6000/aix-unwind.h : Implements stack unwinding on AIX.

This ChangeLog entry clearly is wrong because aix-unwind.h already
implements ppc_aix_fallback_frame_state.  The ChangeLog entry should
reference the exact function being modified and a useful comment about
how it is modified, e.g.,

* config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64
bit support Add 32 bit support for AIX 6.1 and 7.2.

The ChangeLog file is in libgcc, so the file reference is wrong
because it should not use libgcc in the path.

How was this tested?

Thanks, David

RE:[PATCH,AIX] Enable Stack Unwinding on AIX

[REIX, Tony]

Tests:

The change has been tested in 32bit and 64bit on AIX 6.1, 7.1 & 7.2 by using the libbacktrace (with XCOFF support) within a signal handler context (we used a specific back.c program).
And it has been tested with Go tests on AIX for sure (recover tests on SIGSEGV do not work without this change).

ChangeLog:

* config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64 bit support for AIX 6.1 and 7.X and 32 bit support for AIX 7.2.


Cordialement,

Tony Reix

Bull - ATOS
IBM Coop Architect & Technical Leader
Office : +33 (0) 4 76 29 72 67
1 rue de Provence - 38432 Échirolles - France
www.atos.net

________________________________________
De : David Edelsohn [dje.gcc@gmail.com]
Envoyé : lundi 15 mai 2017 22:31
À : REIX, Tony
Cc : GCC Patches; SARTER, MATTHIEU (ext)
Objet : Re: [PATCH,AIX] Enable Stack Unwinding on AIX

Please do not email my IBM Notes address with patches.  Please copy
this Gmail address for patch submissions.

>   * libgcc/config/rs6000/aix-unwind.h : Implements stack unwinding on AIX.

This ChangeLog entry clearly is wrong because aix-unwind.h already
implements ppc_aix_fallback_frame_state.  The ChangeLog entry should
reference the exact function being modified and a useful comment about
how it is modified, e.g.,

* config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64
bit support Add 32 bit support for AIX 6.1 and 7.2.

The ChangeLog file is in libgcc, so the file reference is wrong
because it should not use libgcc in the path.

How was this tested?

Thanks, David

Re: [PATCH,AIX] Enable Stack Unwinding on AIX

[David Edelsohn]

On Tue, May 16, 2017 at 9:50 AM, REIX, Tony <tony.reix@atos.net> wrote:
> Tests:
>
> The change has been tested in 32bit and 64bit on AIX 6.1, 7.1 & 7.2 by using the libbacktrace (with XCOFF support) within a signal handler context (we used a specific back.c program).
> And it has been tested with Go tests on AIX for sure (recover tests on SIGSEGV do not work without this change).
>
> ChangeLog:
>
> * config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64 bit support for AIX 6.1 and 7.X and 32 bit support for AIX 7.2.

If ppc_aix_fallback_frame_state is used for both 32 bit and 64 bit,
there is no need to define it twice.  Just move the
MD_FALLBACK_FRAME_STATE_FOR macro definition outside the #ifdef.  This
also needs a separate ChangeLog comment.

The function that you modified is "ucontext_for".  Please use that
name in the ChangeLog entry.

Will you need someone to apply the patch for you?

Thanks, David