From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14153 invoked by alias); 16 May 2017 13:50:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13054 invoked by uid 89); 16 May 2017 13:50:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=envoy, envoy=e9, lundi, rue?= X-HELO: smtppost.atos.net Received: from smtppost.atos.net (HELO smtppost.atos.net) (193.56.114.166) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 May 2017 13:50:12 +0000 Received: from mail2-ext.my-it-solutions.net (mail2-ext.my-it-solutions.net) by smarthost6.atos.net with smtp (TLS: TLSv1/SSLv3,256bits,ECDHE-RSA-AES256-SHA) id 54fd_52f0_0c8c9a5b_73df_4703_b58e_6baf9f564d65; Tue, 16 May 2017 15:50:13 +0200 Received: from mail2-int.my-it-solutions.net ([10.92.32.13]) by mail2-ext.my-it-solutions.net (8.15.2/8.15.2) with ESMTPS id v4GDoDRS017833 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 16 May 2017 15:50:13 +0200 Received: from FRCRPVV9ET1MSX.ww931.my-it-solutions.net ([172.23.231.41]) by mail2-int.my-it-solutions.net (8.15.2/8.15.2) with ESMTPS id v4GDoCtf030346 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Tue, 16 May 2017 15:50:13 +0200 Received: from FRAUVJ99ET3MSX.ww931.my-it-solutions.net (172.23.231.44) by FRCRPVV9ET1MSX.ww931.my-it-solutions.net (172.23.231.41) with Microsoft SMTP Server (TLS) id 14.3.339.0; Tue, 16 May 2017 15:50:12 +0200 Received: from FRCRPVV9EX3MSX.ww931.my-it-solutions.net ([169.254.6.53]) by FRAUVJ99ET3MSX.ww931.my-it-solutions.net ([172.23.231.44]) with mapi id 14.03.0339.000; Tue, 16 May 2017 15:50:12 +0200 From: "REIX, Tony" To: David Edelsohn CC: GCC Patches , "SARTER, MATTHIEU (ext)" Subject: RE:[PATCH,AIX] Enable Stack Unwinding on AIX Date: Tue, 16 May 2017 13:53:00 -0000 Message-ID: References: In-Reply-To: Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg01282.txt.bz2 Tests: The change has been tested in 32bit and 64bit on AIX 6.1, 7.1 & 7.2 by usin= g the libbacktrace (with XCOFF support) within a signal handler context (we= used a specific back.c program). And it has been tested with Go tests on AIX for sure (recover tests on SIGS= EGV do not work without this change). ChangeLog: * config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64 bit sup= port for AIX 6.1 and 7.X and 32 bit support for AIX 7.2. Cordialement, Tony Reix Bull - ATOS IBM Coop Architect & Technical Leader Office : +33 (0) 4 76 29 72 67 1 rue de Provence - 38432 =C9chirolles - France www.atos.net ________________________________________ De : David Edelsohn [dje.gcc@gmail.com] Envoy=E9 : lundi 15 mai 2017 22:31 =C0 : REIX, Tony Cc : GCC Patches; SARTER, MATTHIEU (ext) Objet : Re: [PATCH,AIX] Enable Stack Unwinding on AIX Please do not email my IBM Notes address with patches. Please copy this Gmail address for patch submissions. > * libgcc/config/rs6000/aix-unwind.h : Implements stack unwinding on AIX. This ChangeLog entry clearly is wrong because aix-unwind.h already implements ppc_aix_fallback_frame_state. The ChangeLog entry should reference the exact function being modified and a useful comment about how it is modified, e.g., * config/rs6000/aix-unwind.h (ppc_aix_fallback_frame_state): Add 64 bit support Add 32 bit support for AIX 6.1 and 7.2. The ChangeLog file is in libgcc, so the file reference is wrong because it should not use libgcc in the path. How was this tested? Thanks, David