* Re: [PATCH,AIX] Enable FFI Go Closure on AIX @ 2017-05-15 20:39 David Edelsohn 2017-05-16 14:50 ` REIX, Tony 0 siblings, 1 reply; 6+ messages in thread From: David Edelsohn @ 2017-05-15 20:39 UTC (permalink / raw) To: REIX, TONY; +Cc: GCC Patches, SARTER, MATTHIEU (ext) This patch needs to be submitted to the libffi project. Also, the ChangeLog needs to specify exactly what is being changed not "Implement Go Closures". The patch clearly touches existing parts of the files that affect more than simply Go closures. How was this tested? libffi is used in many more places than Go, so any changes need to be tested very carefully and thoroughly. What are the results for the libffi testsuite? Have you tried building Python with a version of libffi built with this patch? Thanks, David ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE:[PATCH,AIX] Enable FFI Go Closure on AIX 2017-05-15 20:39 [PATCH,AIX] Enable FFI Go Closure on AIX David Edelsohn @ 2017-05-16 14:50 ` REIX, Tony 2017-05-16 15:26 ` [PATCH,AIX] " David Edelsohn 0 siblings, 1 reply; 6+ messages in thread From: REIX, Tony @ 2017-05-16 14:50 UTC (permalink / raw) To: David Edelsohn; +Cc: GCC Patches, SARTER, MATTHIEU (ext) Hi David, We'll submit the patch to the libffi project asap. We have tested this patch on AIX 6.1 with libffi (master from github) in 32bit and 64bit with same results (same exact failures) when testing with and without our patch, using libffi testsuite. Without patch: === libffi Summary === 64bit & 32bit # of expected passes 1870 # of unexpected failures 38 # of unresolved testcases 2 # of unsupported tests 30 With patch: === libffi Summary === 64bit & 32bit # of expected passes 1890 # of unexpected failures 38 # of unresolved testcases 2 # of unsupported tests 28 We'll test with Python asap, probably this week. Cordialement, Tony Reix Bull - ATOS IBM Coop Architect & Technical Leader Office : +33 (0) 4 76 29 72 67 1 rue de Provence - 38432 Échirolles - France www.atos.net ________________________________________ De : David Edelsohn [dje.gcc@gmail.com] Envoyé : lundi 15 mai 2017 22:36 À : REIX, Tony Cc : GCC Patches; SARTER, MATTHIEU (ext) Objet : Re: [PATCH,AIX] Enable FFI Go Closure on AIX This patch needs to be submitted to the libffi project. Also, the ChangeLog needs to specify exactly what is being changed not "Implement Go Closures". The patch clearly touches existing parts of the files that affect more than simply Go closures. How was this tested? libffi is used in many more places than Go, so any changes need to be tested very carefully and thoroughly. What are the results for the libffi testsuite? Have you tried building Python with a version of libffi built with this patch? Thanks, David ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH,AIX] Enable FFI Go Closure on AIX 2017-05-16 14:50 ` REIX, Tony @ 2017-05-16 15:26 ` David Edelsohn 2017-05-17 12:54 ` REIX, Tony 0 siblings, 1 reply; 6+ messages in thread From: David Edelsohn @ 2017-05-16 15:26 UTC (permalink / raw) To: REIX, Tony; +Cc: GCC Patches, SARTER, MATTHIEU (ext) On Tue, May 16, 2017 at 10:44 AM, REIX, Tony <tony.reix@atos.net> wrote: > Hi David, > > We'll submit the patch to the libffi project asap. > > We have tested this patch on AIX 6.1 with libffi (master from github) in 32bit and 64bit with same results (same exact failures) when testing with and without our patch, using libffi testsuite. > > Without patch: > === libffi Summary === 64bit & 32bit > # of expected passes 1870 > # of unexpected failures 38 > # of unresolved testcases 2 > # of unsupported tests 30 > > With patch: > === libffi Summary === 64bit & 32bit > # of expected passes 1890 > # of unexpected failures 38 > # of unresolved testcases 2 > # of unsupported tests 28 > > We'll test with Python asap, probably this week. Libffi project now is on Github https://github.com/libffi/libffi I think that Anthony now uses pull requests. Once the patches are in the upstream project, we can backport them to GCC. Thanks, David ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE:[PATCH,AIX] Enable FFI Go Closure on AIX 2017-05-16 15:26 ` [PATCH,AIX] " David Edelsohn @ 2017-05-17 12:54 ` REIX, Tony 2017-05-17 13:41 ` REIX, Tony 0 siblings, 1 reply; 6+ messages in thread From: REIX, Tony @ 2017-05-17 12:54 UTC (permalink / raw) To: David Edelsohn; +Cc: GCC Patches, SARTER, MATTHIEU (ext) Hi, We have built and installed the libffi master of yesterday on a AIX 6.1 machine and we have rebuilt and tested Python3 (3.5.2) with this libffi. And that is OK. 32bit and 64bit. 5 more tests were run and succeeded. And 1 test (test_ssl) which was skipped before is now run but failed due to no access to Web (Resource 'sha256.tbs-internet.com' is not available). So. our patch does not break libffi build and tests, nor Python3 build and tests. That looks OK. We'll submit the patch to the libffi project now. Regards, Tony With New libffi: 369 tests OK. 12 tests failed: test_asyncio test_distutils test_eintr test_httpservers test_locale test_posix test_socket test_ssl test_tools test_urllib2 test_urllib2_localnet test_urllib2net 1 test altered the execution environment: test_io 16 tests skipped: test_devpoll test_epoll test_gdb test_kqueue test_msilib test_ossaudiodev test_pep277 test_spwd test_startfile test_tix test_tk test_ttk_guionly test_unicode_file test_winreg test_winsound test_zipfile64 With previous libffi: 364 tests OK. 11 tests failed: test_asyncio test_distutils test_eintr test_httpservers test_locale test_posix test_socket test_tools test_urllib2 test_urllib2_localnet test_urllib2net 1 test altered the execution environment: test_io 22 tests skipped: test_devpoll test_epoll test_gdb test_idle test_kqueue test_msilib test_ossaudiodev test_pep277 test_smtpnet test_spwd test_ssl test_startfile test_tcl test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle test_unicode_file test_winreg test_winsound test_zipfile64 # rpm -qa | grep python3 python3-3.5.2-3 # rpm -qa | grep ffi libffi-devel-20170516-1 libffi-20170516-1 # ldd python python needs: /usr/lib/threads/libc.a(shr.o) /usr/lib/libpthreads.a(shr_xpg5.o) /opt/freeware/src/packages/BUILD/Python-3.5.2/64bit/libpython3.5m.so /opt/freeware/lib/libffi.a(libffi.so.7) /unix /usr/lib/libcrypt.a(shr.o) /usr/lib/libpthreads.a(shr_comm.o) /opt/freeware/lib/libgcc_s.a(shr.o) /usr/lib/threads/libc.a(shr_64.o) /usr/lib/libpthreads.a(shr_xpg5_64.o) /opt/freeware/lib/libintl.a(libintl.so.9) /usr/lib/libcrypt.a(shr_64.o) /opt/freeware/lib/libiconv.a(libiconv.so.2) Cordialement, Tony Reix Bull - ATOS IBM Coop Architect & Technical Leader Office : +33 (0) 4 76 29 72 67 1 rue de Provence - 38432 Échirolles - France www.atos.net ________________________________________ De : David Edelsohn [dje.gcc@gmail.com] Envoyé : mardi 16 mai 2017 17:11 À : REIX, Tony Cc : GCC Patches; SARTER, MATTHIEU (ext) Objet : Re: [PATCH,AIX] Enable FFI Go Closure on AIX On Tue, May 16, 2017 at 10:44 AM, REIX, Tony <tony.reix@atos.net> wrote: > Hi David, > > We'll submit the patch to the libffi project asap. > > We have tested this patch on AIX 6.1 with libffi (master from github) in 32bit and 64bit with same results (same exact failures) when testing with and without our patch, using libffi testsuite. > > Without patch: > === libffi Summary === 64bit & 32bit > # of expected passes 1870 > # of unexpected failures 38 > # of unresolved testcases 2 > # of unsupported tests 30 > > With patch: > === libffi Summary === 64bit & 32bit > # of expected passes 1890 > # of unexpected failures 38 > # of unresolved testcases 2 > # of unsupported tests 28 > > We'll test with Python asap, probably this week. Libffi project now is on Github https://github.com/libffi/libffi I think that Anthony now uses pull requests. Once the patches are in the upstream project, we can backport them to GCC. Thanks, David ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE:[PATCH,AIX] Enable FFI Go Closure on AIX 2017-05-17 12:54 ` REIX, Tony @ 2017-05-17 13:41 ` REIX, Tony 2017-05-17 13:46 ` [PATCH,AIX] " David Edelsohn 0 siblings, 1 reply; 6+ messages in thread From: REIX, Tony @ 2017-05-17 13:41 UTC (permalink / raw) To: David Edelsohn; +Cc: GCC Patches, SARTER, MATTHIEU (ext) Patch has been submitted to libffi github : https://github.com/libffi/libffi/pull/308 . Regards, Cordialement, Tony Reix Bull - ATOS IBM Coop Architect & Technical Leader Office : +33 (0) 4 76 29 72 67 1 rue de Provence - 38432 Échirolles - France www.atos.net ________________________________________ De : REIX, Tony Envoyé : mercredi 17 mai 2017 14:53 À : David Edelsohn Cc : GCC Patches; SARTER, MATTHIEU (ext) Objet : RE:[PATCH,AIX] Enable FFI Go Closure on AIX Hi, We have built and installed the libffi master of yesterday on a AIX 6.1 machine and we have rebuilt and tested Python3 (3.5.2) with this libffi. And that is OK. 32bit and 64bit. 5 more tests were run and succeeded. And 1 test (test_ssl) which was skipped before is now run but failed due to no access to Web (Resource 'sha256.tbs-internet.com' is not available). So. our patch does not break libffi build and tests, nor Python3 build and tests. That looks OK. We'll submit the patch to the libffi project now. Regards, Tony With New libffi: 369 tests OK. 12 tests failed: test_asyncio test_distutils test_eintr test_httpservers test_locale test_posix test_socket test_ssl test_tools test_urllib2 test_urllib2_localnet test_urllib2net 1 test altered the execution environment: test_io 16 tests skipped: test_devpoll test_epoll test_gdb test_kqueue test_msilib test_ossaudiodev test_pep277 test_spwd test_startfile test_tix test_tk test_ttk_guionly test_unicode_file test_winreg test_winsound test_zipfile64 With previous libffi: 364 tests OK. 11 tests failed: test_asyncio test_distutils test_eintr test_httpservers test_locale test_posix test_socket test_tools test_urllib2 test_urllib2_localnet test_urllib2net 1 test altered the execution environment: test_io 22 tests skipped: test_devpoll test_epoll test_gdb test_idle test_kqueue test_msilib test_ossaudiodev test_pep277 test_smtpnet test_spwd test_ssl test_startfile test_tcl test_tix test_tk test_ttk_guionly test_ttk_textonly test_turtle test_unicode_file test_winreg test_winsound test_zipfile64 # rpm -qa | grep python3 python3-3.5.2-3 # rpm -qa | grep ffi libffi-devel-20170516-1 libffi-20170516-1 # ldd python python needs: /usr/lib/threads/libc.a(shr.o) /usr/lib/libpthreads.a(shr_xpg5.o) /opt/freeware/src/packages/BUILD/Python-3.5.2/64bit/libpython3.5m.so /opt/freeware/lib/libffi.a(libffi.so.7) /unix /usr/lib/libcrypt.a(shr.o) /usr/lib/libpthreads.a(shr_comm.o) /opt/freeware/lib/libgcc_s.a(shr.o) /usr/lib/threads/libc.a(shr_64.o) /usr/lib/libpthreads.a(shr_xpg5_64.o) /opt/freeware/lib/libintl.a(libintl.so.9) /usr/lib/libcrypt.a(shr_64.o) /opt/freeware/lib/libiconv.a(libiconv.so.2) Cordialement, Tony Reix Bull - ATOS IBM Coop Architect & Technical Leader Office : +33 (0) 4 76 29 72 67 1 rue de Provence - 38432 Échirolles - France www.atos.net ________________________________________ De : David Edelsohn [dje.gcc@gmail.com] Envoyé : mardi 16 mai 2017 17:11 À : REIX, Tony Cc : GCC Patches; SARTER, MATTHIEU (ext) Objet : Re: [PATCH,AIX] Enable FFI Go Closure on AIX On Tue, May 16, 2017 at 10:44 AM, REIX, Tony <tony.reix@atos.net> wrote: > Hi David, > > We'll submit the patch to the libffi project asap. > > We have tested this patch on AIX 6.1 with libffi (master from github) in 32bit and 64bit with same results (same exact failures) when testing with and without our patch, using libffi testsuite. > > Without patch: > === libffi Summary === 64bit & 32bit > # of expected passes 1870 > # of unexpected failures 38 > # of unresolved testcases 2 > # of unsupported tests 30 > > With patch: > === libffi Summary === 64bit & 32bit > # of expected passes 1890 > # of unexpected failures 38 > # of unresolved testcases 2 > # of unsupported tests 28 > > We'll test with Python asap, probably this week. Libffi project now is on Github https://github.com/libffi/libffi I think that Anthony now uses pull requests. Once the patches are in the upstream project, we can backport them to GCC. Thanks, David ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH,AIX] Enable FFI Go Closure on AIX 2017-05-17 13:41 ` REIX, Tony @ 2017-05-17 13:46 ` David Edelsohn 0 siblings, 0 replies; 6+ messages in thread From: David Edelsohn @ 2017-05-17 13:46 UTC (permalink / raw) To: REIX, Tony; +Cc: GCC Patches, SARTER, MATTHIEU (ext) On Wed, May 17, 2017 at 9:11 AM, REIX, Tony <tony.reix@atos.net> wrote: > Patch has been submitted to libffi github : https://github.com/libffi/libffi/pull/308 . Good. There still was no ChangeLog included with the patch. Also, the new functions in the patch are not consistent with the insertion of the word "go". Sometimes it is near the end, like ffi_call_go_AIX, and sometimes it is near the beginning, like ffi_go_closure_DARWIN. The naming should be consistent. Thanks, David ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-05-17 13:41 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-05-15 20:39 [PATCH,AIX] Enable FFI Go Closure on AIX David Edelsohn 2017-05-16 14:50 ` REIX, Tony 2017-05-16 15:26 ` [PATCH,AIX] " David Edelsohn 2017-05-17 12:54 ` REIX, Tony 2017-05-17 13:41 ` REIX, Tony 2017-05-17 13:46 ` [PATCH,AIX] " David Edelsohn
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).