public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* Re: [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store [fwd: tobias.burnus@physik.fu-berlin.de]
@ 2011-05-03 10:14 Tobias Burnus
  2011-05-03 11:50 ` Jerry DeLisle
  2011-05-03 15:28 ` Mike Stump
  0 siblings, 2 replies; 4+ messages in thread
From: Tobias Burnus @ 2011-05-03 10:14 UTC (permalink / raw)
  To: gcc-patches, fortran

Rainer,

Rainer Orth wrote:
> Jerry DeLisle wrote:
> > This is OK.  We are working on a solution, so maybe it would be better to
> > XFAIL it so that when it does get fixed it will be flagged. It also fails
> > on i686-pc-gnu.
>
> is this a solution for this particular case or for the general need to
> sometimes use -ffloat-store?  In the former case, I'd agree, in the
> latter it's probably better to consistently use -ffloat-store in the
> testcases and review those uses once a solution is in place.

I think the issue is PR 48602 - wrong I/O output due to wrong rounding
and algorithm bugs. The PR has been mostly fixed, but the excess
precision of the x87 processor still causes failures. One solution
might be to compile the whole libgfortran/io/ with
-fexcess-precision=standard. Adding a single
"asm volatile ("" : "+m" (temp))" proved to be insufficient.

Tobias

PS: Especially as you are listed as testsuite maintainer, I would be
happy if you could comment on the testsuite patch at
http://gcc.gnu.org/ml/fortran/2011-04/msg00331.html

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store [fwd: tobias.burnus@physik.fu-berlin.de]
  2011-05-03 10:14 [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store [fwd: tobias.burnus@physik.fu-berlin.de] Tobias Burnus
@ 2011-05-03 11:50 ` Jerry DeLisle
  2011-05-05 14:02   ` Rainer Orth
  2011-05-03 15:28 ` Mike Stump
  1 sibling, 1 reply; 4+ messages in thread
From: Jerry DeLisle @ 2011-05-03 11:50 UTC (permalink / raw)
  To: Tobias Burnus; +Cc: gcc-patches, fortran

On 05/03/2011 03:14 AM, Tobias Burnus wrote:
> Rainer,
>
> Rainer Orth wrote:
>> Jerry DeLisle wrote:
>>> This is OK.  We are working on a solution, so maybe it would be better to
>>> XFAIL it so that when it does get fixed it will be flagged. It also fails
>>> on i686-pc-gnu.
>>
>> is this a solution for this particular case or for the general need to
>> sometimes use -ffloat-store?  In the former case, I'd agree, in the
>> latter it's probably better to consistently use -ffloat-store in the
>> testcases and review those uses once a solution is in place.
>
> I think the issue is PR 48602 - wrong I/O output due to wrong rounding
> and algorithm bugs. The PR has been mostly fixed, but the excess
> precision of the x87 processor still causes failures. One solution
> might be to compile the whole libgfortran/io/ with
> -fexcess-precision=standard. Adding a single
> "asm volatile ("" : "+m" (temp))" proved to be insufficient.
>
> Tobias
>
> PS: Especially as you are listed as testsuite maintainer, I would be
> happy if you could comment on the testsuite patch at
> http://gcc.gnu.org/ml/fortran/2011-04/msg00331.html
>

My goal is to completely not use any floating point operations for that section 
of code.  We have a concept on how to do it.  I am still working out tweaks to 
48787, then I will turn my attention to this. Feel free to quiet that test case 
any way you wish in the meantime.

Jerry

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store [fwd: tobias.burnus@physik.fu-berlin.de]
  2011-05-03 10:14 [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store [fwd: tobias.burnus@physik.fu-berlin.de] Tobias Burnus
  2011-05-03 11:50 ` Jerry DeLisle
@ 2011-05-03 15:28 ` Mike Stump
  1 sibling, 0 replies; 4+ messages in thread
From: Mike Stump @ 2011-05-03 15:28 UTC (permalink / raw)
  To: Tobias Burnus; +Cc: gcc-patches, fortran

On May 3, 2011, at 3:14 AM, Tobias Burnus <tobias.burnus@physik.fu-berlin.de> wrote:
> PS: Especially as you are listed as testsuite maintainer, I would be
> happy if you could comment on the testsuite patch at
> http://gcc.gnu.org/ml/fortran/2011-04/msg00331.html

Ok.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store [fwd: tobias.burnus@physik.fu-berlin.de]
  2011-05-03 11:50 ` Jerry DeLisle
@ 2011-05-05 14:02   ` Rainer Orth
  0 siblings, 0 replies; 4+ messages in thread
From: Rainer Orth @ 2011-05-05 14:02 UTC (permalink / raw)
  To: Jerry DeLisle; +Cc: Tobias Burnus, gcc-patches, fortran

Jerry,

> My goal is to completely not use any floating point operations for that
> section of code.  We have a concept on how to do it.  I am still working
> out tweaks to 48787, then I will turn my attention to this. Feel free to
> quiet that test case any way you wish in the meantime.

ok, I've commited my original patch as a workaround.

Thanks.
        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-05-05 13:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-03 10:14 [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store [fwd: tobias.burnus@physik.fu-berlin.de] Tobias Burnus
2011-05-03 11:50 ` Jerry DeLisle
2011-05-05 14:02   ` Rainer Orth
2011-05-03 15:28 ` Mike Stump

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).