From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id A31D13858D35 for ; Wed, 8 Nov 2023 10:01:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A31D13858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A31D13858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::430 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699437681; cv=none; b=RLreuAmkAUvkMSQpcRFX7chMOkR/lLKmitHpL045mDPXcAGSD4FpR3TTdU6k86ZZE0I8GAXOXgcshna8Zmrd7K9QBkhAWuVzxRQTfLgf2fj3Oe+qLXJs6WZOS3yUTF5RhKILszC6I+5nHl573j8MdcK45fXvhEt7YLmWOBF9f24= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699437681; c=relaxed/simple; bh=GOhv6aUtz/gcZQ4Uq4tJts+K27CRFqfd/fxdHEgBd+c=; h=DKIM-Signature:From:Mime-Version:Subject:Date:Message-Id:To; b=URT5uBHsk9kvEIdTFLy1ECxNDdCoqowrlqJUYkpGM94HqeeUThfBIcnGLgu4tPytzjUsc8eZPeaEOz1eBgmEKh7KEHyYqpZOo3OpkpW4ZOIWCIbnDkRfdLT7aPyyfx3z/IulBcvR9BBekfTjm/AlUqK8+0cC6mwkc2PhEY+WsYI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32db188e254so4018041f8f.0 for ; Wed, 08 Nov 2023 02:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1699437678; x=1700042478; darn=gcc.gnu.org; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=jSfb1ZTsCodo6qg8EYipoGpCLDicARiC0oJRv+8aN7A=; b=WABPYkYWY6uAYaoLmeItnHlBFU2BIv/jYuV+Y2+vvvC3G9ueCxFKzlXqBYDjx496Oh PCbDPt/SxLiyPaQHTzcJvu8wCmLRiSGoV2EmaZcLGH84hmeSPwekFW6Ctg/+8+1JQJN7 ABuJBWlJzP3CmDtR621D+c3x7qWP86wkdWJrLMYvq4hcp8MNQ5Waec1Jvp34KzNDgbSu g2wyhofMukelEaFL9HBLasQ9Va8E4FdI4Rx0u5/JkOCSA+ZX9T6sYvvksie5unDqm5xG m9UAhx+CF38uR0VAxeVkdeJ5mmHNfRu/XTQV8L78v3x1Lr4wsh7p5ftTGHEVymmSiiNs GLUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699437678; x=1700042478; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jSfb1ZTsCodo6qg8EYipoGpCLDicARiC0oJRv+8aN7A=; b=ACQXPhJZqHjvDDLufhg2fx7N82mc6Wrm5GWOJCLt8cJBNVvy/uu5uGOkgUVCbOMRzG ecG7iXnH8JYoGC29Lvdm8CkwVsXU/lcBolP9jlixEuOv9h0wyB/vReIznc2KZ4rRSqtJ stiC9KWCSO6mVFU2t5O5vG7Znp++yUvvZiCyNP5ytH2CFf8gH634E/gQDYEZ+dKIkNo+ opXkl3GYwN6w4aceSrkOtysPQr4jCkZ0O1TvaWemiaA7j6Fw+wDTRLJCJtnUvg7g5bMn GaKLIpQ17GlvkEo4g4yxEJ3puWLrBEcGTI3MgLoHcQ3S4ykB1TBYz7eT86YuP6933lve lhPw== X-Gm-Message-State: AOJu0YxX0hrVdIk3qaxAR6tgq/vUG56GCckwFE/5ng5lc38ONEWVIqd7 LpBFP3yk7VgUCm12b24/UVCORKSR52Q= X-Google-Smtp-Source: AGHT+IFbEfQVixioPyz2WvQ4LSSXtwSc0dZUhhtrJ0u/1Ej/iqfh6/n5Mi5TEVEzghbj3BsGn3U1EA== X-Received: by 2002:adf:fa07:0:b0:32f:e1a2:526a with SMTP id m7-20020adffa07000000b0032fe1a2526amr915329wrr.67.1699437677474; Wed, 08 Nov 2023 02:01:17 -0800 (PST) Received: from smtpclient.apple ([2a02:3032:304:638d:acdb:d28d:98b9:a925]) by smtp.gmail.com with ESMTPSA id i12-20020a5d630c000000b0032dba85ea1bsm4536912wru.75.2023.11.08.02.01.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Nov 2023 02:01:16 -0800 (PST) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH 1/3] tree-ssa-sink: do not sink to in front of setjmp Date: Wed, 8 Nov 2023 11:01:05 +0100 Message-Id: References: <87o7g48vli.fsf@oldenburg.str.redhat.com> Cc: Alexander Monakov via Gcc-patches , Alexander Monakov In-Reply-To: <87o7g48vli.fsf@oldenburg.str.redhat.com> To: Florian Weimer X-Mailer: iPhone Mail (20H115) X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 08.11.2023 um 10:04 schrieb Florian Weimer : >=20 > =EF=BB=BF* Alexander Monakov via Gcc-patches: >=20 >> diff --git a/gcc/testsuite/gcc.dg/setjmp-7.c b/gcc/testsuite/gcc.dg/setjm= p-7.c >> new file mode 100644 >> index 000000000..44b5bcbfa >> --- /dev/null >> +++ b/gcc/testsuite/gcc.dg/setjmp-7.c >> @@ -0,0 +1,13 @@ >> +/* { dg-do compile } */ >> +/* { dg-options "-O2 -fno-guess-branch-probability -w" } */ >> +/* { dg-require-effective-target indirect_jumps } */ >> + >> +struct __jmp_buf_tag { }; >> +typedef struct __jmp_buf_tag jmp_buf[1]; >> +struct globals { jmp_buf listingbuf; }; >> +extern struct globals *const ptr_to_globals; >> +void foo() >> +{ >> + if ( _setjmp ( ((*ptr_to_globals).listingbuf ))) >> + ; >> +} >=20 > Is the implicit declaration of _setjmp important to this test? > Could we declare it explicitly instead? It shouldn=E2=80=99t be important. > Thanks, > Florian >=20