From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2316 invoked by alias); 19 May 2015 18:46:13 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2306 invoked by uid 89); 19 May 2015 18:46:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 May 2015 18:46:11 +0000 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 7610A260D7746; Tue, 19 May 2015 19:46:05 +0100 (IST) Received: from hhmail02.hh.imgtec.org (10.100.10.20) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 19 May 2015 19:46:08 +0100 Received: from hhmail02.hh.imgtec.org ([::1]) by hhmail02.hh.imgtec.org ([::1]) with mapi id 14.03.0224.002; Tue, 19 May 2015 19:46:08 +0100 From: Robert Suchanek To: "Maciej W. Rozycki" CC: Matthew Fortune , "Catherine_Moore@mentor.com" , "gcc-patches@gcc.gnu.org" , Steve Ellcey Subject: RE: [PATCH, MIPS]: Fix internal compiler error: in check_bool_attrs, at recog.c:2218 for micromips attribute Date: Tue, 19 May 2015 18:59:00 -0000 Message-ID: References: <6D39441BF12EF246A7ABCE6654B02353210594BF@LEMAIL01.le.imgtec.org> In-Reply-To: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg01741.txt.bz2 Hi, The original patch had a missing declaration of micromips_globals in mips.h= =20 that appears to be the cause of segmentation faults when building mips-mti-= linux-gnu. I didn't get any failures just before the submission neither on mips-img-li= nux-gnu nor mips64el-linux-gnu and the test case is too trivial to trigger the ICE. Below is the missing line. With this change mips-mti-linux-gnu builds fine. The trunk is unstable and needed another patch from PR66181 to build Glibc. Ok to commit? > We could add -mflip-micromips complementing -mflip-mips16 and use that > for testing too. Chances are it'd reveal further issues. Looking at how > -mflip-mips16 has been implemented it does not appear to me adding > -mflip-micromips would be a lot of effort. I'm in favour of adding such a switch since the testsuite doesn't cover=20 a mixture of MIPS and microMIPS code. Regards, Robert gcc/ * config/mips/mips.h (micromips_globals): Declare. --- gcc/config/mips/mips.h | 1 + 1 file changed, 1 insertion(+) diff --git a/gcc/config/mips/mips.h b/gcc/config/mips/mips.h index 0ea4e6d..85c8a97 100644 --- a/gcc/config/mips/mips.h +++ b/gcc/config/mips/mips.h @@ -3108,6 +3108,7 @@ extern const struct mips_cpu_info *mips_arch_info; extern const struct mips_cpu_info *mips_tune_info; extern unsigned int mips_base_compression_flags; extern GTY(()) struct target_globals *mips16_globals; +extern GTY(()) struct target_globals *micromips_globals; #endif =20 /* Enable querying of DFA units. */ --=20 2.2.2