public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Robert Suchanek <Robert.Suchanek@imgtec.com>
To: Matthew Fortune <Matthew.Fortune@imgtec.com>,
	"Catherine_Moore@mentor.com"	<Catherine_Moore@mentor.com>,
	Prachi Godbole <Prachi.Godbole@imgtec.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: RE: [PATCH, MIPS] Scheduling for M51xx core family
Date: Wed, 22 Jul 2015 12:56:00 -0000	[thread overview]
Message-ID: <B5E67142681B53468FAF6B7C31356562441ACAEE@hhmail02.hh.imgtec.org> (raw)
In-Reply-To: <6D39441BF12EF246A7ABCE6654B02353211EC43A@LEMAIL01.le.imgtec.org>

Hi Matthew,

> > gcc/
> >
> > 	* config/mips/m5100.md: New file.
> > 	* config/mips/mips-cpus.def (m5100, m5101): Define.
> > 	* config/mips/mips-tables.opt: Regenerate.
> > 	* config/mips/mips.c (mips_rtx_cost_data): Add costs for m5100.
> > 	* config/mips/mips.h (MIPS_ISA_LEVEL_SPEC): Map -march=m5100 and
> > 	-march=m5101 to -mips32r5.
> > 	(MIPS_ARCH_FLOAT_SPEC): Map -m5101 to -msoft-float.
> > 	(MIPS_ISA_NAN2008_SPEC): Map -march=m51* to -mnan=2008 if
> > 	!-msoft-float.
> > 	* config/mips/mips.md: Include m5100.md.
> > 	(processor): Add m5100.
> > 	* doc/invoke.texi (-march=@var{arch}): Add m5100, m5101.
> 
> OK, this looks fine.

The patch committed as r226065.

> I did realise while reading through this that the MIPS_ARCH_FLOAT_SPEC
> is not used for and ordinary MIPS Linux compiler which seems odd but
> I presume this is to make it possible to use one hard-float sysroot
> for any core and emulate the FPU when not present.
> 
> I think it is probably a mistake to have put MIPS_ARCH_FLOAT_SPEC in
> the mti-linux.h and android.h DRIVER_SELF_SPECS so I think they need
> removing. Although we support building soft-float multilibs I don't
> think they actually get used very much so leaving the selection of
> soft-float down to the end user in Linux seems wise.
> 
> With the i6400 scheduler committed then we can also get rid of the w32
> and w64 placeholders that were there solely to provide an R6 processor
> to use as the default processor for the generic arch options.

I'll send a follow-up patch to remove the redundant bits.

Regards,
Robert

      reply	other threads:[~2015-07-22 12:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 14:51 Robert Suchanek
2015-07-18 16:03 ` Richard Sandiford
2015-07-18 22:14   ` Matthew Fortune
2015-07-23 21:29     ` Richard Sandiford
2015-07-20 21:49 ` Matthew Fortune
2015-07-22 12:56   ` Robert Suchanek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B5E67142681B53468FAF6B7C31356562441ACAEE@hhmail02.hh.imgtec.org \
    --to=robert.suchanek@imgtec.com \
    --cc=Catherine_Moore@mentor.com \
    --cc=Matthew.Fortune@imgtec.com \
    --cc=Prachi.Godbole@imgtec.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).