public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Robert Suchanek <Robert.Suchanek@imgtec.com>
To: Matthew Fortune <Matthew.Fortune@imgtec.com>,
	"Catherine_Moore@mentor.com"	<Catherine_Moore@mentor.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [PATCH] Disable -mbranch-likely for -Os when targetting generic architecture
Date: Fri, 14 Aug 2015 13:14:00 -0000	[thread overview]
Message-ID: <B5E67142681B53468FAF6B7C31356562441B05F4@hhmail02.hh.imgtec.org> (raw)

Hi,

The patch below disables generation of the branch likely instructions for -Os
but only for generic architecture.  The branch likely may result in some
code size reduction but the cost of running the code on R6 core is significant.

Disabling this for generic architecture would therefore be desirable for now.

Ok to apply?

Regards,
Robert

gcc/
	* mips.c (mips_option_override): Enable branch likely for non-generic
	architecture.
---
 gcc/config/mips/mips.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
index a9829bd..68def06 100644
--- a/gcc/config/mips/mips.c
+++ b/gcc/config/mips/mips.c
@@ -19564,7 +19564,7 @@ mips_option_override (void)
   if ((target_flags_explicit & MASK_BRANCHLIKELY) == 0)
     {
       if (ISA_HAS_BRANCHLIKELY
-	  && (optimize_size
+	  && ((optimize_size && strncmp (mips_arch_info->name, "mips", 4) != 0)
 	      || (mips_tune_info->tune_flags & PTF_AVOID_BRANCHLIKELY) == 0))
 	target_flags |= MASK_BRANCHLIKELY;
       else
-- 
2.4.5

             reply	other threads:[~2015-08-14 12:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 13:14 Robert Suchanek [this message]
2015-08-20 20:15 ` Richard Sandiford
2015-08-20 21:52   ` Matthew Fortune
2015-09-04 14:29     ` Robert Suchanek
2015-10-22 19:09       ` Moore, Catherine
2016-05-24 15:35         ` Robert Suchanek
2016-09-21 13:32           ` Matthew Fortune
2016-10-11  8:00             ` Robert Suchanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B5E67142681B53468FAF6B7C31356562441B05F4@hhmail02.hh.imgtec.org \
    --to=robert.suchanek@imgtec.com \
    --cc=Catherine_Moore@mentor.com \
    --cc=Matthew.Fortune@imgtec.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).