From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84857 invoked by alias); 25 May 2016 07:36:40 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 84844 invoked by uid 89); 25 May 2016 07:36:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=balance, protect X-HELO: mailapp01.imgtec.com Received: from mailapp01.imgtec.com (HELO mailapp01.imgtec.com) (195.59.15.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 25 May 2016 07:36:38 +0000 Received: from HHMAIL01.hh.imgtec.org (unknown [10.100.10.19]) by Websense Email with ESMTPS id EA1385F8DC5E7; Wed, 25 May 2016 08:36:32 +0100 (IST) Received: from hhmail02.hh.imgtec.org ([fe80::5400:d33e:81a4:f775]) by HHMAIL01.hh.imgtec.org ([fe80::710b:f219:72bc:e0b3%26]) with mapi id 14.03.0266.001; Wed, 25 May 2016 08:36:35 +0100 From: Robert Suchanek To: Sandra Loosemore , "Catherine_Moore@mentor.com" , Matthew Fortune CC: "gcc-patches@gcc.gnu.org" Subject: RE: [PATCH][MIPS] Add -minline-intermix to ignore compression flags when inlining Date: Wed, 25 May 2016 10:16:00 -0000 Message-ID: References: <5744FF77.2000409@codesourcery.com> In-Reply-To: <5744FF77.2000409@codesourcery.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2016-05/txt/msg01994.txt.bz2 Hi Sandra, > > diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi > > index 73f1cb6..2f6195e 100644 > > --- a/gcc/doc/invoke.texi > > +++ b/gcc/doc/invoke.texi > > @@ -837,6 +837,7 @@ Objective-C and Objective-C++ Dialects}. > > -mips16 -mno-mips16 -mflip-mips16 @gol > > -minterlink-compressed -mno-interlink-compressed @gol > > -minterlink-mips16 -mno-interlink-mips16 @gol > > +-minline-intermix -mno-inline-intermix @gol >=20 > Funky indentation here.... I'm not sure what's wrong here, it's the diff I'd say. There is no indentation within "MIPS Options". >=20 > > -mabi=3D@var{abi} -mabicalls -mno-abicalls @gol > > -mshared -mno-shared -mplt -mno-plt -mxgot -mno-xgot @gol > > -mgp32 -mgp64 -mfp32 -mfpxx -mfp64 -mhard-float -msoft-float @g= ol > > @@ -17916,6 +17917,18 @@ Aliases of @option{-minterlink-compressed} and > > @option{-mno-interlink-compressed}. These options predate the microM= IPS > ASE > > and are retained for backwards compatibility. > > > > +@item -minline-intermix > > +@itemx -mno-inline-intermix > > +@opindex minline-intermix > > +@opindex mno-inline-intermix > > +Enable inlining of functions which have opposing compression flags e.g. > > +@code{mips16}/@code{nomips16} attributes. > > +This is useful when using the @code{mips16} attribute to balance code = size > > +and performance so that a function will be compressed when not inlined= or > > +vice-versa. When using this option it is necessary to protect functio= ns > > +that cannot be compiled as MIPS16 with a @code{noinline} attribute to = ensure > > +they are not inlined into a MIPS16 function. >=20 > This flag applies to microMIPS inlining, too, right?=20 That's correct. > It's confusing to only mention MIPS16. Indeed. The option originated from MIPS16 but it can be applied to microMI= PS and it's better to mention it. >=20 > Maybe you could say something like this instead: >=20 > Allow inlining even if the compression flags differ between caller and > callee. This is useful in conjunction with the @code{mips16}, > @code{micromips}, or @code{nocompression} function attributes. The code > for the inlined function is compiled using the compression flags for the > callee, so you may need to use the @code{noinline} attribute on > functions that must be compiled with particular compression settings. This sounds better. Thanks and regards, Robert