* [PATCH] testsuite, darwin: improve check for -shared support
@ 2024-03-07 20:44 FX Coudert
0 siblings, 0 replies; only message in thread
From: FX Coudert @ 2024-03-07 20:44 UTC (permalink / raw)
To: GCC Patches; +Cc: Iain Sandoe
[-- Attachment #1: Type: text/plain, Size: 244 bytes --]
The undefined symbols are allowed for C checks, but when
this is run as C++, the mangled foo() symbol is still
seen as undefined, and the testsuite thinks darwin does not
support -shared.
Pushed after approval by Iain Sandoe in PR114233
FX
[-- Attachment #2: 0001-testsuite-darwin-improve-check-for-shared-support.patch --]
[-- Type: application/octet-stream, Size: 1292 bytes --]
From 0ed6e5b4820e01fa86b48a7b1d62f752ec97ea41 Mon Sep 17 00:00:00 2001
From: Francois-Xavier Coudert <fxcoudert@gcc.gnu.org>
Date: Thu, 7 Mar 2024 17:27:17 +0100
Subject: [PATCH] testsuite, darwin: improve check for -shared support
The undefined symbols are allowed for C checks, but when
this is run as C++, the mangled foo() symbol is still
seen as undefined, and the testsuite thinks darwin does not
support -shared.
gcc/testsuite/ChangeLog:
PR target/114233
* lib/target-supports.exp: Fix test for C++.
---
gcc/testsuite/lib/target-supports.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index ae33c4f1e3a..467b539b20d 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -1390,7 +1390,7 @@ proc check_effective_target_shared { } {
# here to be undefined.
set extra_flags ""
if { [istarget *-*-darwin\[912\]*] } {
- set extra_flags "-Wl,-U,_foo,-U,_bar"
+ set extra_flags "-Wl,-U,_foo,-U,_bar,-U,__Z3foov"
}
# Note that M68K has a multilib that supports -fpic but not
# -fPIC, so we need to check both. We test with a program that
--
2.39.3 (Apple Git-146)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-03-07 20:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-07 20:44 [PATCH] testsuite, darwin: improve check for -shared support FX Coudert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).