[PATCH][PING][Revised] fix --enable-build-with-cxx on darwin]

[PATCH][PING][Revised] fix --enable-build-with-cxx on darwin]

[Jack Howarth]

   Could someone commit this patch, which was already approved in

http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00411.html

The absence of this patch in gcc trunk prevents --enable-build-with-cxx 
from working on darwin. Thanks in advance.
          Jack

----- Forwarded message from Jack Howarth <howarth@bromo.med.uc.edu> -----

X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bromo.med.uc.edu
X-Spam-Level: 
X-Spam-Status: No, score=-1.5 required=4.4 tests=AWL,BAYES_00,
	DNS_FROM_OPENWHOIS,FH_DATE_PAST_20XX,RCVD_IN_DNSWL_MED autolearn=no
	version=3.2.5
X-Original-To: howarth@bromo.med.uc.edu
Delivered-To: howarth@bromo.med.uc.edu
X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_CX,T_RP_MATCHES_RCVD
Date: Thu, 5 May 2011 08:58:26 -0400
From: Jack Howarth <howarth@bromo.med.uc.edu>
To: gcc-patches@gcc.gnu.org
Subject: [PATCH][Revised] fix --enable-build-with-cxx on darwin
User-Agent: Mutt/1.5.18 (2008-05-17)
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <mailto:gcc-patches-unsubscribe-howarth=bromo.msbb.uc.edu@gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Delivered-To: mailing list gcc-patches@gcc.gnu.org

Currently the bootstrap with --enable-build-with-cxx is broken due to compiler errors of the form
"error: converting 'false' to pointer type 'varpool_node*' [-Werror=conversion-null]". The attached
patch changes the last remaing instance of false to NULL and restores the --enable-build-with-cxx bootstrap.
Tested on x86_64-apple-darwin10. Okay for gcc trunk?
                Jack

2011-05-05  Jack Howarth <howarth@bromo.med.uc.edu>

	* gcc/varpool.c (varpool_extra_name_alias): Likewise.

Index: gcc/varpool.c
===================================================================
--- gcc/varpool.c	(revision 173423)
+++ gcc/varpool.c	(working copy)
@@ -676,7 +676,7 @@ varpool_extra_name_alias (tree alias, tr
 
 #ifndef ASM_OUTPUT_DEF
   /* If aliases aren't supported by the assembler, fail.  */
-  return false;
+  return NULL;
 #endif
 
   gcc_assert (TREE_CODE (decl) == VAR_DECL);

----- End forwarded message -----

Re: [PATCH][PING][Revised] fix --enable-build-with-cxx on darwin]

[Mike Stump]

On Jun 3, 2011, at 9:25 AM, Jack Howarth wrote:
>   Could someone commit this patch, which was already approved in

Done.