Unreviewed testsuite, C, i386 patches

Unreviewed testsuite, C, i386 patches

[Rainer Orth]

The following patches have remained unreviewed for a week:

	[testsuite] Skip several UCN tests on systems without ASCII locale (PR testsuite/47400)
        http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02305.html

This one requires a testsuite and/or C maintainer.

	[testsuite, 4.4/4.5] Backport dg-require-effective-target avx_runtime
	http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02298.html

This one requires a i386 maintainer.

The next patch has remained unreviewed for 3 weeks:

	[ada, testsuite] gnat.dg cleanup
        http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01129.html

It seems to be blocked since we have no testsuite maintainer and nobody
else cares ;-(

Thanks.
	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed testsuite, C, i386 patches

[Uros Bizjak]

On Mon, Feb 7, 2011 at 12:51 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> The following patches have remained unreviewed for a week:

>        [testsuite, 4.4/4.5] Backport dg-require-effective-target avx_runtime
>        http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02298.html

This is OK.

Thanks,
Uros.

Re: Unreviewed testsuite, C, i386 patches

[Joseph S. Myers]

On Mon, 7 Feb 2011, Rainer Orth wrote:

> The following patches have remained unreviewed for a week:
> 
> 	[testsuite] Skip several UCN tests on systems without ASCII locale (PR testsuite/47400)
>         http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02305.html
> 
> This one requires a testsuite and/or C maintainer.

The approach seems fine from a C perspective, though you probably want a 
testsuite person to review the .exp changes.

-- 
Joseph S. Myers
joseph@codesourcery.com

Re: Unreviewed testsuite, C, i386 patches

[Rainer Orth]

"Joseph S. Myers" <joseph@codesourcery.com> writes:

> On Mon, 7 Feb 2011, Rainer Orth wrote:
>
>> The following patches have remained unreviewed for a week:
>> 
>> 	[testsuite] Skip several UCN tests on systems without ASCII locale (PR testsuite/47400)
>>         http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02305.html
>> 
>> This one requires a testsuite and/or C maintainer.
>
> The approach seems fine from a C perspective, though you probably want a 
> testsuite person to review the .exp changes.

Same problem as usual: there is none ;-(

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed testsuite, C, i386 patches

[Mike Stump]

On Feb 7, 2011, at 3:51 AM, Rainer Orth wrote:
> The next patch has remained unreviewed for 3 weeks:
> 
> 	[ada, testsuite] gnat.dg cleanup
>        http://gcc.gnu.org/ml/gcc-patches/2011-01/msg01129.html
> 
> It seems to be blocked since we have no testsuite maintainer and nobody
> else cares ;-(

Let me correct that, no one that has been approved to approve the patch cares...  :-)

Re: Unreviewed testsuite, C, i386 patches

[Richard Guenther]

On Mon, 7 Feb 2011, Rainer Orth wrote:

> "Joseph S. Myers" <joseph@codesourcery.com> writes:
> 
> > On Mon, 7 Feb 2011, Rainer Orth wrote:
> >
> >> The following patches have remained unreviewed for a week:
> >> 
> >> 	[testsuite] Skip several UCN tests on systems without ASCII locale (PR testsuite/47400)
> >>         http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02305.html
> >> 
> >> This one requires a testsuite and/or C maintainer.
> >
> > The approach seems fine from a C perspective, though you probably want a 
> > testsuite person to review the .exp changes.
> 
> Same problem as usual: there is none ;-(

Ok.

With all the recent patches would you volunteer to be a testsuite
maintainer?

Thanks,
Richard.

Re: Unreviewed testsuite, C, i386 patches

[Rainer Orth]

Richard Guenther <rguenther@suse.de> writes:

>> > The approach seems fine from a C perspective, though you probably want a 
>> > testsuite person to review the .exp changes.
>> 
>> Same problem as usual: there is none ;-(
>
> Ok.
>
> With all the recent patches would you volunteer to be a testsuite
> maintainer?

I think I should ;-)  I already suggested it to Gerald in private mail,
but have been uncertain if I'm knowledgeable enough since I'm still
reading up on Tcl and DejaGnu.  On the other hand, if nobody else is
available, I'd give it a try.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Re: Unreviewed testsuite, C, i386 patches

[Arnaud Charlet]

> I think I should ;-)  I already suggested it to Gerald in private mail,
> but have been uncertain if I'm knowledgeable enough since I'm still
> reading up on Tcl and DejaGnu.  On the other hand, if nobody else is
> available, I'd give it a try.

I think that would be a good idea, since we clearly are missing reviewers
in this area, and have patches that are left unreviewed, which is too bad.

Arno