From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11723 invoked by alias); 8 Jun 2011 01:25:47 -0000 Received: (qmail 11711 invoked by uid 22791); 8 Jun 2011 01:25:47 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RFC_ABUSE_POST,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta06.emeryville.ca.mail.comcast.net (HELO qmta06.emeryville.ca.mail.comcast.net) (76.96.30.56) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 08 Jun 2011 01:25:31 +0000 Received: from omta15.emeryville.ca.mail.comcast.net ([76.96.30.71]) by qmta06.emeryville.ca.mail.comcast.net with comcast id tCq31g0061Y3wxoA6DRWt9; Wed, 08 Jun 2011 01:25:30 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta15.emeryville.ca.mail.comcast.net with comcast id tDRJ1g00X0BKwT48bDRJiH; Wed, 08 Jun 2011 01:25:19 +0000 Subject: Re: [testsuite] skip ARM tests with conflicting options Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Mike Stump In-Reply-To: <4DEEB332.2070706@codesourcery.com> Date: Wed, 08 Jun 2011 02:03:00 -0000 Cc: "Joseph S. Myers" , gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <4DEE8FE7.50001@codesourcery.com> <4DEEB332.2070706@codesourcery.com> To: Janis Johnson X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00601.txt.bz2 On Jun 7, 2011, at 4:24 PM, Janis Johnson wrote: > On 06/07/2011 02:07 PM, Joseph S. Myers wrote: >> On Tue, 7 Jun 2011, Janis Johnson wrote: >>=20 >>> Several tests in gcc.target/arm use dg-options with -mcpu=3Dxxxx, which >>> causes compiler warnings or errors when the multilib flags include >>> -march=3Dyyyy. This patch causes those tests to be skipped. It also >>> prevents gcc.target/arm/20090811-1.c from running with multilibs that >>> would override -mcpu or -mfloat-abi options specified for the test. >>=20 >> I think you should allow compatible -march options - for example, if=20 >> dg-options has -mcpu=3Dcortex-a8, allow -march=3Darmv7-a but disallow al= l=20 >> other -march options. >>=20 > Is this one OK? Not sure if the arm people want to review this or would rather I review it.= .. Let's give the arm folks a couple days to comment, if no objections, Ok. A point of warning, eventually, you'll discover that when a compiler defaul= ts to the argument you want to skip, that you'll needs slightly more power = to skip them. darwin ran into this with things like -m64, and eventually h= ad to do something like lp64. configure options like --with-cpu=3Darm9 are= the sort that can change the default.