From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25201 invoked by alias); 13 Apr 2011 10:43:54 -0000 Received: (qmail 25191 invoked by uid 22791); 13 Apr 2011 10:43:53 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-qy0-f182.google.com (HELO mail-qy0-f182.google.com) (209.85.216.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 10:43:44 +0000 Received: by qyk27 with SMTP id 27so310046qyk.20 for ; Wed, 13 Apr 2011 03:43:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.201.28 with SMTP id ey28mr201688qcb.108.1302691423120; Wed, 13 Apr 2011 03:43:43 -0700 (PDT) Received: by 10.229.67.96 with HTTP; Wed, 13 Apr 2011 03:43:43 -0700 (PDT) In-Reply-To: <201104131136.48795.pedro@codesourcery.com> References: <4DA4900C.3020303@redhat.com> <201104131136.48795.pedro@codesourcery.com> Date: Wed, 13 Apr 2011 10:43:00 -0000 Message-ID: Subject: Re: [patch i386 mingw g++.dg gcc.dg]: Set -mms-bitfields as default for native windows targets From: Kai Tietz To: Pedro Alves Cc: gcc-patches@gcc.gnu.org, Richard Henderson Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00972.txt.bz2 2011/4/13 Pedro Alves : > On Tuesday 12 April 2011 19:53:42, Kai Tietz wrote: >> 2011/4/12 Richard Henderson : >> > On 04/12/2011 05:47 AM, Kai Tietz wrote: >> >> ChangeLog gcc/ >> >> >> >> =A0 =A0 =A0 * config/i386/mingw32.h (TARGET_SUBTARGET_DEFAULT): Add >> >> =A0 =A0 =A0 MASK_MS_BITFIELD_LAYOUT bit. >> >> >> >> ChangeLog gcc/testsuite >> >> >> >> =A0 =A0 =A0 * g++.dg/ext/bitfield2.C: Add for i?86/x86_64-*-mingw* >> >> =A0 =A0 =A0 targets the additional -mno-ms-bitfields and >> >> =A0 =A0 =A0 -Wno-packed-bitfield-compat options. >> >> =A0 =A0 =A0 * g++.dg/ext/bitfield3.C: Likewise. >> >> =A0 =A0 =A0 * g++.dg/ext/bitfield4.C: Likewise. >> >> =A0 =A0 =A0 * g++.dg/ext/bitfield5.C: Likewise. >> >> =A0 =A0 =A0 * gcc.dg/bitfld-15.c: Likewise. >> >> =A0 =A0 =A0 * gcc.dg/bitfld-16.c: Likewise. >> >> =A0 =A0 =A0 * gcc.dg/bitfld-17.c: Likewise. >> >> =A0 =A0 =A0 * gcc.dg/bitfld-18.c: Likewise. >> > >> > Ok. >> > >> > >> > r~ >> > >> >> >> Applied at revision 172336. >> >> Thanks, >> Kai >> > > This is a default ABI change (IIRC, when the option was > introduced, it was left off as default so to not break the ABI). > > Shouldn't we advertise it somewhere? > > -- > Pedro Alves > Yes, I did recently a lot of abi changing for mingw's targets. They all will need a nice description (and possible ways to get old default behavior) in changes.html I collect them for later. Or do you mean it should be noted earlier? Regards, Kai