From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8579 invoked by alias); 19 May 2011 16:52:29 -0000 Received: (qmail 8570 invoked by uid 22791); 19 May 2011 16:52:27 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,TW_ZJ X-Spam-Check-By: sourceware.org Received: from mail-pz0-f47.google.com (HELO mail-pz0-f47.google.com) (209.85.210.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 19 May 2011 16:52:05 +0000 Received: by pzk36 with SMTP id 36so1393209pzk.20 for ; Thu, 19 May 2011 09:52:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.68.243 with SMTP id z19mr5036032pbt.276.1305823923976; Thu, 19 May 2011 09:52:03 -0700 (PDT) Received: by 10.68.41.4 with HTTP; Thu, 19 May 2011 09:52:03 -0700 (PDT) In-Reply-To: References: Date: Thu, 19 May 2011 18:25:00 -0000 Message-ID: Subject: Re: [PATCH] fix vfmsubaddpd/vfmaddsubpd generation From: Quentin Neill To: Uros Bizjak , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01401.txt.bz2 On Wed, May 18, 2011 at 10:32 AM, Uros Bizjak wrote: > Hello! > >> This patch fixes an obvious problem: the fma4_fmsubadd/fma4_fmaddsub >> instruction templates don't generate vfmsubaddpd/vfmaddsubpd because >> they don't use >> >> This passes bootstrap on x86_64 on trunk. =A0Okay to commit? > > See comments in the code. > >> BTW, I'm testing on gcc-4_6-branch. =A0Should I post a different patch >> thread, or just use this one? > > No, the patch is clear and simple enough, you don't need to post it twice. > > diff --git a/gcc/ChangeLog b/gcc/ChangeLog > index 3625d9b..e86ea4e 100644 > --- a/gcc/ChangeLog > +++ b/gcc/ChangeLog > @@ -1,3 +1,8 @@ > +2011-05-17 =A0Harsha Jagasia =A0 > + > + =A0 =A0 =A0 * config/i386/sse.md (fma4_fmsubadd): Use . > + =A0 =A0 =A0 (fma4_fmaddsub): Likewise > + > =A02011-05-17 =A0Richard Guenther =A0 > > ChangeLog should be included in the message body, not in the patch. > Please see [1] for details. > > =A0 =A0 =A0 =A0* gimple.c (iterative_hash_gimple_type): Simplify singleton > diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md > index 291bffb..7c4e6dd 100644 > --- a/gcc/config/i386/sse.md > +++ b/gcc/config/i386/sse.md > @@ -1663,7 +1663,7 @@ > =A0 =A0 =A0 =A0 =A0 (match_operand:VF 3 "nonimmediate_operand" "xm,x")] > =A0 =A0 =A0 =A0 =A0UNSPEC_FMADDSUB))] > =A0 "TARGET_FMA4" > - =A0"vfmaddsubps\t{%3, %2, %1, %0|%0, %1, %2, %3}" > + =A0"vfmaddsubp\t{%3, %2, %1, %0|%0, %1, %2, %3}" > =A0 [(set_attr "type" "ssemuladd") > =A0 =A0(set_attr "mode" "")]) > > No, mode attribute resolves to ps and pd for VF mode > iterator, so "vfmaddsub". > > @@ -1676,7 +1676,7 @@ > =A0 =A0 =A0 =A0 =A0 =A0 (match_operand:VF 3 "nonimmediate_operand" "xm,x"= ))] > =A0 =A0 =A0 =A0 =A0UNSPEC_FMADDSUB))] > =A0 "TARGET_FMA4" > - =A0"vfmsubaddps\t{%3, %2, %1, %0|%0, %1, %2, %3}" > + =A0"vfmsubaddp\t{%3, %2, %1, %0|%0, %1, %2, %3}" > =A0 [(set_attr "type" "ssemuladd") > =A0 =A0(set_attr "mode" "")]) > > Same here. > > OK everywhere with these two changes. > > [1] http://gcc.gnu.org/contribute.html. > > Thanks, > Uros. Uros, Thanks for the feedback and gentle reminder. I will apply your changes, retesting on both branches, and then commit. --=20 Quentin