From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29887 invoked by alias); 10 Jun 2011 15:47:52 -0000 Received: (qmail 29873 invoked by uid 22791); 10 Jun 2011 15:47:51 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,TW_CX,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 10 Jun 2011 15:47:37 +0000 Received: from hpaq2.eem.corp.google.com (hpaq2.eem.corp.google.com [172.25.149.2]) by smtp-out.google.com with ESMTP id p5AFlZEG008401 for ; Fri, 10 Jun 2011 08:47:35 -0700 Received: from gxk22 (gxk22.prod.google.com [10.202.11.22]) by hpaq2.eem.corp.google.com with ESMTP id p5AFkq7A008003 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Fri, 10 Jun 2011 08:47:34 -0700 Received: by gxk22 with SMTP id 22so2458855gxk.2 for ; Fri, 10 Jun 2011 08:47:34 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.160.4 with SMTP id i4mr2874664ybe.241.1307720854086; Fri, 10 Jun 2011 08:47:34 -0700 (PDT) Received: by 10.151.142.15 with HTTP; Fri, 10 Jun 2011 08:47:34 -0700 (PDT) In-Reply-To: <20110609184955.794601DA1CD@topo.tor.corp.google.com> References: <20110609184955.794601DA1CD@topo.tor.corp.google.com> Date: Fri, 10 Jun 2011 15:53:00 -0000 Message-ID: Subject: Re: [pph] Do not emit PCH if generating PPH (issue4591061) From: Diego Novillo To: reply@codereview.appspotmail.com, Gabriel Charette , Lawrence Crowl , gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary=000e0cd7627cf9252f04a55d7c37 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00853.txt.bz2 --000e0cd7627cf9252f04a55d7c37 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 993 On Thu, Jun 9, 2011 at 11:49, Diego Novillo wrote: > > We were trying to generate PCH and PPH information at the same time. > We never noticed because PPH is generated after PCH, so we were just > clobbering over the previous dump. > > Found it by accident while debugging a GC ICE. =C2=A0This should make > testing slightly faster. > > Committed to the branch. This version had problems and it was still abusing the PCH options from specs. The problem is that when compiling header files separately, the compiler assumes that we want to generate PCH files. In the long term, I think we will want to replace PCH with PPH, but until then I'm adding a new flag -fpph-gen to distinguish the PCH from the PPH generation. So, when compiling a header file, if you want a PPH image, you need to: $ gcc -fpph-gen foo.h This generate foo.pph instead of foo.gch. The new patch also adds documentation on the three user-facing flags used for pph. Tested on x86_64. Diego. --000e0cd7627cf9252f04a55d7c37 Content-Type: text/plain; charset=US-ASCII; name="issue4591061_3001.diff.txt" Content-Disposition: attachment; filename="issue4591061_3001.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gorb87k21 Content-length: 8101 SW5kZXg6IGdjYy9jLWZhbWlseS9jLW9wdHMuYwpkaWZmIC0tZ2l0IGEvZ2Nj L2MtZmFtaWx5L2Mtb3B0cy5jIGIvZ2NjL2MtZmFtaWx5L2Mtb3B0cy5jCmlu ZGV4IGU1MjU4M2UuLjhmZTU2NmUgMTAwNjQ0Ci0tLSBhL2djYy9jLWZhbWls eS9jLW9wdHMuYworKysgYi9nY2MvYy1mYW1pbHkvYy1vcHRzLmMKQEAgLTM2 OCwxMyArMzY4LDExIEBAIGNfY29tbW9uX2hhbmRsZV9vcHRpb24gKHNpemVf dCBzY29kZSwgY29uc3QgY2hhciAqYXJnLCBpbnQgdmFsdWUsCiAgICAgICBi cmVhazsKIAogICAgIGNhc2UgT1BUX19vdXRwdXRfcGNoXzoKLSAgICAgIHsK LSAgICAgICAgY2hhciAqZG90ID0gc3RycmNociAoYXJnLCAnLicpOwotICAg ICAgICBpZiAoZG90ICE9IE5VTEwgJiYgc3RyY21wIChkb3QsICIucHBoIikg PT0gMCkKLSAgICAgICAgICBwcGhfb3V0X2ZpbGUgPSBhcmc7Ci0gICAgICAg IGVsc2UKLSAgICAgICAgICBwY2hfZmlsZSA9IGFyZzsKLSAgICAgIH0KKyAg ICAgIHBjaF9maWxlID0gYXJnOworICAgICAgYnJlYWs7CisKKyAgICBjYXNl IE9QVF9fb3V0cHV0X3BwaF86CisgICAgICBwcGhfb3V0X2ZpbGUgPSBhcmc7 CiAgICAgICBicmVhazsKIAogICAgIGNhc2UgT1BUX0E6CkluZGV4OiBnY2Mv Yy1mYW1pbHkvYy5vcHQKZGlmZiAtLWdpdCBhL2djYy9jLWZhbWlseS9jLm9w dCBiL2djYy9jLWZhbWlseS9jLm9wdAppbmRleCA2NzcwOGI4Li5iZGMwZmM5 IDEwMDY0NAotLS0gYS9nY2MvYy1mYW1pbHkvYy5vcHQKKysrIGIvZ2NjL2Mt ZmFtaWx5L2Mub3B0CkBAIC0xMzksNiArMTM5LDkgQEAgQyBPYmpDIEMrKyBP YmpDKysgSm9pbmVkIEFsaWFzKG8pCiAtb3V0cHV0LXBjaD0KIEMgT2JqQyBD KysgT2JqQysrIEpvaW5lZCBTZXBhcmF0ZQogCistb3V0cHV0LXBwaD0KK0Mr KyBKb2luZWQgU2VwYXJhdGUKKwogLXBlZGFudGljCiBDIE9iakMgQysrIE9i akMrKyBBbGlhcyhwZWRhbnRpYykKIApAQCAtOTMzLDggKzkzNiwxMiBAQCBm cHBoLWR1bXAtdHJlZQogQysrIFZhcihmbGFnX3BwaF9kdW1wX3RyZWUpCiAt ZnBwaC1kdW1wLXRyZWUJRHVtcCBnbG9iYWwgbmFtZXNwYWNlIHRyZWUgYXJv dW5kIFBQSCByZWFkcy93cml0ZXMuCiAKK2ZwcGgtZ2VuCitDKysKKy1mcHBo LWdlbglHZW5lcmF0ZSBhIFBQSCBpbWFnZSBmcm9tIHRoZSBpbnB1dCBmaWxl CisKIGZwcGgtaGRyPQotQysrIE9iakMrKyBKb2luZWQgTWlzc2luZ0FyZ0Vy cm9yKG1pc3NpbmcgZmlsZW5hbWUgYWZ0ZXIgJXFzKQorQysrIEpvaW5lZCBN aXNzaW5nQXJnRXJyb3IobWlzc2luZyBmaWxlbmFtZSBhZnRlciAlcXMpCiAt ZnBwaC1oZHI9PGJhc2UtbmFtZT4gICBBIG1hcHBpbmcgZnJvbSA8YmFzZS1u YW1lPi5oIHRvIDxiYXNlLW5hbWU+LnBwaAogCiBmcHBoLWxvZ2ZpbGU9CkBA IC05NDIsNyArOTQ5LDcgQEAgQysrIEpvaW5lZCBSZWplY3ROZWdhdGl2ZSBW YXIoZmxhZ19wcGhfbG9nZmlsZSkKIC1mcHBoLWxvZ2ZpbGU9PGZpbGUtbmFt ZT4JRW1pdCBQUEggZGVidWcgaW5mb3JtYXRpb24gdG8gPGZpbGUtbmFtZT4K IAogZnBwaC1tYXA9Ci1DKysgT2JqQysrIEpvaW5lZCBNaXNzaW5nQXJnRXJy b3IobWlzc2luZyBmaWxlbmFtZSBhZnRlciAlcXMpCitDKysgSm9pbmVkIE1p c3NpbmdBcmdFcnJvcihtaXNzaW5nIGZpbGVuYW1lIGFmdGVyICVxcykKIC1m cHBoLW1hcD08ZmlsZS1uYW1lPiAgIEEgZmlsZSBvZiBtYXBwaW5ncyBmcm9t ICNpbmNsdWRlIHRvIFBQSCBmaWxlCiAKIGZwcGgtdHJhY2VyPQpJbmRleDog Z2NjL2NwL2xhbmctc3BlY3MuaApkaWZmIC0tZ2l0IGEvZ2NjL2NwL2xhbmct c3BlY3MuaCBiL2djYy9jcC9sYW5nLXNwZWNzLmgKaW5kZXggYTczYWJhMy4u ZWYwM2EzOSAxMDA2NDQKLS0tIGEvZ2NjL2NwL2xhbmctc3BlY3MuaAorKysg Yi9nY2MvY3AvbGFuZy1zcGVjcy5oCkBAIC00OCw4ICs0OCw5IEBAIGFsb25n IHdpdGggR0NDOyBzZWUgdGhlIGZpbGUgQ09QWUlORzMuICBJZiBub3Qgc2Vl CiAgICAgICBjYzFwbHVzICV7c2F2ZS10ZW1wcyp8bm8taW50ZWdyYXRlZC1j cHA6LWZwcmVwcm9jZXNzZWQgJXtzYXZlLXRlbXBzKjolYi5paX0gJXshc2F2 ZS10ZW1wcyo6JWcuaWl9fVwKIAkgICAgICAleyFzYXZlLXRlbXBzKjoleyFu by1pbnRlZ3JhdGVkLWNwcDolKGNwcF91bmlxdWVfb3B0aW9ucyl9fVwKIAkl KGNjMV9vcHRpb25zKSAlMlwKLQkleyFmc3ludGF4LW9ubHk6JXshZmR1bXAt YWRhLXNwZWMqOi1vICVnLnMgJXshbyo6LS1vdXRwdXQtcGNoPSVpLmdjaH1c Ci0gICAgICAgICVXe28qOi0tb3V0cHV0LXBjaD0lKn19JVZ9fX19IiwKKwkl eyFmcHBoLWdlbjoleyFmc3ludGF4LW9ubHk6JXshZmR1bXAtYWRhLXNwZWMq Oi1vICVnLnMgJXshbyo6LS1vdXRwdXQtcGNoPSVpLmdjaH1cCisJJVd7byo6 LS1vdXRwdXQtcGNoPSUqfX19fSBcCisJJXtmcHBoLWdlbjoleyFvKjotLW91 dHB1dC1wcGg9JWIucHBofSVXe28qOi0tb3V0cHV0LXBwaD0lKn19JVZ9fX0i LAogICAgICBDUExVU1BMVVNfQ1BQX1NQRUMsIDAsIDB9LAogICB7IkBjKysi LAogICAgICIle0V8TXxNTTpjYzFwbHVzIC1FICUoY3BwX29wdGlvbnMpICUy ICUoY3BwX2RlYnVnX29wdGlvbnMpfVwKSW5kZXg6IGdjYy9kb2MvaW52b2tl LnRleGkKZGlmZiAtLWdpdCBhL2djYy9kb2MvaW52b2tlLnRleGkgYi9nY2Mv ZG9jL2ludm9rZS50ZXhpCmluZGV4IDYyMDc4MDAuLjUyNDQ3MWEgMTAwNjQ0 Ci0tLSBhL2djYy9kb2MvaW52b2tlLnRleGkKKysrIGIvZ2NjL2RvYy9pbnZv a2UudGV4aQpAQCAtMTk1LDYgKzE5NSw3IEBAIGluIHRoZSBmb2xsb3dpbmcg c2VjdGlvbnMuCiAtZm5vLXRocmVhZHNhZmUtc3RhdGljcyAtZnVzZS1jeGEt YXRleGl0ICAtZm5vLXdlYWsgIC1ub3N0ZGluYysrIEBnb2wKIC1mbm8tZGVm YXVsdC1pbmxpbmUgIC1mdmlzaWJpbGl0eS1pbmxpbmVzLWhpZGRlbiBAZ29s CiAtZnZpc2liaWxpdHktbXMtY29tcGF0IEBnb2wKKy1mcHBoLWhkciAtZnBw aC1tYXAgLWZwcGgtZ2VuIEBnb2wKIC1XYWJpICAtV2NvbnZlcnNpb24tbnVs bCAgLVdjdG9yLWR0b3ItcHJpdmFjeSBAZ29sCiAtV25vZXhjZXB0IC1Xbm9u LXZpcnR1YWwtZHRvciAgLVdyZW9yZGVyIEBnb2wKIC1XZWZmYysrICAtV3N0 cmljdC1udWxsLXNlbnRpbmVsIEBnb2wKQEAgLTIxNzEsNiArMjE3Miw0MiBA QCBvcHRpb24gZXhpc3RzIG9ubHkgZm9yIHRlc3RpbmcsIGFuZCBzaG91bGQg bm90IGJlIHVzZWQgYnkgZW5kLXVzZXJzOwogaXQgd2lsbCByZXN1bHQgaW4g aW5mZXJpb3IgY29kZSBhbmQgaGFzIG5vIGJlbmVmaXRzLiAgVGhpcyBvcHRp b24gbWF5CiBiZSByZW1vdmVkIGluIGEgZnV0dXJlIHJlbGVhc2Ugb2YgRysr LgogCitAaXRlbSAtZnBwaC1nZW4KK0BvcGluZGV4IGZwcGgtZ2VuCitHZW5l cmF0ZSBhIFByZS1QYXJzZWQgSGVhZGVyIChQUEgpIGZpbGUgaW5zdGVhZCBv ZiBhIFBDSCBmaWxlLiAgVGhpcyBvcHRpb24KK2lzIG9ubHkgdmFsaWQgd2hl biBjb21waWxpbmcgaGVhZGVyIGZpbGVzIHNlcGFyYXRlbHkuICBJbnN0ZWFk IG9mIGdlbmVyYXRpbmcKK2EgUENIIGZpbGVzLCBHKysgd2lsbCBzYXZlIHRo ZSBwYXJzZWQgZGVjbGFyYXRpb25zIGluIGEgaGVhZGVyIGZpbGUgdG8KK2Eg UFBIIGZpbGUuICBCeSBkZWZhdWx0LCB0aGUgUFBIIGltYWdlIGZvciBhIGhl YWRlciBmaWxlIG5hbWVkIEBmaWxle2Zvby5ofQoraXMgQGZpbGV7Zm9vLnBw aH0uCisKK05PVEU6IFRoaXMgb3B0aW9uIGlzIHRlbXBvcmFyeS4gIEl0IGlz IG9ubHkgbWVhbnQgdG8gc2VydmUgdGhlIGluaXRpYWwKK2ltcGxlbWVudGF0 aW9uIG9mIHRoaXMgZmVhdHVyZS4gIFRoZSBmaW5hbCB1c2VyIGludGVyZmFj ZSB3aWxsIGxpa2VseQordXNlIGEgZGlmZmVyZW50IG1lY2hhbmlzbSBmb3Ig UFBILgorCitAaXRlbSAtZnBwaC1tYXA9QHZhcntmaWxlLm1hcH0KK0BvcGlu ZGV4IGZwcGgtbWFwCitVc2UgUFBIIG1hcHBpbmcgZmlsZSBAZmlsZXtmaWxl Lm1hcH0gdG8gZGV0ZXJtaW5lIHdoYXQgaGVhZGVycyBzaG91bGQgYmUKK3By b2Nlc3NlZCBmcm9tIHRoZWlyIFBQSCBpbWFnZXMuICBUaGlzIGZpbGUgY29u dGFpbnMgYSBsaXN0IG9mIGZpbGUgbmFtZQorcGFpcnMgaW4gdGhlIGZvcm0g YGBAdmFye2ZpbGUuaH0gQHZhcntmaWxlLnBwaH0nJy4gIFdoZW4gdGhlIHBy ZS1wcm9jZXNzb3IKK2ZpbmRzIHRoZSBkaXJlY3RpdmUgQGNvZGV7I2luY2x1 ZGUgImZpbGUuaCJ9LCBhbmQgdGhlcmUgZXhpc3RzIGEgbWFwcGluZworYmV0 d2VlbiBAdmFye2ZpbGUuaH0gYW5kIEB2YXJ7ZmlsZS5wcGh9IGluIEBmaWxl e2ZpbGUubWFwfSwgdGhlbiB0aGUKK2NvbXBpbGVyIHdpbGwgaW5zdGFudGlh dGUgdGhlIFBQSCBpbWFnZSBAdmFye2ZpbGUucHBofS4gIFRoZSB0ZXh0Citp biBAdmFye2ZpbGUuaH0gd2lsbCBiZSBpZ25vcmVkLgorCitOT1RFOiBUaGlz IG9wdGlvbiBpcyB0ZW1wb3JhcnkuICBJdCBpcyBvbmx5IG1lYW50IHRvIHNl cnZlIHRoZSBpbml0aWFsCitpbXBsZW1lbnRhdGlvbiBvZiB0aGlzIGZlYXR1 cmUuICBUaGUgZmluYWwgdXNlciBpbnRlcmZhY2Ugd2lsbCBsaWtlbHkKK3Vz ZSBhIGRpZmZlcmVudCBtZWNoYW5pc20gZm9yIFBQSC4KKworQGl0ZW0gLWZw cGgtaGRyPUB2YXJ7ZmlsZS5ofQorQG9waW5kZXggZnBwaC1oZHIKK1RoaXMg aXMgYSBzaG9ydC1oYW5kIG5vdGF0aW9uIHRvIG1hcCBhIHNpbmdsZSBoZWFk ZXIgQGZpbGV7ZmlsZS5ofSB0bworaXRzIGltYWdlIEBmaWxle2ZpbGUucHBo fS4gIE11bHRpcGxlIG9jY3VycmVuY2VzIG9mIHRoaXMgZmxhZyB3aWxsCitp bnRyb2R1Y2UgbXVsdGlwbGUgbWFwcGluZ3MuCisKK05PVEU6IFRoaXMgb3B0 aW9uIGlzIHRlbXBvcmFyeS4gIEl0IGlzIG9ubHkgbWVhbnQgdG8gc2VydmUg dGhlIGluaXRpYWwKK2ltcGxlbWVudGF0aW9uIG9mIHRoaXMgZmVhdHVyZS4g IFRoZSBmaW5hbCB1c2VyIGludGVyZmFjZSB3aWxsIGxpa2VseQordXNlIGEg ZGlmZmVyZW50IG1lY2hhbmlzbSBmb3IgUFBILgorCiBAaXRlbSAtbm9zdGRp bmMrKwogQG9waW5kZXggbm9zdGRpbmMrKwogRG8gbm90IHNlYXJjaCBmb3Ig aGVhZGVyIGZpbGVzIGluIHRoZSBzdGFuZGFyZCBkaXJlY3RvcmllcyBzcGVj aWZpYyB0bwpJbmRleDogZ2NjL3Rlc3RzdWl0ZS9saWIvZGctcHBoLmV4cApk aWZmIC0tZ2l0IGEvZ2NjL3Rlc3RzdWl0ZS9saWIvZGctcHBoLmV4cCBiL2dj Yy90ZXN0c3VpdGUvbGliL2RnLXBwaC5leHAKaW5kZXggMjA1ODk1OS4uYzc3 M2FhMCAxMDA2NDQKLS0tIGEvZ2NjL3Rlc3RzdWl0ZS9saWIvZGctcHBoLmV4 cAorKysgYi9nY2MvdGVzdHN1aXRlL2xpYi9kZy1wcGguZXhwCkBAIC0zMyw3 ICszMyw3IEBAIHByb2MgZGctcHBoLWhkciB7IHN1YmRpciB0ZXN0IG9wdGlv bnMgbWFwZmxhZyBzdWZmaXggfSB7CiAgICAgdmVyYm9zZSAtbG9nICJcblRl c3RpbmcgJG5zaG9ydCwgJG9wdGlvbnMiCiAKICAgICBzZXQgZGctZG8td2hh dC1kZWZhdWx0IHByZXBhcnNlCi0gICAgZGctdGVzdCAta2VlcC1vdXRwdXQg JHRlc3QgIiRvcHRpb25zICRtYXBmbGFnIC1JLiIgIiIKKyAgICBkZy10ZXN0 IC1rZWVwLW91dHB1dCAkdGVzdCAiLWZwcGgtZ2VuICRvcHRpb25zICRtYXBm bGFnIC1JLiIgIiIKIAogfQogCkBAIC01MSw3ICs1MSw3IEBAIHByb2MgZGct cHBoLW5lZyB7IHN1YmRpciB0ZXN0IG9wdGlvbnMgbWFwZmxhZyBzdWZmaXgg fSB7CiAgICAgdmVyYm9zZSAtbG9nICJcblRlc3RpbmcgJG5zaG9ydCwgJG9w dGlvbnMiCiAKICAgICBzZXQgZGctZG8td2hhdC1kZWZhdWx0IGNvbXBpbGUK LSAgICBkZy10ZXN0IC1rZWVwLW91dHB1dCAkdGVzdCAiJG9wdGlvbnMgJG1h cGZsYWcgLUkuIiAiIgorICAgIGRnLXRlc3QgLWtlZXAtb3V0cHV0ICR0ZXN0 ICItZnBwaC1nZW4gJG9wdGlvbnMgJG1hcGZsYWcgLUkuIiAiIgogICAgIGlm IHsgIVtmaWxlX29uX2hvc3QgZXhpc3RzICIkYm5hbWUucyJdIH0gewogCWZp bGVfb25faG9zdCBkZWxldGUgIiRibmFtZS5zIgogICAgIH0K --000e0cd7627cf9252f04a55d7c37--