From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23843 invoked by alias); 6 Jun 2011 15:33:30 -0000 Received: (qmail 23830 invoked by uid 22791); 6 Jun 2011 15:33:29 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 06 Jun 2011 15:33:09 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id p56FX7IY030294 for ; Mon, 6 Jun 2011 08:33:07 -0700 Received: from yic24 (yic24.prod.google.com [10.243.65.152]) by wpaz33.hot.corp.google.com with ESMTP id p56FWg9o017139 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Mon, 6 Jun 2011 08:33:06 -0700 Received: by yic24 with SMTP id 24so1174642yic.38 for ; Mon, 06 Jun 2011 08:33:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.230.12 with SMTP id c12mr4442367ybh.13.1307374385794; Mon, 06 Jun 2011 08:33:05 -0700 (PDT) Received: by 10.151.41.13 with HTTP; Mon, 6 Jun 2011 08:33:05 -0700 (PDT) In-Reply-To: References: <20110601001232.CCD681DA1C9@topo.tor.corp.google.com> Date: Mon, 06 Jun 2011 15:33:00 -0000 Message-ID: Subject: Re: [lto] Merge streamer hooks from pph branch. (issue4568043) From: Diego Novillo To: Richard Guenther Cc: reply@codereview.appspotmail.com, Jan Hubicka , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00419.txt.bz2 On Mon, Jun 6, 2011 at 10:50, Richard Guenther wrote: > Do you remember if it was only void_zero_node that causes problems? > We could just special-case it in > lto_input_integer_cst/lto_output_integer_cst. =C2=A0Or even fix the C fam= ily > frontends to not create or use this strange node. =C2=A0It seems to be > a special tree for "empty valid something" which could as well be > a new tree code with a singleton object. void_zero_node was the only one causing problems because it couldn't be built with build_int_cst_wide. However, the other well-known constants where causing problem when the parser tried to pointer-compare them. This sounded a bit strange to me, since I was expecting the constant cache in the type to give back shared constants, but I did not investigate it further. Making void_zero_node a new singleton object sounds like a good cleanup. Diego.