From: Cary Coutant <ccoutant@google.com>
To: Diego Novillo <dnovillo@google.com>
Cc: reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [google][patch] Track discriminators by instruction instead of by basic block (issue4441075)
Date: Sat, 30 Apr 2011 02:10:00 -0000 [thread overview]
Message-ID: <BANLkTi=CKu6vsEveXbf+M0P-yML+G4Mo+g@mail.gmail.com> (raw)
In-Reply-To: <BANLkTin48c75BUWTg4XfvLiqm+FOT73g_Q@mail.gmail.com>
>> 2011-04-28 Cary Coutant <ccoutant@google.com>
>>
>> * basic-block.h (struct basic_block_def): Remove discriminator field.
>> * cfghooks.c (split_block): Remove discriminator field.
>> * cfglayout.c (insn_discriminator): New function.
>> * final.c (discriminator): Remove.
>> (override_discriminator): New file-scope variable.
>> (final_start_function): Remove tracking of discriminator by basic
>> block.
>> (final_scan_insn): Track discriminator by instruction.
>> (notice_source_line): Check for discriminator override. Get
>> discriminator from instruction.
>> * gimple-pretty-print.c (dump_gimple_stmt): Print discriminator.
>> (dump_bb_header): Don't print discriminator.
>> * input.c: Include vecprim.h.
>> (discriminator_location_locations): New variable.
>> (discriminator_location_discriminators): New variable.
>> (min_discriminator_location): New variable.
>> (expand_location): Use map_discriminator_location.
>> (location_with_discriminator): New function.
>> (has_discriminator): New function.
>> (map_discriminator_location): New function.
>> (get_discriminator_from_locus): New function.
>> * input.h (location_with_discriminator): New function.
>> (has_discriminator): New function.
>> (map_discriminator_location): New function.
>> (get_discriminator_from_locus): New function.
>> * print-rtl.c (print_rtx): Print discriminator.
>> * rtl.h (insn_discriminator): New function.
>> * tree-cfg.c: Include input.h.
>> (assign_discriminator): Assign discriminators to instructions rather
>> than to the basic block.
>> * tree-pretty-print.c (dump_location): Print discriminator.
>
> OK if testing passes.
Thanks, committed to google/main.
-cary
prev parent reply other threads:[~2011-04-29 23:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 18:34 Cary Coutant
2011-04-28 18:36 ` Diego Novillo
2011-04-28 18:53 ` Cary Coutant
2011-04-30 2:10 ` Cary Coutant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=CKu6vsEveXbf+M0P-yML+G4Mo+g@mail.gmail.com' \
--to=ccoutant@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).