Re: PATCH: Change maybe_eh_return to bool

[Uros Bizjak <ubizjak@gmail.com>]

On Thu, May 12, 2011 at 11:58 PM, H.J. Lu <hjl.tools@gmail.com> wrote:

>> FWIW, the return type of ix86_save_reg (and ix86_hard_regno_mode_ok
>> and perhaps many others...) can also be changed to bool.
>
> This patch changes the return type of ix86_save_reg to bool and return
> value of ix86_hard_regno_mode_ok to bool.
>
> OK for trunk?

> 2011-05-12  H.J. Lu  <hongjiu.lu@intel.com>
>
>        * config/i386/i386.c (ix86_save_reg): Change return type to
>        bool.
>        (ix86_hard_regno_mode_ok): Change return value to bool.
>

OK, but please update the function comments to say "Return TRUE ..."
instead of "Return 1 ..."

Also:

> -      return reload_in_progress || reload_completed;
> +	return true;
> +      return reload_in_progress != 0 || reload_completed != 0;

return !can_create_pseudo_p ();

Thanks,
Uros.