From: Richard Guenther <richard.guenther@gmail.com>
To: Christian Bruel <christian.bruel@st.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Jan Hubicka <hubicka@ucw.cz>
Subject: Re: [PATH] PR/49139 fix always_inline failures diagnostics
Date: Tue, 21 Jun 2011 12:07:00 -0000 [thread overview]
Message-ID: <BANLkTi=DKBL8uBsUF9PnfO64WtyEGGhdnA@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimbOiyRMOgq6Pi9M+PfehDvN3knGg@mail.gmail.com>
On Tue, Jun 21, 2011 at 1:11 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Mon, Jun 20, 2011 at 3:56 PM, Christian Bruel <christian.bruel@st.com> wrote:
>> On 06/20/2011 03:41 PM, Rainer Orth wrote:
>>>
>>> Christian Bruel<christian.bruel@st.com> writes:
>>>
>>>> 2011-06-16 Christian Bruel<christian.bruel@st.com>
>>>>
>>>> PR 49139/43654
>>>
>>> Please use the correct PR number format here:
>>>
>>> PR middle-end/49139
>>> PR middle-end/43654
>>>
>>> Otherwise the check-in notices don't get into the PRs.
>>
>> OK thanks, in fact I was referring to the file gcc.dg/pr43564.c (there was a
>> typo in the number btw). But good indeed to send the notice into the
>> original PR as well.
>
> The code now looks like
>
> if (node->callees)
> {
> /* Redirecting edges might lead to a need for vops to be recomputed. */
> todo |= TODO_update_ssa_only_virtuals;
> todo = optimize_inline_calls (current_function_decl);
> }
>
> I have committed an obvious patch.
Ick - that broke bootstrap. FIxing as follows.
RIchard.
2011-06-21 Richard Guenther <rguenther@suse.de>
* ipa-inline-transform.c (inline_transform): Fix previous
change.
Index: gcc/ipa-inline-transform.c
===================================================================
--- gcc/ipa-inline-transform.c (revision 175253)
+++ gcc/ipa-inline-transform.c (working copy)
@@ -364,13 +364,13 @@ inline_transform (struct cgraph_node *no
timevar_push (TV_INTEGRATION);
if (node->callees)
- {
- todo = optimize_inline_calls (current_function_decl);
- /* Redirecting edges might lead to a need for vops to be recomputed. */
- todo |= TODO_update_ssa_only_virtuals;
- }
+ todo = optimize_inline_calls (current_function_decl);
timevar_pop (TV_INTEGRATION);
+ if (!(todo & TODO_update_ssa_any))
+ /* Redirecting edges might lead to a need for vops to be recomputed. */
+ todo |= TODO_update_ssa_only_virtuals;
+
cfun->always_inline_functions_inlined = true;
cfun->after_inlining = true;
return todo | execute_fixup_cfg ();
next prev parent reply other threads:[~2011-06-21 12:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 9:07 Christian Bruel
2011-05-31 12:25 ` Richard Guenther
2011-05-31 12:28 ` Jakub Jelinek
2011-05-31 17:07 ` Christian Bruel
2011-06-01 10:03 ` Richard Guenther
2011-06-01 13:02 ` Christian Bruel
2011-06-01 13:07 ` Richard Guenther
2011-06-06 8:58 ` Christian Bruel
2011-06-06 9:55 ` Richard Guenther
2011-06-08 8:25 ` Christian Bruel
2011-06-08 9:42 ` Richard Guenther
2011-06-08 11:56 ` Christian Bruel
2011-06-14 11:29 ` Christian Bruel
2011-06-20 13:36 ` Christian Bruel
2011-06-20 13:46 ` Rainer Orth
2011-06-20 13:54 ` Mike Stump
2011-06-20 14:04 ` Christian Bruel
2011-06-21 11:52 ` Richard Guenther
2011-06-21 12:07 ` Richard Guenther [this message]
2011-06-20 13:51 ` Richard Guenther
2011-06-01 14:49 ` Jan Hubicka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=DKBL8uBsUF9PnfO64WtyEGGhdnA@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=christian.bruel@st.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).