From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8523 invoked by alias); 5 Jun 2011 17:25:14 -0000 Received: (qmail 8511 invoked by uid 22791); 5 Jun 2011 17:25:12 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 05 Jun 2011 17:24:56 +0000 Received: from hpaq2.eem.corp.google.com (hpaq2.eem.corp.google.com [172.25.149.2]) by smtp-out.google.com with ESMTP id p55HOs2L028008 for ; Sun, 5 Jun 2011 10:24:54 -0700 Received: from gyb11 (gyb11.prod.google.com [10.243.49.75]) by hpaq2.eem.corp.google.com with ESMTP id p55HOqDT018956 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Sun, 5 Jun 2011 10:24:53 -0700 Received: by gyb11 with SMTP id 11so1485058gyb.29 for ; Sun, 05 Jun 2011 10:24:52 -0700 (PDT) MIME-Version: 1.0 Received: by 10.151.42.9 with SMTP id u9mr3573548ybj.244.1307294692108; Sun, 05 Jun 2011 10:24:52 -0700 (PDT) Received: by 10.151.26.21 with HTTP; Sun, 5 Jun 2011 10:24:52 -0700 (PDT) In-Reply-To: References: Date: Sun, 05 Jun 2011 17:25:00 -0000 Message-ID: Subject: Re: -fdump-passes -fenable-xxx=func_name_list From: Xinliang David Li To: Richard Guenther Cc: GCC Patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-06/txt/msg00330.txt.bz2 Is this patch ok? Thanks, David On Wed, Jun 1, 2011 at 10:24 AM, Xinliang David Li wro= te: > The attached is the split #1 patch that enhances -fenable/disable. > > Ok after testing? > > Thanks, > David > > On Wed, Jun 1, 2011 at 9:16 AM, Xinliang David Li wr= ote: >> On Wed, Jun 1, 2011 at 1:51 AM, Richard Guenther >> wrote: >>> On Wed, Jun 1, 2011 at 1:34 AM, Xinliang David Li = wrote: >>>> The following patch implements the a new option that dumps gcc PASS >>>> configuration. The sample output is attached. =A0There is one >>>> limitation: some placeholder passes that are named with '*xxx' are >>>> note registered thus they are not listed. They are not important as >>>> they can not be turned on/off anyway. >>>> >>>> The patch also enhanced -fenable-xxx and -fdisable-xx to allow a list >>>> of function assembler names to be specified. >>>> >>>> Ok for trunk? >>> >>> Please split the patch. >>> >>> I'm not too happy how you dump the pass configuration. =A0Why not simpl= y, >>> at a _single_ place, walk the pass tree? =A0Instead of doing pieces of = it >>> at pass execution time when it's not already dumped - that really looks >>> gross. >> >> Yes, that was the original plan -- but it has problems >> 1) the dumper needs to know the root pass lists -- which can change >> frequently -- it can be a long term maintanance burden; >> 2) the centralized dumper needs to be done after option processing >> 3) not sure if gate functions have any side effects or have dependencies= on cfun >> >> The proposed solutions IMHO is not that intrusive -- just three hooks >> to do the dumping and tracking indentation. >> >>> >>> The documentation should also link this option to the -fenable/disable >>> options as obviously the pass names in that dump are those to be >>> used for those flags (and not readily available anywhere else). >> >> Ok. >> >>> >>> I also think that it would be way more useful to note in the individual >>> dump files the functions (at the place they would usually appear) that >>> have the pass explicitly enabled/disabled. >> >> Ok -- for ipa passes or tree/rtl passes where all functions are >> explicitly disabled. >> >> Thanks, >> >> David >> >>> >>> Richard. >>> >>>> Thanks, >>>> >>>> David >>>> >>> >> >