From: Richard Guenther <richard.guenther@gmail.com>
To: Diego Novillo <dnovillo@google.com>
Cc: Lawrence Crowl <crowl@google.com>,
reply@codereview.appspotmail.com, jason@redhat.com,
gcc-patches@gcc.gnu.org
Subject: Re: [patch] Split Parse Timevar (issue4378056)
Date: Wed, 13 Apr 2011 09:19:00 -0000 [thread overview]
Message-ID: <BANLkTi=HJtUViEAqaXCwZSa=XFaTxLH+Ww@mail.gmail.com> (raw)
In-Reply-To: <BANLkTimx-kE0Dg59kLTPy5U2XX4N3XMo2A@mail.gmail.com>
On Tue, Apr 12, 2011 at 9:06 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Tue, Apr 12, 2011 at 14:49, Lawrence Crowl <crowl@google.com> wrote:
>> This patch provides more finer, more precise compile time information.
>> I sent an advisory mail some time ago, and it was good then. Please
>> confirm for trunk.
>
> The patch looks fine to me, but of course it's Jason the one you need
> an OK from.
Pushing/popping timevars is not free. What's the compile-time impact of this
change (for -ftime-report, of course) - with small timed regions, does it not
just return garbage because of clock precision issues and overhead of
querying the clock iself?
Richard.
next prev parent reply other threads:[~2011-04-13 9:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 18:50 Lawrence Crowl
2011-04-12 19:06 ` Diego Novillo
2011-04-13 9:19 ` Richard Guenther [this message]
2011-04-13 20:57 ` Lawrence Crowl
2011-04-20 23:33 ` Jason Merrill
2011-04-21 20:38 ` Diego Novillo
2011-04-22 0:40 ` Lawrence Crowl
2011-04-22 2:34 ` Jason Merrill
2011-04-23 0:05 ` Lawrence Crowl
2011-04-24 9:34 ` Jason Merrill
2011-04-27 19:18 ` Lawrence Crowl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=HJtUViEAqaXCwZSa=XFaTxLH+Ww@mail.gmail.com' \
--to=richard.guenther@gmail.com \
--cc=crowl@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).