From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-289645-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 16312 invoked by alias); 15 Apr 2011 20:33:52 -0000
Received: (qmail 16303 invoked by uid 22791); 15 Apr 2011 20:33:52 -0000
X-SWARE-Spam-Status: No, hits=-2.3 required=5.0	tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 15 Apr 2011 20:33:48 +0000
Received: from wpaz9.hot.corp.google.com (wpaz9.hot.corp.google.com [172.24.198.73])	by smtp-out.google.com with ESMTP id p3FKXkvu020380	for <gcc-patches@gcc.gnu.org>; Fri, 15 Apr 2011 13:33:46 -0700
Received: from gwaa12 (gwaa12.prod.google.com [10.200.27.12])	by wpaz9.hot.corp.google.com with ESMTP id p3FKXQfg027302	(version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT)	for <gcc-patches@gcc.gnu.org>; Fri, 15 Apr 2011 13:33:45 -0700
Received: by gwaa12 with SMTP id a12so1291450gwa.28        for <gcc-patches@gcc.gnu.org>; Fri, 15 Apr 2011 13:33:44 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.150.242.2 with SMTP id p2mr3123810ybh.241.1302899624722; Fri, 15 Apr 2011 13:33:44 -0700 (PDT)
Received: by 10.150.212.19 with HTTP; Fri, 15 Apr 2011 13:33:44 -0700 (PDT)
In-Reply-To: <BANLkTin1MMLMRP-FJxN8fS27dPz=9BC90g@mail.gmail.com>
References: <BANLkTimm26r+6FBitPMhBxupXsyEXsO-DA@mail.gmail.com>	<BANLkTikpwRV7Xta3gRY4cmNz1NP6bNy4PA@mail.gmail.com>	<BANLkTin1MMLMRP-FJxN8fS27dPz=9BC90g@mail.gmail.com>
Date: Fri, 15 Apr 2011 21:20:00 -0000
Message-ID: <BANLkTi=HaFXMMSdnr+Hc0oaPyVF8=Cth+g@mail.gmail.com>
Subject: Re: FDO usability trivial patch to fix div by zero error with insane profile
From: Diego Novillo <dnovillo@google.com>
To: Xinliang David Li <davidxl@google.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jan Hubicka <jh@suse.cz>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-04/txt/msg01249.txt.bz2

On Fri, Apr 15, 2011 at 16:21, Xinliang David Li <davidxl@google.com> wrote:
> There is no way to get a test case that can produce the problem in a
> deterministic way. =C2=A0There is really not much for Honza to review
> though :)

The check may be needed somewhere else, you may be papering over the
real issue.  I don't think you are but I don't know the code well
enough to say for sure.


Diego.