From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8711 invoked by alias); 14 Apr 2011 13:53:26 -0000 Received: (qmail 8697 invoked by uid 22791); 14 Apr 2011 13:53:25 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Apr 2011 13:53:21 +0000 Received: from kpbe17.cbf.corp.google.com (kpbe17.cbf.corp.google.com [172.25.105.81]) by smtp-out.google.com with ESMTP id p3EDrKaT024165 for ; Thu, 14 Apr 2011 06:53:20 -0700 Received: from gwb17 (gwb17.prod.google.com [10.200.2.17]) by kpbe17.cbf.corp.google.com with ESMTP id p3EDrIZD002623 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 14 Apr 2011 06:53:19 -0700 Received: by gwb17 with SMTP id 17so882009gwb.29 for ; Thu, 14 Apr 2011 06:53:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.14.15 with SMTP id 15mr1600097ybn.70.1302789198511; Thu, 14 Apr 2011 06:53:18 -0700 (PDT) Received: by 10.150.212.19 with HTTP; Thu, 14 Apr 2011 06:53:18 -0700 (PDT) In-Reply-To: References: Date: Thu, 14 Apr 2011 13:53:00 -0000 Message-ID: Subject: Re: RFA: Gimple calls to "internal" functions From: Diego Novillo To: gcc-patches@gcc.gnu.org, patches@linaro.org, richard.sandiford@linaro.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01069.txt.bz2 On Thu, Apr 14, 2011 at 09:43, Richard Sandiford wrote: > +/* This file specifies a list of internal "functions". =C2=A0These funct= ions > + =C2=A0 differ from built-in functions in that they have no linkage and = cannot > + =C2=A0 be called directly by the user. =C2=A0They represent operations = that are only > + =C2=A0 synthesised by GCC itself. > + > + =C2=A0 Internal functions are used instead of tree codes if the operati= on > + =C2=A0 and its operands are more naturally represented as a GIMPLE_CALL > + =C2=A0 than a GIMPLE_ASSIGN. > + > + =C2=A0 Each entry in this file has the form: > + > + =C2=A0 =C2=A0 DEF_INTERNAL_FN (NAME, FLAGS) > + > + =C2=A0 where NAME is the name of the function and FLAGS is a set of > + =C2=A0 ECF_* flags. =C2=A0*/ Could you add a short description specifying how these internal functions are later expanded into RTL? So, this patch adds no internal functions at all? We need to make sure that internal functions are properly streamed in/out for LTO. So, we should have some test cases for it. The patch looks OK, otherwise. Diego.